Tue, Aug 26, 2014 at 02:23:24PM CEST, ogerl...@mellanox.com wrote:
>On 21/08/2014 19:18, Jiri Pirko wrote:
>>--- a/net/core/rtnetlink.c
>>+++ b/net/core/rtnetlink.c
>>@@ -868,7 +868,7 @@ static noinline size_t if_nlmsg_size(const struct
>>net_device *dev,
>> + rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS +
>> IFLA_PORT_SELF */
>> + rtnl_link_get_size(dev) /* IFLA_LINKINFO */
>> + rtnl_link_get_af_size(dev) /* IFLA_AF_SPEC */
>>- + nla_total_size(MAX_PHYS_PORT_ID_LEN); /* IFLA_PHYS_PORT_ID */
>>+ + nla_total_size(MAX_PHYS_ITEM_ID_LEN); /* IFLA_PHYS_PORT_ID */
>> }
>>
>> static int rtnl_vf_ports_fill(struct sk_buff *skb, struct net_device *dev)
>>@@ -952,7 +952,7 @@ static int rtnl_port_fill(struct sk_buff *skb, struct
>>net_device *dev,
>> static int rtnl_phys_port_id_fill(struct sk_buff *skb, struct net_device
>> *dev)
>> {
>> int err;
>>- struct netdev_phys_port_id ppid;
>>+ struct netdev_phys_item_id ppid;
>>
>> err = dev_get_phys_port_id(dev, &ppid);
>> if (err) {
>>@@ -1196,7 +1196,7 @@ static const struct nla_policy ifla_policy[IFLA_MAX+1]
>>= {
>> [IFLA_PROMISCUITY] = { .type = NLA_U32 },
>> [IFLA_NUM_TX_QUEUES] = { .type = NLA_U32 },
>> [IFLA_NUM_RX_QUEUES] = { .type = NLA_U32 },
>>- [IFLA_PHYS_PORT_ID] = { .type = NLA_BINARY, .len =
>>MAX_PHYS_PORT_ID_LEN },
>>+ [IFLA_PHYS_PORT_ID] = { .type = NLA_BINARY, .len =
>>MAX_PHYS_ITEM_ID_LEN },
>> [IFLA_CARRIER_CHANGES] = { .type = NLA_U32 }, /* ignored */
>> };
>>
>
>just a nit, but if this approach/patch goes in, any reason not to change
>IFLA_PHYS_PORT_ID to IFLA_PHYS_ITEM_ID?
It would be still port_id. No change there. I changed in-kernel struct
name "port"->"item" so it can be reused for switch_id as well.
>
>Or.
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
