Acked-by: Alex Wang
Applied with following change to master, branch-2.3
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index d6b9326..5c4d93b 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -1534,7 +1534,7 @@ ovsdb_idl_txn_commit(struct ovsdb_idl_txn *txn)
bool any_updates;
if (
Applied to master, thanks,
On Thu, May 29, 2014 at 11:25 PM, Ryan Wilson wrote:
> Due to patch fe83f8 (netdev: Remove netdev from global shash when
> the user is changing interface configuration), netdevs can be
> destructed and deallocated by revalidator and RCU threads. When
> netdevs with cl
Bridge, port and interface status changes are not sent to the
database if the connectivity and netdev sequence numbers have not
changed. However, if the previous database transaction fails, then
status changes will not be updated in the database until the
connectivity and netdev sequence numbers ch
Due to patch fe83f8 (netdev: Remove netdev from global shash when
the user is changing interface configuration), netdevs can be
destructed and deallocated by revalidator and RCU threads. When
netdevs with class bsd are destroyed, the rtbsd notifier is
unregistered, possibly causing memory to be fre
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe Stringer.
Cc: Ravi K
Cc: Leo Alterman
Cc: Isaku Yamahata
Cc: Joe Stringer
Signed-off-by: Sim
> Due to patch fe83f8 (netdev: Remove netdev from global shash when
> the user is changing interface configuration), netdevs can be
> destructed and deallocated by revalidator and RCU threads. When
> netdevs with class bsd are destroyed, the rtbsd notifier is
> unregistered, possibly causing memory
Working on setting up a NetBSD environment now, will report back with the
results soon.
Ryan
From: Ben Pfaff mailto:b...@nicira.com>>
Date: Thursday, May 29, 2014 10:37 PM
To: Alex Wang mailto:al...@nicira.com>>
Cc: YAMAMOTO Takashi mailto:yamam...@valinux.co.jp>>,
Ryan Wilson mailto:wr...@nici
Did either of you build test it on BSD? Ideally, we would (but I don't have
a BSD setup myself).
On May 29, 2014 10:32 PM, "Alex Wang" wrote:
>
> Acked-by: Alex Wang
>
> Hey Yamamoto,
>
> FYI, this patch is bsd related.
>
> I'll apply it soon,
>
> Thanks,
> Alex Wang,
>
> ___
If an MPLS packet requires segmentation then use mpls_features
to determine if the software implementation should be used.
As no driver advertises MPLS GSO segmentation this will always be
the case.
I had not noticed that this was necessary before as software MPLS GSO
segmentation was already bei
Acked-by: Alex Wang
Hey Yamamoto,
FYI, this patch is bsd related.
I'll apply it soon,
Thanks,
Alex Wang,
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Dear Sir,
We are manufacturer specializing in aluminum carrying box with competitive
price and good quality.
Please be kindly inform me if you would be interested in our offers,thanks
--
Best regards
Jason
MSAC CO.,LTD
www.ms-aluminumcase.com
www.aluminum-carryingcase
Bridge, port and interface status changes are not sent to the
database if the connectivity and netdev sequence numbers have not
changed. However, if the previous database transaction fails, then
status changes will not be updated in the database until the
connectivity and netdev sequence numbers ch
Thanks for fixing this bug Ryan,
For this round, high level comments:
> -static struct ovsdb_idl_txn *status_txn;
> +static struct ovsdb_idl_txn *update_txn;
> +enum ovsdb_idl_txn_status update_txn_status = TXN_UNCOMMITTED;
>
> /* When the status update transaction returns 'TXN_INCOMPLETE', sh
Pravin,
If we're not really expecting distcleancheck to work as a separate target
from its call in distclean, then this is not worth looking at. It is only a
problem when used separate from distclean.
On 28 May 2014 03:12, Ben Pfaff wrote:
> I don't know anything about these files and it's in
I couldn't measure a difference in TCP_CRR. I dropped that part of the
message from the patch that I sent for master:
http://openvswitch.org/pipermail/dev/2014-May/040863.html
On 28 May 2014 14:33, Joe Stringer wrote:
> Yeah, I'd like to get a gauge of this as well. I'll follow up on this.
>
>
A series of bugs have been identified recently that are caused by a
combination of the awkward flow dump API, possibility of duplicate flows
in a flow dump, and premature optimisation of the revalidator logic.
This patch attempts to simplify the revalidator logic by combining
multiple critical sect
This patch refactors the code around ukey creation and lookup to
simplify the code for callers. A new function ukey_acquire() combines
these functions and attempts to acquire a lock on the ukey. Failure to
acquire a lock on the ukey is usually a sign that another thread is
handling the same flow co
Python's time.time() function uses the system wall clock. However, if NTP resets
the wall clock to be a time in the past, then this causes NVPd threads to poll
block indefinitely since the time is unexpectedly negative.
This patch fixes the issue by using time.monotonic() if Python's version >= 3.
On May 29, 2014, at 10:49 AM, Alex Wang wrote:
> It is actually in a high level,
>
> udpif_revalidator() -> xpthread_barrier_wait()
>
>
If I read the code correctly, the barriers are used to synchronize the
beginning and the end of the actual revalidation, which happens entirely in
revalid
Signed-off-by: Ryan Wilson
---
lib/ovsdb-idl.c | 28 +---
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index 7556b7f..d6b9326 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -23,6 +23,7 @@
#include
#include "
Netdev statistics are not sent to the database if the netdev sequence
number has not changed. However, if the previous database transaction
fails, then netdev statistics will not be updated in the database
until the netdev sequence number changes.
This patch always sends netdev statistics if the l
On May 29, 2014, at 2:09 PM, Ben Pfaff wrote:
> On Thu, May 29, 2014 at 01:56:31PM -0700, Jarno Rajahalme wrote:
>>
>>> On May 29, 2014, at 1:03 PM, Ben Pfaff wrote:
>>>
>>> I think that miniflow_extract() goes a little overboard on the
>>> OVS_LIKELYs. In particular these seem suspicious:
>
On May 29, 2014, at 3:06 PM, Ben Pfaff wrote:
> Jarno, you might want to take a look at this, since it is a simple
> patch that improves the test cases in a way that you suggested.
>
And I wondered why was this not in yet!
Comments below:
> On Wed, May 21, 2014 at 5:05 PM, Ben Pfaff wrote:
>
On May 29, 2014, at 4:37 PM, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme Summary:
> Signed-off-by: Jarno Rajahalme
Sorry about the mess up here…
Jarno___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Factor out the priority vector code from the classifier.
Making the classifier use RCU instead of locking requires parallel
access to the priority vector, pointing to subtables in descending
priority order. When a new subtable is added, a new copy of the
priority vector is allocated, while the cu
This further eases porting existing hmap code to use cmap instead.
The iterator variants taking an explicit cursor are retained (renamed)
as they are needed when iteration is to be continued from the last
iterated node.
Signed-off-by: Jarno Rajahalme
---
lib/cmap.h| 43 +++
Remove unnecessary includes from lib/classifier.h and add them to
lib/classifier.c as needed.
Signed-off-by: Jarno Rajahalme
---
lib/classifier.c |5 +
lib/classifier.h |9 -
2 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/lib/classifier.c b/lib/classifier.c
in
This bug did not manifest due to 'hmap_node' being in the same offset
in both struct cls_partition and struct cls_subtable.
Signed-off-by: Jarno Rajahalme
---
lib/classifier.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/classifier.c b/lib/classifier.c
index 00d47ac
Non-leader revalidator thread uses pthread_barrier_* functions in their
main loop to synchronize with leader thread. However, since those threads
only call poll_block() intermittently, the poll interval check in
poll_block() can wrongly take the time since last call as poll interval
and issue the
On Thu, May 29, 2014 at 3:35 PM, Ansis Atteka wrote:
> On Wed, May 28, 2014 at 2:46 PM, Ben Pfaff wrote:
>> On Wed, May 28, 2014 at 02:40:23PM -0700, Ansis Atteka wrote:
>>> Between fork() and execvp() calls in the process_start()
>>> function both child and parent processes share the same
>>> fi
No rush from my point of view, just going through patchwork.
On Thu, May 29, 2014 at 3:36 PM, Pravin Shelar wrote:
> I will review it by tomorrow.
>
> On Thu, May 29, 2014 at 2:08 PM, Ben Pfaff wrote:
>> This has been sitting in patchwork for a while. I guess that Pravin or
>> Jesse needs to rev
I will review it by tomorrow.
On Thu, May 29, 2014 at 2:08 PM, Ben Pfaff wrote:
> This has been sitting in patchwork for a while. I guess that Pravin or
> Jesse needs to review it?
>
> On Fri, May 16, 2014 at 5:33 PM, Andy Zhou wrote:
>> When deleting a mask from the mask array, we always move t
On Wed, May 28, 2014 at 2:46 PM, Ben Pfaff wrote:
> On Wed, May 28, 2014 at 02:40:23PM -0700, Ansis Atteka wrote:
>> Between fork() and execvp() calls in the process_start()
>> function both child and parent processes share the same
>> file descriptors. This means that, if a child process
>> rece
On Thu, May 29, 2014 at 03:32:05PM -0700, Ansis Atteka wrote:
> Between fork() and execvp() calls in the process_start()
> function both child and parent processes share the same
> file descriptors. This means that, if a child process
> received a signal during this time interval, then it could
>
Between fork() and execvp() calls in the process_start()
function both child and parent processes share the same
file descriptors. This means that, if a child process
received a signal during this time interval, then it could
potentially write data to a shared file descriptor.
One such example is
Jarno, you might want to take a look at this, since it is a simple
patch that improves the test cases in a way that you suggested.
On Wed, May 21, 2014 at 5:05 PM, Ben Pfaff wrote:
> This will only catch core dumps in tests that start and stop ovs-vswitchd,
> but that covers the ones most likely
Thanks for fixing this,~
Applied with following changes as discussed offline:
diff --git a/lib/route-table-stub.c b/lib/route-table-stub.c
index 9acc81c..dab4fd2 100644
--- a/lib/route-table-stub.c
+++ b/lib/route-table-stub.c
@@ -24,13 +24,6 @@ route_table_get_name(ovs_be32 ip OVS_UNUSED, char
n
On Thu, May 29, 2014 at 01:56:31PM -0700, Jarno Rajahalme wrote:
>
> > On May 29, 2014, at 1:03 PM, Ben Pfaff wrote:
> >
> > I think that miniflow_extract() goes a little overboard on the
> > OVS_LIKELYs. In particular these seem suspicious:
> >
> >if (OVS_LIKELY((nw_proto != IPPRO
I agree with the sentiment that it shouldn't be optional; that was my first
thought. Although, feedback from V1 was concerned about additional system
resources required to run it like that.
Perhaps a compromise is to have it configurable like this, but default to
-j8?
On 30 May 2014 08:20, Ethan
This has been sitting in patchwork for a while. I guess that Pravin or
Jesse needs to review it?
On Fri, May 16, 2014 at 5:33 PM, Andy Zhou wrote:
> When deleting a mask from the mask array, we always move the last entry
> into its current location. Another approach can be NULL in its current
> p
Due to patch fe83f8 (netdev: Remove netdev from global shash when
the user is changing interface configuration), netdevs can be
destructed and deallocated by revalidator and RCU threads. When
netdevs with class bsd are destroyed, the rtbsd notifier is
unregistered, possibly causing memory to be fre
This seems reasonable. I'll send a follow-up patch.
On 30 May 2014 08:08, Ethan Jackson wrote:
> So my only comment is that I'd prefer it automagically detect whether
> the user is specifying a test number, or a test name. I've got
> something similar to my personal scripts which essentially d
On Wed, May 28, 2014 at 05:00:48PM -0700, Andy Zhou wrote:
> In case DP_HASH and RECIRC actions need to be executed in slow path,
> current implementation simply don't handle them -- vswitchd simply
> crashes. This patch fixes them by supply an implementation for them.
>
> RECIRC will be handled b
> On May 29, 2014, at 1:03 PM, Ben Pfaff wrote:
>
> I think that miniflow_extract() goes a little overboard on the
> OVS_LIKELYs. In particular these seem suspicious:
>
>if (OVS_LIKELY((nw_proto != IPPROTO_HOPOPTS)
>if (OVS_LIKELY(nw_proto == IPPROTO_TCP)) {
>} else
It's your script. If you tell me it should have a feature that
launches tuxracer, I'm not going to argue ;-)
On Thu, May 29, 2014 at 01:20:03PM -0700, Ethan Jackson wrote:
> Same versions. Looks like I had added this: export
> TESTSUITEFLAGS="-j8" to my bashrc which is why I got parallelism.
>
On Thu, May 29, 2014 at 05:50:12PM -0300, Flavio Leitner wrote:
> On Thu, May 29, 2014 at 01:31:07PM -0700, Ben Pfaff wrote:
> > On Wed, May 28, 2014 at 10:10:34PM -0300, Flavio Leitner wrote:
> > > Signed-off-by: Flavio Leitner
> >
> > I don't know much about IGMP. I see that there are three ve
On Thu, May 29, 2014 at 01:31:07PM -0700, Ben Pfaff wrote:
> On Wed, May 28, 2014 at 10:10:34PM -0300, Flavio Leitner wrote:
> > Signed-off-by: Flavio Leitner
>
> I don't know much about IGMP. I see that there are three versions,
> v1, v2, and v3, and that this patch series only adds support for
Thanks! Applied.
On Thu, May 29, 2014 at 01:41:59PM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> > On May 29, 2014, at 1:34 PM, Ben Pfaff wrote:
> >
> > The comments on the "group" functions had been shamelessly copied without
> > significant update from the corresponding flo
Acked-by: Jarno Rajahalme
> On May 29, 2014, at 1:34 PM, Ben Pfaff wrote:
>
> The comments on the "group" functions had been shamelessly copied without
> significant update from the corresponding flow table functions. This
> commit fixes the errors.
>
> This commit also removes an obsolete co
On Thu, May 29, 2014 at 05:35:33PM -0300, Flavio Leitner wrote:
> On Thu, May 29, 2014 at 01:12:36PM -0700, Ben Pfaff wrote:
> > On Wed, May 28, 2014 at 10:10:29PM -0300, Flavio Leitner wrote:
> > > Add IGMP support to struct flow, flow compose and flow extract.
> > >
> > > Signed-off-by: Flavio L
On Thu, May 29, 2014 at 01:12:36PM -0700, Ben Pfaff wrote:
> On Wed, May 28, 2014 at 10:10:29PM -0300, Flavio Leitner wrote:
> > Add IGMP support to struct flow, flow compose and flow extract.
> >
> > Signed-off-by: Flavio Leitner
>
> The OVS_LIKELY on this line in miniflow_extract() looks weird
The comments on the "group" functions had been shamelessly copied without
significant update from the corresponding flow table functions. This
commit fixes the errors.
This commit also removes an obsolete comment in ofopgroup_complete().
Signed-off-by: Ben Pfaff
---
ofproto/ofproto.c | 29 ++
Applied, thanks!
On Thu, May 29, 2014 at 07:33:31AM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
>
> > On May 28, 2014, at 3:23 PM, Ben Pfaff wrote:
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > ofproto/ofproto-provider.h |2 +-
> > 1 file changed, 1 insertion(+), 1 deletion
You're right, it was slightly odd. Fixed in the next version.
Thanks for the review!
Ryan
On 5/29/14 1:17 PM, "Ethan Jackson" wrote:
>It's kinda weird that route_table_get_ifindex() is a globally
>accessible function which requires a mutex which is internal to the
>module. I think the answer
On Wed, May 28, 2014 at 10:10:33PM -0300, Flavio Leitner wrote:
> If the packet is multicast and the snooping feature is enabled,
> update the multicast snooping database accordingly and send it
> to the right ports.
>
> If the packet is not multicast or the snooping feature is disabled,
> let the
On Wed, May 28, 2014 at 10:10:34PM -0300, Flavio Leitner wrote:
> Signed-off-by: Flavio Leitner
I don't know much about IGMP. I see that there are three versions,
v1, v2, and v3, and that this patch series only adds support for v1
and v2. Is the lack of v3 support a significant limitation in
pr
On Thu, May 29, 2014 at 01:16:31PM -0700, Ben Pfaff wrote:
> On Wed, May 28, 2014 at 10:10:30PM -0300, Flavio Leitner wrote:
> > It follows mac learning, but since the multicast snooping feature
> > can be disabled, the locking is handled in the library.
> >
> > Signed-off-by: Flavio Leitner
>
>
On Wed, May 28, 2014 at 10:10:32PM -0300, Flavio Leitner wrote:
> This patch adds the command 'ovs-appctl mdb/show bridge'
> to show learned groups on a bridge from the multicast
> snooping database.
>
> It also adds the command 'ovs-appctl mdb/flush [bridge]'
> to flush learned groups on a bridge
On Thu, May 29, 2014 at 12:55:24PM -0700, Ben Pfaff wrote:
> On Wed, May 28, 2014 at 10:10:28PM -0300, Flavio Leitner wrote:
> > This patch adds generic IGMP snooping library code
> > that is used in follow-up patches.
> >
> > Signed-off-by: Flavio Leitner
>
> Thanks for v2!
>
> Some structures
Due to patch fe83f8 (netdev: Remove netdev from global shash when
the user is changing interface configuration), netdevs can be
destructed and deallocated by revalidator and RCU threads. When
netdevs with class vport are destroyed, the routing table is
unregistered, possibly causing memory to be fr
On Wed, May 28, 2014 at 10:10:31PM -0300, Flavio Leitner wrote:
> Signed-off-by: Flavio Leitner
The comment in ofproto-provider.h here refers to parameters that are
actually members of struct ofproto_mcast_snooping_settings:
+/* Sets the multicast snooping aging timeout for the OFPP_NORMAL ac
Same versions. Looks like I had added this: export
TESTSUITEFLAGS="-j8" to my bashrc which is why I got parallelism.
I suppose my other comment is that I'd prefer this isn't optional. We
hardcode parallelism for make, we might as well do it for make check.
Ethan
On Thu, May 29, 2014 at 1:17 PM
It's kinda weird that route_table_get_ifindex() is a globally
accessible function which requires a mutex which is internal to the
module. I think the answer is to remove it from the header file and
make it static.
Other than that looks fine.
Acked-by: Ethan Jackson
On Thu, May 29, 2014 at 12:
It doesn't work for me with Autoconf 2.69 and GNU Make 3.81.
What versions are you using?
On Thu, May 29, 2014 at 1:13 PM, Ethan Jackson wrote:
> On my system at leas,t the fact that we pass "-j 8" to make,
> automagically causes the tests to run in parallel already. Does that
> not work for you
On Wed, May 28, 2014 at 10:10:30PM -0300, Flavio Leitner wrote:
> It follows mac learning, but since the multicast snooping feature
> can be disabled, the locking is handled in the library.
>
> Signed-off-by: Flavio Leitner
Needs a rebase, so this is where I stopped doing test builds. Still
rea
On my system at leas,t the fact that we pass "-j 8" to make,
automagically causes the tests to run in parallel already. Does that
not work for you?
Ethan
On Thu, May 29, 2014 at 10:12 AM, Ben Pfaff wrote:
> Ethan, I think you should review this.
>
> On Mon, May 19, 2014 at 3:37 PM, Joe Stringer
On Wed, May 28, 2014 at 10:10:29PM -0300, Flavio Leitner wrote:
> Add IGMP support to struct flow, flow compose and flow extract.
>
> Signed-off-by: Flavio Leitner
The OVS_LIKELY on this line in miniflow_extract() looks weird to me.
I realize that you were just copying what was already there, bu
So my only comment is that I'd prefer it automagically detect whether
the user is specifying a test number, or a test name. I've got
something similar to my personal scripts which essentially does the
following:
if args.test[0].isdigit():
test_flags = args.test
else:
Sorry for the delay, I've reviewed and merged this patch
Ethan
On Thu, May 29, 2014 at 10:10 AM, Ben Pfaff wrote:
> Ethan, are you going to review this? It's a few weeks old.
>
> On Fri, May 9, 2014 at 4:56 PM, Daniele Di Proietto
> wrote:
>> Signed-off-by: Daniele Di Proietto
>> ---
>> util
I think that miniflow_extract() goes a little overboard on the
OVS_LIKELYs. In particular these seem suspicious:
if (OVS_LIKELY((nw_proto != IPPROTO_HOPOPTS)
if (OVS_LIKELY(nw_proto == IPPROTO_TCP)) {
} else if (OVS_LIKELY(nw_proto == IPPROTO_UDP)) {
} else if
On Wed, May 28, 2014 at 10:10:28PM -0300, Flavio Leitner wrote:
> This patch adds generic IGMP snooping library code
> that is used in follow-up patches.
>
> Signed-off-by: Flavio Leitner
Thanks for v2!
Some structures in mcast-learning.h have union members that look like
this:
union {
Due to patch fe83f8 (netdev: Remove netdev from global shash when
the user is changing interface configuration), netdevs can be
destructed and deallocated by revalidator and RCU threads. When
netdevs with class vport are destroyed, the routing table is
unregistered, possibly causing memory to be fr
On Thu, May 29, 2014 at 1:21 AM, YAMAMOTO Takashi
wrote:
>>> what would the new definition of DP_HASH action look like?
>>>
>> flow_hash_5tuple
>
> DP_HASH was defined as "datapath specific hash of the packet".
> my question is what it will be after your proposed change.
It will be the same.
Use
It is actually in a high level,
udpif_revalidator() -> xpthread_barrier_wait()
On Thu, May 29, 2014 at 10:46 AM, Jarno Rajahalme
wrote:
>
> On May 29, 2014, at 10:02 AM, Ben Pfaff wrote:
>
> On Thu, May 29, 2014 at 09:59:44AM -0700, Jarno Rajahalme wrote:
>
>
> On May 29, 2014, at 9:52 AM, Be
On May 29, 2014, at 10:02 AM, Ben Pfaff wrote:
> On Thu, May 29, 2014 at 09:59:44AM -0700, Jarno Rajahalme wrote:
>>
>> On May 29, 2014, at 9:52 AM, Ben Pfaff wrote:
>>
>>> On Wed, May 28, 2014 at 06:55:41PM -0700, Alex Wang wrote:
Since some threads do not call time_poll() regularly in
Ethan, I think you should review this.
On Sun, May 18, 2014 at 9:11 PM, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
> ---
> utilities/ovs-dev.py | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
> index 7a4425f..97fab6c 1007
Ethan, I think you should review this.
On Mon, May 19, 2014 at 3:37 PM, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
> ---
> v2: Make it configurable.
> ---
> utilities/ovs-dev.py |4
> 1 file changed, 4 insertions(+)
>
> diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
>
Ethan, are you going to review this? It's a few weeks old.
On Fri, May 9, 2014 at 4:56 PM, Daniele Di Proietto
wrote:
> Signed-off-by: Daniele Di Proietto
> ---
> utilities/ovs-dev.py | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git a/utilities/ovs-dev.py b/utilities
>
>
> Is this just because of the xpthread_barrier_wait() calls? It might
> be nice to instead write our own poll_block()-able barriers.
>
Yes, let me explore a bit.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, May 29, 2014 at 09:59:44AM -0700, Jarno Rajahalme wrote:
>
> On May 29, 2014, at 9:52 AM, Ben Pfaff wrote:
>
> > On Wed, May 28, 2014 at 06:55:41PM -0700, Alex Wang wrote:
> >> Since some threads do not call time_poll() regularly in their main loop
> >> (e.g. non-leader revalidator threa
On May 29, 2014, at 9:52 AM, Ben Pfaff wrote:
> On Wed, May 28, 2014 at 06:55:41PM -0700, Alex Wang wrote:
>> Since some threads do not call time_poll() regularly in their main loop
>> (e.g. non-leader revalidator threads), their intermittent invocation of
>> time_poll() in other modules can cau
On Wed, May 28, 2014 at 06:55:41PM -0700, Alex Wang wrote:
> Since some threads do not call time_poll() regularly in their main loop
> (e.g. non-leader revalidator threads), their intermittent invocation of
> time_poll() in other modules can cause warnings like below:
>
> "Unreasonably long 16518m
Thanks for the patch! This fixes the same issue with GCC 4.6 as well.
Pushed to master,
Jarno
On May 29, 2014, at 1:12 AM, YAMAMOTO Takashi wrote:
> This ends up to add -std=gnu99 and fixes the following
> compilation problem introduced by commit 08feeb75.
> ("lib/flow: Use C99 declaration i
Acked-by: Jarno Rajahalme
> On May 28, 2014, at 3:23 PM, Ben Pfaff wrote:
>
> Signed-off-by: Ben Pfaff
> ---
> ofproto/ofproto-provider.h |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ofproto/ofproto-provider.h b/ofproto/ofproto-provider.h
> index ceeda64..ff539b
>> what would the new definition of DP_HASH action look like?
>>
> flow_hash_5tuple
DP_HASH was defined as "datapath specific hash of the packet".
my question is what it will be after your proposed change.
YAMAMOTO Takashi
___
dev mailing list
dev@openv
This ends up to add -std=gnu99 and fixes the following
compilation problem introduced by commit 08feeb75.
("lib/flow: Use C99 declaration in for statement.")
libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I ../include -I ../lib -I
./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpoin
86 matches
Mail list logo
