Sorry for the delay, I've reviewed and merged this patch
Ethan
On Thu, May 29, 2014 at 10:10 AM, Ben Pfaff <b...@nicira.com> wrote:
> Ethan, are you going to review this? It's a few weeks old.
>
> On Fri, May 9, 2014 at 4:56 PM, Daniele Di Proietto
> <ddiproie...@vmware.com> wrote:
>> Signed-off-by: Daniele Di Proietto <ddiproie...@vmware.com>
>> ---
>> utilities/ovs-dev.py | 19 +++++++++++++++++++
>> 1 file changed, 19 insertions(+)
>>
>> diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
>> index 7a4425f..814a9d0 100755
>> --- a/utilities/ovs-dev.py
>> +++ b/utilities/ovs-dev.py
>> @@ -224,6 +224,12 @@ def run():
>> % (root_uuid, version))
>>
>> cmd = [BUILD_GCC + "/vswitchd/ovs-vswitchd"]
>> +
>> + if options.dpdk:
>> + cmd.append("--dpdk")
>> + cmd.extend(options.dpdk)
>> + cmd.append("--")
>> +
>> if options.gdb:
>> cmd = ["gdb", "--args"] + cmd
>> elif options.valgrind:
>> @@ -312,6 +318,16 @@ Commands:
>> sys.exit(0)
>> commands.append(doc)
>>
>> +def parse_subargs(option, opt_str, value, parser):
>> + subopts = []
>> +
>> + while parser.rargs:
>> + dpdkarg = parser.rargs.pop(0)
>> + if dpdkarg == "--":
>> + break
>> + subopts.append(dpdkarg)
>> +
>> + setattr(parser.values, option.dest, subopts)
>>
>> def main():
>> global options
>> @@ -344,6 +360,9 @@ def main():
>> help="run ovs-vswitchd under gdb")
>> group.add_option("--valgrind", dest="valgrind", action="store_true",
>> help="run ovs-vswitchd under valgrind")
>> + group.add_option("--dpdk", dest="dpdk", action="callback",
>> + callback=parse_subargs,
>> + help="run ovs-vswitchd with dpdk subopts (ended by
>> --)")
>> parser.add_option_group(group)
>>
>> options, args = parser.parse_args()
>> --
>> 2.0.0.rc0
>>
>> _______________________________________________
>> dev mailing list
>> dev@openvswitch.org
>> http://openvswitch.org/mailman/listinfo/dev
>
>
>
> --
> "I don't normally do acked-by's. I think it's my way of avoiding
> getting blamed when it all blows up." Andrew Morton
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
