Thanks for the patch! This fixes the same issue with GCC 4.6 as well.
Pushed to master,
Jarno
On May 29, 2014, at 1:12 AM, YAMAMOTO Takashi <yamam...@valinux.co.jp> wrote:
> This ends up to add -std=gnu99 and fixes the following
> compilation problem introduced by commit 08feeb75.
> ("lib/flow: Use C99 declaration in for statement.")
>
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I ../include -I ../lib -I
> ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
> -Wno-format-zero-length -Wswitch-enum -Wunused-parameter -Wstrict-aliasing
> -Wbad-function-cast -Wcast-align -Wmissing-prototypes
> -Wmissing-field-initializers -g -O2 -MT lib/classifier.lo -MD -MP -MF
> lib/.deps/classifier.Tpo -c ../lib/classifier.c -o lib/classifier.o
> ../lib/classifier.c: In function 'miniflow_and_mask_matches_flow':
> ../lib/classifier.c:1722:5: error: 'for' loop initial declarations are only
> allowed in C99 mode
> ../lib/classifier.c:1722:5: note: use option -std=c99 or -std=gnu99 to
> compile your code
> Makefile:3013: recipe for target 'lib/classifier.lo' failed
>
> % gcc --version
> gcc (NetBSD nb1 20120916) 4.5.4
> Copyright (C) 2010 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> Signed-off-by: YAMAMOTO Takashi <yamam...@valinux.co.jp>
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index 4bf69e8..9a86507 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -21,7 +21,7 @@ AC_CONFIG_HEADERS([config.h])
> AC_CONFIG_TESTDIR([tests])
> AM_INIT_AUTOMAKE
>
> -AC_PROG_CC
> +AC_PROG_CC_C99
> AM_PROG_CC_C_O
> AC_PROG_CPP
> AC_PROG_MKDIR_P
> --
> 1.8.3.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
