On Thu, May 29, 2014 at 01:16:31PM -0700, Ben Pfaff wrote: > On Wed, May 28, 2014 at 10:10:30PM -0300, Flavio Leitner wrote: > > It follows mac learning, but since the multicast snooping feature > > can be disabled, the locking is handled in the library. > > > > Signed-off-by: Flavio Leitner <f...@redhat.com> > > Needs a rebase, so this is where I stopped doing test builds. Still > reading the diffs, though.
I did rebase, tested and sent. I guess something has changed in the middle :) > Please capitalize the first letter of the new comment, matching the > style: > REV_FLOW_TABLE, /* Flow table changed. */ > REV_MAC_LEARNING, /* Mac learning changed. */ > + REV_MCAST_SNOOPING, /* multicast snooping changed. */ Ok. > }; > COVERAGE_DEFINE(rev_reconfigure); > COVERAGE_DEFINE(rev_stp); > > Looks good otherwise. Good, thanks fbl _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
