On Thu, May 29, 2014 at 01:12:36PM -0700, Ben Pfaff wrote:
> On Wed, May 28, 2014 at 10:10:29PM -0300, Flavio Leitner wrote:
> > Add IGMP support to struct flow, flow compose and flow extract.
> >
> > Signed-off-by: Flavio Leitner <f...@redhat.com>
>
> The OVS_LIKELY on this line in miniflow_extract() looks weird to me.
> I realize that you were just copying what was already there, but that
> looked weird to me too:
> > + } else if (OVS_LIKELY(nw_proto == IPPROTO_IGMP)) {
> I sent out a message to ask about the existing style:
> http://openvswitch.org/pipermail/dev/2014-May/040810.html
I agree, but I didn't want to be an exception there.
So, I think I should use whatever style is being used when posting v3?
> I think that this patch should add IGMP support to match_format().
> Otherwise ofp_packet_to_string() won't be able to print IGMP fields,
> which could be important for debugging.
I will take a look.
> Otherwise it looks good, thank you!
Thanks!
fbl
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
