On Wed, May 28, 2014 at 10:10:31PM -0300, Flavio Leitner wrote: > Signed-off-by: Flavio Leitner <f...@redhat.com>
The comment in ofproto-provider.h here refers to parameters that are actually members of struct ofproto_mcast_snooping_settings: + /* Sets the multicast snooping aging timeout for the OFPP_NORMAL action + * to 'idle_time', in seconds, and the maximum number of multicast snooping + * table entries to 'max_entries'. + * + * An implementation that doesn't support configuring these features may + * set this function to NULL or implement it as a no-op. */ + int (*set_mcast_snooping)(struct ofproto *ofproto, + const struct ofproto_mcast_snooping_settings *s); The comment on 'set_mcast_snooping_port' does not mention the 'aux' parameter. The comment on ofproto_port_set_mcast_snooping() calls the 'aux' parameter 'ofp_port'. In the definition of struct ofproto_mcast_snooping_settings, I would mention the unit for 'idle_time' (seconds?). Thanks, Ben. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
