Re: Review Request 24704: Patch for KAFKA-1499

> On Feb. 27, 2015, 10:53 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/message/CompressionCodec.scala, line 46 > > > > > > Not sure what you mean - can you elaborate? > > Jun Rao wrote: > Instead of conta

Re: Review Request 24704: Patch for KAFKA-1499

> On Feb. 27, 2015, 10:53 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/message/CompressionCodec.scala, line 46 > > > > > > Not sure what you mean - can you elaborate? Instead of contains((compressionType.toLo

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review74615 --- core/src/main/scala/kafka/message/CompressionCodec.scala

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review74612 --- Sorry for the late review. Just a minor comment below. core/src/ma

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review67954 --- Ship it! - Joel Koshy On Dec. 26, 2014, 4:09 p.m., Manikumar Redd

Re: Review Request 24704: Patch for KAFKA-1499

> On Dec. 17, 2014, 1:57 p.m., Joel Koshy wrote: > > core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala, line 67 > > > > > > `...should produce " + readMessage(0).compressionCodec` i didnt find any issue h

Re: Review Request 24704: Patch for KAFKA-1499

> On Dec. 18, 2014, 4:30 a.m., Eric Olander wrote: > > core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala, line 78 > > > > > > A more Scala-like implementation is: > > > > def parameters = { > >

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Dec. 26, 2014, 4:09 p.m.) Review request for kafka. Bugs: KAFKA-1499

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review65450 --- core/src/main/scala/kafka/message/BrokerCompression.scala

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review65316 --- Overall, looks good. I do have a bit of a concern on having to maint

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review65223 --- Ship it! Ship It! - Jonathan Creasy On Dec. 16, 2014, 5:10 p.m.,

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review65221 --- core/src/main/scala/kafka/log/Log.scala

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Dec. 16, 2014, 5:10 p.m.) Review request for kafka. Bugs: KAFKA-1499

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Oct. 26, 2014, 7:44 a.m.) Review request for kafka. Bugs: KAFKA-1499

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54636 --- Ship it! Ship It! - Joel Koshy On Sept. 25, 2014, 5:38 a.m., Man

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54513 --- Ship it! Ship It! - Jonathan Creasy On Sept. 25, 2014, 5:38 a.m.

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Sept. 25, 2014, 5:38 a.m.) Review request for kafka. Bugs: KAFKA-149

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54423 --- Ship it! Ship It! - Joel Koshy On Sept. 24, 2014, 8:57 a.m., Man

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54421 --- core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala

Re: Review Request 24704: Patch for KAFKA-1499

> On Sept. 23, 2014, 8:51 p.m., Joel Koshy wrote: > > core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala, line 69 > > > > > > Can you fix all the whitespace inconsistencies in this patch? We > > generally u

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Sept. 24, 2014, 8:57 a.m.) Review request for kafka. Bugs: KAFKA-149

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Sept. 24, 2014, 8:52 a.m.) Review request for kafka. Bugs: KAFKA-149

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54327 --- core/src/main/scala/kafka/log/Log.scala

Re: Review Request 24704: Patch for KAFKA-1499

> On Sept. 23, 2014, 6:45 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala, line 205 > > > > > > If the message set is uncompressed and the broker-side config is set to > > enab

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Sept. 23, 2014, 9:17 a.m.) Review request for kafka. Bugs: KAFKA-149

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54255 --- core/src/main/scala/kafka/message/ByteBufferMessageSet.scala

Re: Review Request 24704: Patch for KAFKA-1499

> On Sept. 19, 2014, 8:26 p.m., Joel Koshy wrote: > > core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala, line 55 > > > > > > Should this just be part of LogTest instead? I used parameterized test to test a

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Sept. 21, 2014, 10:30 a.m.) Review request for kafka. Bugs: KAFKA-14

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54016 --- core/src/main/scala/kafka/message/ByteBufferMessageSet.scala

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Aug. 21, 2014, 4:17 p.m.) Review request for kafka. Bugs: KAFKA-1499

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 14, 2014, 9:52 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 323 > > > > > > Can we just call the config compression.type? Also, the default value > > of NoCompressi

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 14, 2014, 9:52 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 323 > > > > > > Can we just call the config compression.type? Also, the default value > > of NoCompressi

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 14, 2014, 9:52 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 323 > > > > > > Can we just call the config compression.type? Also, the default value > > of NoCompressi

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 14, 2014, 9:52 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 323 > > > > > > Can we just call the config compression.type? Also, the default value > > of NoCompressi

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 14, 2014, 9:52 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 323 > > > > > > Can we just call the config compression.type? Also, the default value > > of NoCompressi

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 14, 2014, 9:52 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 323 > > > > > > Can we just call the config compression.type? Also, the default value > > of NoCompressi

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 15, 2014, 12:52 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/log/Log.scala, line 263 > > > > > > As summarized in the ticket description we should have per-topic > > overrides as well. If the topic'

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 15, 2014, 12:52 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/log/Log.scala, line 263 > > > > > > As summarized in the ticket description we should have per-topic > > overrides as well. If the topic'

Re: Review Request 24704: Patch for KAFKA-1499

> On Aug. 14, 2014, 9:52 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaConfig.scala, line 323 > > > > > > Can we just call the config compression.type? Also, the default value > > of NoCompressi

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Aug. 15, 2014, 8:53 a.m.) Review request for kafka. Bugs: KAFKA-1499

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review50675 --- Thanks for the patch. core/src/main/scala/kafka/log/Log.scala

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review50651 --- core/src/main/scala/kafka/server/KafkaConfig.scala

Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- Review request for kafka. Bugs: KAFKA-1499 https://issues.apache.org/jira/b