----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54327 -----------------------------------------------------------
core/src/main/scala/kafka/log/Log.scala <https://reviews.apache.org/r/24704/#comment94437> minor nit: would prefer that we make source codec the first argument (only because source appearing on the left side; source -> target seems more natural) core/src/main/scala/kafka/log/Log.scala <https://reviews.apache.org/r/24704/#comment94438> (just like this) core/src/main/scala/kafka/log/Log.scala <https://reviews.apache.org/r/24704/#comment94439> Another minor comment. This can be written as: val targetCodec = if (config.enableBrokerCompression) config.compressionType else sourceCodec core/src/main/scala/kafka/message/ByteBufferMessageSet.scala <https://reviews.apache.org/r/24704/#comment94446> Thanks for making this change - looks much clearer. Just the minor edit that I suggested above wrt ordering of the arguments. core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala <https://reviews.apache.org/r/24704/#comment94444> whitespace core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala <https://reviews.apache.org/r/24704/#comment94442> Can you fix all the whitespace inconsistencies in this patch? We generally use two space indentation on scala - however, there are a bunch of places in this patch where there is a mix of two-space/four-space indent. - Joel Koshy On Sept. 23, 2014, 9:17 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24704/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 9:17 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1499 > https://issues.apache.org/jira/browse/KAFKA-1499 > > > Repository: kafka > > > Description > ------- > > Addresing Joel's comments > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 0ddf97bd30311b6039e19abade41d2fbbad2f59b > core/src/main/scala/kafka/log/LogConfig.scala > 5746ad4767589594f904aa085131dd95e56d72bb > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala > 788c7864bc881b935975ab4a4e877b690e65f1f1 > core/src/main/scala/kafka/server/KafkaConfig.scala > 165c816a9f4c925f6e46560e7e2ff9cf7591946b > core/src/main/scala/kafka/server/KafkaServer.scala > 390fef500d7e0027e698c259d777454ba5a0f5e8 > core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala PRE-CREATION > core/src/test/scala/unit/kafka/message/ByteBufferMessageSetTest.scala > 4e45d965bc423192ac704883ee75e9727006f89b > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > 2377abe4933e065d037828a214c3a87e1773a8ef > > Diff: https://reviews.apache.org/r/24704/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
