> On Sept. 23, 2014, 6:45 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala, line 205 > > <https://reviews.apache.org/r/24704/diff/7/?file=699221#file699221line205> > > > > If the message set is uncompressed and the broker-side config is set to > > enable broker-side compression but the compression type is uncompressed it > > will still make a copy - right? > > > > Would it be clearer to just change the (existing) second parameter to > > targetCodec and the new parameter to sourceCodec? So the condition would be > > (if (sourceCodec == NoCompressionCodec && targetCodec == > > NoCompressionCodec) // do in-place conversion)
Ok..agreed.. done the required chnages - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54255 ----------------------------------------------------------- On Sept. 23, 2014, 9:17 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24704/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 9:17 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1499 > https://issues.apache.org/jira/browse/KAFKA-1499 > > > Repository: kafka > > > Description > ------- > > Addresing Joel's comments > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 0ddf97bd30311b6039e19abade41d2fbbad2f59b > core/src/main/scala/kafka/log/LogConfig.scala > 5746ad4767589594f904aa085131dd95e56d72bb > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala > 788c7864bc881b935975ab4a4e877b690e65f1f1 > core/src/main/scala/kafka/server/KafkaConfig.scala > 165c816a9f4c925f6e46560e7e2ff9cf7591946b > core/src/main/scala/kafka/server/KafkaServer.scala > 390fef500d7e0027e698c259d777454ba5a0f5e8 > core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala PRE-CREATION > core/src/test/scala/unit/kafka/message/ByteBufferMessageSetTest.scala > 4e45d965bc423192ac704883ee75e9727006f89b > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > 2377abe4933e065d037828a214c3a87e1773a8ef > > Diff: https://reviews.apache.org/r/24704/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
