> On Dec. 17, 2014, 1:57 p.m., Joel Koshy wrote: > > core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala, line 67 > > <https://reviews.apache.org/r/24704/diff/13/?file=793051#file793051line67> > > > > `...should produce " + readMessage(0).compressionCodec`
i didnt find any issue here > On Dec. 17, 2014, 1:57 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/message/BrokerCompression.scala, line 20 > > <https://reviews.apache.org/r/24704/diff/13/?file=793046#file793046line20> > > > > Can you think of a way to avoid having to maintain this distinctly from > > CompressionCodec.scala? > > > > E.g., one thought is to have a separate BrokerCompressionCodec sealed > > trait in that class; have all the existing codecs extend from both > > CompressionCodec and BrokerCompressionCodec and the new > > ProducerCompressionCodec only extend from BrokerCompressionCodec > > > > (or see if there is an altogether different better way) Joel, i implemented your suggestion here. Merged the new BrokerCompression code to existing CompressionCodec.scala. Pl let me know if any changes are required. - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review65316 ----------------------------------------------------------- On Dec. 26, 2014, 4:09 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24704/ > ----------------------------------------------------------- > > (Updated Dec. 26, 2014, 4:09 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1499 > https://issues.apache.org/jira/browse/KAFKA-1499 > > > Repository: kafka > > > Description > ------- > > Support given for Broker-side compression, Addersing Joel's comments > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 024506cd00556a0037c0b3b6b603da32968b69ab > core/src/main/scala/kafka/log/LogConfig.scala > ca7a99e99f641b2694848b88bf4ae94657071d03 > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala > 788c7864bc881b935975ab4a4e877b690e65f1f1 > core/src/main/scala/kafka/message/CompressionCodec.scala > 9439d2bc29a0c2327085f08577c6ce1b01db1489 > core/src/main/scala/kafka/server/KafkaConfig.scala > 6e26c5436feb4629d17f199011f3ebb674aa767f > core/src/main/scala/kafka/server/KafkaServer.scala > 1bf7d10cef23a77e716666eb16bf6d0e68bc4ebe > core/src/test/scala/kafka/log/LogConfigTest.scala > 99b0df7b69c5e0a1b6251c54592c6ef63b1800fe > core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala PRE-CREATION > core/src/test/scala/unit/kafka/message/ByteBufferMessageSetTest.scala > 4e45d965bc423192ac704883ee75e9727006f89b > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > 2377abe4933e065d037828a214c3a87e1773a8ef > > Diff: https://reviews.apache.org/r/24704/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
