----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54016 -----------------------------------------------------------
core/src/main/scala/kafka/message/ByteBufferMessageSet.scala <https://reviews.apache.org/r/24704/#comment93885> We can still do an in-place conversion if the messages are uncompressed and broker-side compression is disabled right? Otherwise we are _always_ copying the messages. core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala <https://reviews.apache.org/r/24704/#comment93887> Should this just be part of LogTest instead? - Joel Koshy On Aug. 21, 2014, 4:17 p.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24704/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2014, 4:17 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1499 > https://issues.apache.org/jira/browse/KAFKA-1499 > > > Repository: kafka > > > Description > ------- > > Addressing Joel's comments. Introduced new config properties > broker.compression.enable, broker.compression.type. > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 0ddf97bd30311b6039e19abade41d2fbbad2f59b > core/src/main/scala/kafka/log/LogConfig.scala > 5746ad4767589594f904aa085131dd95e56d72bb > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala > 788c7864bc881b935975ab4a4e877b690e65f1f1 > core/src/main/scala/kafka/server/KafkaConfig.scala > 1a45f8716ccc0398cf9395d91d66199d16882aae > core/src/main/scala/kafka/server/KafkaServer.scala > 28711182aaa70eaa623de858bc063cb2613b2a4d > core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala PRE-CREATION > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > 2377abe4933e065d037828a214c3a87e1773a8ef > > Diff: https://reviews.apache.org/r/24704/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
