> On Sept. 19, 2014, 8:26 p.m., Joel Koshy wrote: > > core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala, line 55 > > <https://reviews.apache.org/r/24704/diff/6/?file=666213#file666213line55> > > > > Should this just be part of LogTest instead?
I used parameterized test to test all the posible senarios. So created new test class. > On Sept. 19, 2014, 8:26 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala, line 206 > > <https://reviews.apache.org/r/24704/diff/6/?file=666210#file666210line206> > > > > We can still do an in-place conversion if the messages are uncompressed > > and broker-side compression is disabled right? Otherwise we are _always_ > > copying the messages. Ok..Initially I tried to minimize the changes. Done few changes to support in-place conversion of messages. - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54016 ----------------------------------------------------------- On Sept. 21, 2014, 10:30 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24704/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2014, 10:30 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1499 > https://issues.apache.org/jira/browse/KAFKA-1499 > > > Repository: kafka > > > Description > ------- > > Addresing Joel's comments > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 0ddf97bd30311b6039e19abade41d2fbbad2f59b > core/src/main/scala/kafka/log/LogConfig.scala > 5746ad4767589594f904aa085131dd95e56d72bb > core/src/main/scala/kafka/message/ByteBufferMessageSet.scala > 788c7864bc881b935975ab4a4e877b690e65f1f1 > core/src/main/scala/kafka/server/KafkaConfig.scala > 165c816a9f4c925f6e46560e7e2ff9cf7591946b > core/src/main/scala/kafka/server/KafkaServer.scala > 390fef500d7e0027e698c259d777454ba5a0f5e8 > core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala PRE-CREATION > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > 2377abe4933e065d037828a214c3a87e1773a8ef > > Diff: https://reviews.apache.org/r/24704/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
