> On Aug. 15, 2014, 12:52 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/log/Log.scala, line 263 > > <https://reviews.apache.org/r/24704/diff/1/?file=660643#file660643line263> > > > > As summarized in the ticket description we should have per-topic > > overrides as well. If the topic's config has an explicit override to use a > > specific compression type then we should use that. Or would you like to do > > this in a follow-up patch?
This patch includes per-topic override also. Pl check diff of LogConfig.java. per-topic config property name is "compression.type" > On Aug. 15, 2014, 12:52 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/log/Log.scala, line 317 > > <https://reviews.apache.org/r/24704/diff/1/?file=660643#file660643line317> > > > > Rather than make this a var can this be set correctly up front? i.e., I > > think in analyzeAndValidateMessageSet Agreed. moved code to analyzeAndValidateMessageSet method > On Aug. 15, 2014, 12:52 a.m., Joel Koshy wrote: > > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala, line 19 > > <https://reviews.apache.org/r/24704/diff/1/?file=660647#file660647line19> > > > > Can you also add a test to LogTest - i.e., that the feature actually > > works? ok. I added a test case. - Manikumar Reddy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review50675 ----------------------------------------------------------- On Aug. 15, 2014, 8:53 a.m., Manikumar Reddy O wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24704/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 8:53 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1499 > https://issues.apache.org/jira/browse/KAFKA-1499 > > > Repository: kafka > > > Description > ------- > > Addressing Neha's,Joel's comments > > > Diffs > ----- > > core/src/main/scala/kafka/log/Log.scala > 0ddf97bd30311b6039e19abade41d2fbbad2f59b > core/src/main/scala/kafka/log/LogConfig.scala > 5746ad4767589594f904aa085131dd95e56d72bb > core/src/main/scala/kafka/server/KafkaConfig.scala > 1a45f8716ccc0398cf9395d91d66199d16882aae > core/src/main/scala/kafka/server/KafkaServer.scala > 28711182aaa70eaa623de858bc063cb2613b2a4d > core/src/test/scala/unit/kafka/log/LogTest.scala > 577d102fc2eb6bb1a72326141ecd431db6d66f04 > core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala > 2377abe4933e065d037828a214c3a87e1773a8ef > > Diff: https://reviews.apache.org/r/24704/diff/ > > > Testing > ------- > > > Thanks, > > Manikumar Reddy O > >
