vismayku commented on PR #416:
URL:
https://github.com/apache/httpcomponents-core/pull/416#issuecomment-1688236548
@ok2c Sorry for the ping but I have a follow up question.
I also want to contribute similar change to 4.x major version. Which
specific major-minor version I should work on?
ok2c commented on PR #416:
URL:
https://github.com/apache/httpcomponents-core/pull/416#issuecomment-1688580065
> @ok2c Sorry for the ping but I have a follow up question. I also want to
contribute similar change to 4.x major version. Which specific major-minor
version I should work on?
arturobernalg opened a new pull request, #418:
URL: https://github.com/apache/httpcomponents-core/pull/418
Description:
This pull request addresses the recommendations set out in RFC 9110
regarding the deprecation of the userInfo subcomponent in "http" or "https"
URIs.
Changes
michael-o commented on code in PR #418:
URL:
https://github.com/apache/httpcomponents-core/pull/418#discussion_r1304790613
##
httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java:
##
@@ -155,7 +148,7 @@ public URIAuthority(final String hostname) {
}
pub
arturobernalg commented on code in PR #418:
URL:
https://github.com/apache/httpcomponents-core/pull/418#discussion_r1305308816
##
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java:
##
@@ -156,7 +155,7 @@ public URIBuilder setAuthority(final NamedEndpoint
authorit
arturobernalg opened a new pull request, #419:
URL: https://github.com/apache/httpcomponents-core/pull/419
Refactor `testConcurrentOperations` to use `AtomicBooleans` for outcome
verification, enhancing test determinism and reducing exception
unpredictability.
--
This is an automated mes
ok2c commented on PR #418:
URL:
https://github.com/apache/httpcomponents-core/pull/418#issuecomment-1693338496
@arturobernalg I am fine with all the proposed changes but I personally
think that `URIBuilder` should still support user info as it is not meant to be
strictly `http`/`https` spe
arturobernalg commented on PR #419:
URL:
https://github.com/apache/httpcomponents-core/pull/419#issuecomment-1693359992
> @arturobernalg Interesting. Future callbacks are deterministic but the
future itself is not?
@ok2c
With `` AtomicBoolean` ensures we can deterministically t
arturobernalg commented on PR #418:
URL:
https://github.com/apache/httpcomponents-core/pull/418#issuecomment-1693409507
> @arturobernalg I am fine with all the proposed changes but I personally
think that `URIBuilder` should still support user info as it is not meant to be
strictly `http`/
michael-o commented on PR #418:
URL:
https://github.com/apache/httpcomponents-core/pull/418#issuecomment-1693435870
> > @arturobernalg I am fine with all the proposed changes but I personally
think that `URIBuilder` should still support user info as it is not meant to be
strictly `http`/`h
dependabot[bot] opened a new pull request, #420:
URL: https://github.com/apache/httpcomponents-core/pull/420
Bumps [io.reactivex.rxjava3:rxjava](https://github.com/ReactiveX/RxJava)
from 3.1.6 to 3.1.7.
Release notes
Sourced from https://github.com/ReactiveX/RxJava/releases";>io.re
bpitman opened a new pull request, #421:
URL: https://github.com/apache/httpcomponents-core/pull/421
Note that this patch is probably incomplete - it does not break existing
tests, but no tests were added nor updated to verify the new code.
We have a need to set the InetAddress for a
ok2c commented on PR #419:
URL:
https://github.com/apache/httpcomponents-core/pull/419#issuecomment-1693665913
> Maybe I'm wrong but BasicFuture operations are inherently non-deterministic
@arturobernalg It was not my intent when I initially built `BasicFuture` but
this is likely how
arturobernalg merged PR #419:
URL: https://github.com/apache/httpcomponents-core/pull/419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
bpitman commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1693678024
I ran locally with `-Djapicmp.skip=true` (needed with `package`, but not
`test`). Is there a mechanism for documenting known changes to the api?
--
This is an automated mess
ok2c commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1693692150
@bpitman What is exactly the intent of this change? Why do you think you
need an `InetAddress` at the request level? It is completely unclear from the
description of the PR or fro
bpitman commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1693695500
See initial comment:
```
We have a need to set the InetAddress for a request - the ip tells us where
to connect and the hostname is needed for ssl verification.
```
bpitman commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1693712807
Example data for a request:
```
{
"state": "RUNNING",
"status": "UP",
"name": "upload",
"hostname": "192.168.30.10",
"ip": "192.168.30.10",
"s
ok2c commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1693714227
> We have a need to set the InetAddress for a request - the ip tells us
where to connect and the hostname is needed for ssl verification.
@bpitman This makes no sense at the
ok2c commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1693731633
@bpitman In your particular case you do not even need any custom code. All
you need to do is to set up the connection route correctly.
```
final HttpHost target = new HttpHos
bpitman commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1693765595
It would have saved me a lot of time if this had worked. Having InetAddress
in HttpHost made it seem like it supported my needs right out of the box. Look
at my changes to se
bpitman commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1693771484
To be clear, I'm using httpcore5, not httpclient5. The client looks like
non-blocking wrappers around around blocking code - though, maybe just poor
examples? We can't expect
ok2c commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1693869120
> To be clear, I'm using httpcore5, not httpclient5.
@bpitman You should have started off by saying that. HttpClient has a by far
more complex and sophisticated connection m
bpitman commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1694006616
Messing around with client examples. The target ends up wrong if HttpHost
is part of the request object, but works if passed in directly to
client.execute() - as you suggested
bpitman commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1694123536
The fixes in the pr address all of these use cases using core5 directly.
client5 is still broken - it needs similar fixes (rebuild the HttpHost using
address info that had bee
garydgregory commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1694132384
Shouldn't we use builders instead of adding yet even more constructors?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
bpitman commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1694137687
Generally, yes. This doesn't look like a typical builder pattern, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
ok2c commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1694220125
You are going about it all wrong. You are mixing up message composition and
message routing responsibilities. Request builders build messages. They do not
make connection setup an
ok2c closed pull request #421: Support InetAddress throughout request execution
URL: https://github.com/apache/httpcomponents-core/pull/421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
ok2c opened a new pull request, #422:
URL: https://github.com/apache/httpcomponents-core/pull/422
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
ok2c commented on PR #421:
URL:
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1694268016
@bpitman Superseded by #422 Feel to free to review / test / comment upon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
garydgregory commented on code in PR #422:
URL:
https://github.com/apache/httpcomponents-core/pull/422#discussion_r1306408906
##
httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2MultiplexingRequester.java:
##
@@ -128,18 +130,38 @@ public Cancellable exe
ok2c opened a new pull request, #478:
URL: https://github.com/apache/httpcomponents-client/pull/478
Added internal cache storage implementation that can be used to implement
custom cache storage backends with specific cache entry eviction strategy.
@arturobernalg Please review.
--
bpitman commented on PR #422:
URL:
https://github.com/apache/httpcomponents-core/pull/422#issuecomment-1694405377
Passing on intent from PR 421: I understand that you want no more
connection/tls configuration in HttpRequest beyond what can be expressed in
URI. In this case, why does the
ok2c commented on PR #422:
URL:
https://github.com/apache/httpcomponents-core/pull/422#issuecomment-1694407530
@bpitman
The `#setHttpHost` method is merely a convenience method that copies the
protocol scheme and the authority in one go from an existing `HttpHost`. I am
not sure I
arturobernalg opened a new pull request, #423:
URL: https://github.com/apache/httpcomponents-core/pull/423
This PR brings our `URIBuilder` in line with the standards set by RFC 9110,
specifically Section 4.2.2 regarding HTTPS URIs.
Changes:
Implemented a check to ensure `ht
arturobernalg commented on code in PR #478:
URL:
https://github.com/apache/httpcomponents-client/pull/478#discussion_r1306637937
##
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/InternalCacheStorage.java:
##
@@ -0,0 +1,94 @@
+/*
+ * =
arturobernalg merged PR #476:
URL: https://github.com/apache/httpcomponents-client/pull/476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr
ok2c commented on code in PR #478:
URL:
https://github.com/apache/httpcomponents-client/pull/478#discussion_r1306646775
##
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/InternalCacheStorage.java:
##
@@ -0,0 +1,94 @@
+/*
+ * ==
arturobernalg commented on code in PR #478:
URL:
https://github.com/apache/httpcomponents-client/pull/478#discussion_r1306651808
##
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/InternalCacheStorage.java:
##
@@ -0,0 +1,94 @@
+/*
+ * =
arturobernalg merged PR #478:
URL: https://github.com/apache/httpcomponents-client/pull/478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr
ok2c merged PR #422:
URL: https://github.com/apache/httpcomponents-core/pull/422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apac
lacompas commented on code in PR #478:
URL:
https://github.com/apache/httpcomponents-client/pull/478#discussion_r1307790388
##
httpclient5-cache/src/main/java/org/apache/hc/client5/http/impl/cache/InternalCacheStorage.java:
##
@@ -0,0 +1,94 @@
+/*
+ * ==
arturobernalg opened a new pull request, #424:
URL: https://github.com/apache/httpcomponents-core/pull/424
This pull request introduces changes to ensure our HTTP handling aligns with
the requirements set out in [RFC9110](https://www.rfc-editor.org/rfc/rfc9110).
Specifically, we've added va
arturobernalg opened a new pull request, #425:
URL: https://github.com/apache/httpcomponents-core/pull/425
This PR introduces two significant changes to improve our alignment with
modern HTTP standards:
- Trailer Headers with Chunked Transfer Encoding: We've added a check to
ensu
arturobernalg commented on PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#issuecomment-1699651791
> @arturobernalg Is this PR ready for review?
@ok2c yes. Or is there something I'm missing?
--
This is an automated message from the Apache Git Service.
To respon
ok2c commented on PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#issuecomment-1699594902
@arturobernalg Is this PR ready for review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ok2c commented on code in PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#discussion_r1311292928
##
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java:
##
@@ -313,11 +314,14 @@ public URI build() throws URISyntaxException {
return new
ok2c commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1311302155
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -127,4 +133,32 @@ public void process(final HttpRequest request, final
reschke commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1311309977
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -127,4 +133,32 @@ public void process(final HttpRequest request, fina
ok2c commented on code in PR #425:
URL:
https://github.com/apache/httpcomponents-core/pull/425#discussion_r1311380711
##
httpcore5/src/main/java/org/apache/hc/core5/http/message/MessageSupport.java:
##
@@ -151,6 +152,11 @@ public static void addContentEncodingHeader(final
Http
ok2c commented on code in PR #425:
URL:
https://github.com/apache/httpcomponents-core/pull/425#discussion_r1311380711
##
httpcore5/src/main/java/org/apache/hc/core5/http/message/MessageSupport.java:
##
@@ -151,6 +152,11 @@ public static void addContentEncodingHeader(final
Http
kwin opened a new pull request, #479:
URL: https://github.com/apache/httpcomponents-client/pull/479
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
kwin commented on code in PR #479:
URL:
https://github.com/apache/httpcomponents-client/pull/479#discussion_r1311425123
##
pom.xml:
##
@@ -227,8 +227,8 @@
maven-javadoc-plugin
-
https://hc.apache.org/httpcomponents-core-5.0.x/httpcore5
ok2c commented on code in PR #479:
URL:
https://github.com/apache/httpcomponents-client/pull/479#discussion_r1311449084
##
pom.xml:
##
@@ -227,8 +227,8 @@
maven-javadoc-plugin
-
https://hc.apache.org/httpcomponents-core-5.0.x/httpcore5
ok2c merged PR #479:
URL: https://github.com/apache/httpcomponents-client/pull/479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.ap
kwin commented on code in PR #479:
URL:
https://github.com/apache/httpcomponents-client/pull/479#discussion_r1311450127
##
pom.xml:
##
@@ -227,8 +227,8 @@
maven-javadoc-plugin
-
https://hc.apache.org/httpcomponents-core-5.0.x/httpcore5
cachescrubber opened a new pull request, #480:
URL: https://github.com/apache/httpcomponents-client/pull/480
Document classic and async exec chain behaviour when automatic retries are
enabled.
https://issues.apache.org/jira/browse/HTTPCLIENT-2291
--
This is an automated message fro
ok2c commented on PR #480:
URL:
https://github.com/apache/httpcomponents-client/pull/480#issuecomment-1701014744
@cachescrubber Awesome! One thing, though. Do you mind dropping code
snippets out of Javadocs, as code examples often tend to get out of sync with
the actual API usage.
--
Th
cachescrubber commented on PR #480:
URL:
https://github.com/apache/httpcomponents-client/pull/480#issuecomment-1701081868
@ok2c I removed the snippets. Having implemented a handler myself I remember
having to dig in the source of clientBuilder in order to find the name of the
retry handle
ok2c commented on PR #480:
URL:
https://github.com/apache/httpcomponents-client/pull/480#issuecomment-1701102844
> I think I would at least document the name (ChainElement#RETRY) in order
to place the interceptors relative to it. WDYT?
Makes perfect sense.
--
This is an automated
ok2c merged PR #480:
URL: https://github.com/apache/httpcomponents-client/pull/480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.ap
arturobernalg commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1311925115
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -127,4 +133,32 @@ public void process(final HttpRequest request
arturobernalg merged PR #418:
URL: https://github.com/apache/httpcomponents-core/pull/418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
arturobernalg commented on code in PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#discussion_r1311941788
##
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java:
##
@@ -313,11 +314,14 @@ public URI build() throws URISyntaxException {
re
arturobernalg commented on PR #425:
URL:
https://github.com/apache/httpcomponents-core/pull/425#issuecomment-1701556124
OK. I din´t see that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
arturobernalg closed pull request #425: HTTPCORE-756 - Enhance HTTP header
handling and deprecate legacy features
URL: https://github.com/apache/httpcomponents-core/pull/425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
arturobernalg commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312058180
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -127,4 +133,32 @@ public void process(final HttpRequest request
ok2c commented on code in PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#discussion_r1312747037
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,41 +260,41 @@ public void cancelled() {
@Test
void testGe
michael-o commented on PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#issuecomment-1702420779
Am I stupid or where do I see that the request actually contains content?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
reschke commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312784977
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -127,4 +133,32 @@ public void process(final HttpRequest request, fina
reschke commented on PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#issuecomment-1702432568
FWIW, as far as I can tell, this PR only checks that there is a Content-Type
field value. It doesn't check its validity, right?
--
This is an automated message from the Apach
ok2c commented on PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#issuecomment-1702444761
> Am I stupid or where do I see that the request actually contains content?
@michael-o This is quite fair. @arturobernalg I think there should be a
check there is actually a
ok2c commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312801174
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -127,4 +133,32 @@ public void process(final HttpRequest request, final
reschke commented on code in PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#discussion_r1312857095
##
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java:
##
@@ -309,11 +310,14 @@ public URI build() throws URISyntaxException {
return n
arturobernalg commented on code in PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#discussion_r1312860300
##
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java:
##
@@ -309,11 +310,14 @@ public URI build() throws URISyntaxException {
re
arturobernalg commented on code in PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#discussion_r1312881881
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,41 +260,41 @@ public void cancelled() {
@Test
vo
reschke commented on PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#issuecomment-1702581449
I'm not sure that changing `toString()` is a good idea here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
ok2c commented on PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#issuecomment-1702595456
@arturobernalg What you can do here is move the checks to the `#build`
method and keep `#buildString` as is. That would also enable to remove that
ugly try-catch from the `#toStri
ok2c commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312913134
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,21 +112,56 @@ public void process(final HttpRequest request, final
ok2c commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312913134
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,21 +112,56 @@ public void process(final HttpRequest request, final
ok2c commented on PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#issuecomment-1702609085
@arturobernalg Please also do not forget to update the description as it
will be used as a commit message
--
This is an automated message from the Apache Git Service.
To respond
arturobernalg commented on code in PR #424:
URL:
https://github.com/apache/httpcomponents-core/pull/424#discussion_r1312949660
##
httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestContent.java:
##
@@ -110,21 +112,56 @@ public void process(final HttpRequest reques
arturobernalg opened a new pull request, #426:
URL: https://github.com/apache/httpcomponents-core/pull/426
- Use AtomicBoolean for future completion tracking.
- Simplify async behavior and improve test determinism.
--
This is an automated message from the Apache Git Service.
To respond
ok2c commented on code in PR #426:
URL:
https://github.com/apache/httpcomponents-core/pull/426#discussion_r1313069605
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,35 +260,36 @@ public void cancelled() {
@Test
void testGe
arturobernalg commented on code in PR #426:
URL:
https://github.com/apache/httpcomponents-core/pull/426#discussion_r1313078700
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,35 +260,36 @@ public void cancelled() {
@Test
vo
ok2c commented on code in PR #426:
URL:
https://github.com/apache/httpcomponents-core/pull/426#discussion_r1313087273
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,35 +260,36 @@ public void cancelled() {
@Test
void testGe
thc202 commented on code in PR #426:
URL:
https://github.com/apache/httpcomponents-core/pull/426#discussion_r1313139826
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,35 +260,36 @@ public void cancelled() {
@Test
void test
arturobernalg commented on code in PR #426:
URL:
https://github.com/apache/httpcomponents-core/pull/426#discussion_r1313176491
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,35 +260,36 @@ public void cancelled() {
@Test
vo
arturobernalg commented on PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#issuecomment-1703046218
> @arturobernalg Please also do not forget to update the description as it
will be used as a commit message
@ok2c
Done
--
This is an automated message from t
thc202 commented on code in PR #426:
URL:
https://github.com/apache/httpcomponents-core/pull/426#discussion_r1313409461
##
httpcore5/src/test/java/org/apache/hc/core5/concurrent/TestBasicFuture.java:
##
@@ -260,35 +260,36 @@ public void cancelled() {
@Test
void test
arturobernalg merged PR #423:
URL: https://github.com/apache/httpcomponents-core/pull/423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
arturobernalg merged PR #424:
URL: https://github.com/apache/httpcomponents-core/pull/424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
arturobernalg merged PR #426:
URL: https://github.com/apache/httpcomponents-core/pull/426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
yndu13 opened a new pull request, #427:
URL: https://github.com/apache/httpcomponents-core/pull/427
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
yndu13 commented on PR #427:
URL:
https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1704592623
@ok2c Can someone give a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ok2c commented on PR #427:
URL:
https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705145516
@yndu13 Looks correct to me. I am still trying to test the fix locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
yndu13 commented on PR #427:
URL:
https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705165517
> @yndu13 Looks correct to me. I am still trying to test the fix locally.
Thanks, you can use this [socks
server](https://github.com/serjs/socks5-server) to verify this pr
garydgregory commented on PR #427:
URL:
https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705169527
Hi @yndu13
Thank you for your PR.
Without a matching test, this change in behavior can be undone in the future
without anyone noticing.
--
This is an automated me
yndu13 commented on PR #427:
URL:
https://github.com/apache/httpcomponents-core/pull/427#issuecomment-1705190444
> Hi @yndu13 Thank you for your PR. Without a matching test, this change in
behavior can be undone in the future without anyone noticing.
I agree with this opinion, but th
601 - 700 of 2920 matches
Mail list logo
