ok2c commented on PR #421:
URL: 
https://github.com/apache/httpcomponents-core/pull/421#issuecomment-1694220125

   You are going about it all wrong. You are mixing up message composition and 
message routing responsibilities. Request builders build messages. They do not 
make connection setup and message routing decisions. The _same_ message can be 
routed via _different_ routes multiple times. If no routing information has 
been explicitly given the message router can take the host and the port from 
the message to build the default route, but that is it. The target endpoint of 
the route and the message authority can be entirely different. The change-set 
you are proposing neglects all that.
   
   > Using the client.execute(target, ...):
   > 
   >     1. works correctly
   > 
   >     2. works correctly
   > 
   >     3. works correctly
   > 
   >     4. works correctly
   
   Sure it does, because unlike the two other cases you actually correctly tell 
HttpClient to use the expected route to connect to the target endpoint 
   
   Please do feel free to raise a JIRA for `AsyncRequester` improvements in 
core or provide a PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org

Reply via email to