michael-o commented on code in PR #418:
URL:
https://github.com/apache/httpcomponents-core/pull/418#discussion_r1304790613
##########
httpcore5/src/main/java/org/apache/hc/core5/net/URIAuthority.java:
##########
@@ -155,7 +148,7 @@ public URIAuthority(final String hostname) {
}
public String getUserInfo() {
- return userInfo;
Review Comment:
No deprecation here?
##########
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java:
##########
@@ -156,7 +155,7 @@ public URIBuilder setAuthority(final NamedEndpoint
authority) {
* @since 5.2
*/
public URIBuilder setAuthority(final URIAuthority authority) {
- setUserInfo(authority.getUserInfo());
+ setUserInfo(null);
Review Comment:
Does the invocation make any sense now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
