garydgregory commented on code in PR #422: URL: https://github.com/apache/httpcomponents-core/pull/422#discussion_r1306408906
########## httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2MultiplexingRequester.java: ########## @@ -128,18 +130,38 @@ public Cancellable execute( Args.notNull(timeout, "Timeout"); Args.notNull(context, "Context"); final CancellableExecution cancellableExecution = new CancellableExecution(); - execute(exchangeHandler, pushHandlerFactory, cancellableExecution, timeout, context); + execute(target, exchangeHandler, pushHandlerFactory, cancellableExecution, timeout, context); return cancellableExecution; } public Cancellable execute( final AsyncClientExchangeHandler exchangeHandler, + final HandlerFactory<AsyncPushConsumer> pushHandlerFactory, final Timeout timeout, final HttpContext context) { - return execute(exchangeHandler, null, timeout, context); + return execute(null, exchangeHandler, pushHandlerFactory, timeout, context); + } + + /** Review Comment: Needs a description. ########## httpcore5-h2/src/main/java/org/apache/hc/core5/http2/impl/nio/bootstrap/H2MultiplexingRequester.java: ########## @@ -119,7 +117,11 @@ public void setValidateAfterInactivity(final TimeValue timeValue) { connPool.setValidateAfterInactivity(timeValue); } + /** Review Comment: Needs a description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org