arturobernalg commented on code in PR #423:
URL:
https://github.com/apache/httpcomponents-core/pull/423#discussion_r1312860300
##########
httpcore5/src/main/java/org/apache/hc/core5/net/URIBuilder.java:
##########
@@ -309,11 +310,14 @@ public URI build() throws URISyntaxException {
return new URI(buildString());
}
- private String buildString() {
+ private String buildString() throws URISyntaxException {
final StringBuilder sb = new StringBuilder();
if (this.scheme != null) {
sb.append(this.scheme).append(':');
}
+ if (URIScheme.HTTPS.same(scheme) && (TextUtils.isBlank(host))) {
Review Comment:
True. should be `HTTP` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
