bpitman opened a new pull request, #421: URL: https://github.com/apache/httpcomponents-core/pull/421
Note that this patch is probably incomplete - it does not break existing tests, but no tests were added nor updated to verify the new code. We have a need to set the InetAddress for a request - the ip tells us where to connect and the hostname is needed for ssl verification. We could have also done this with lots of separate conn pools and tls strategies, or maybe with a custom conn pool. I preferred to have this per request, though (rather than per requester). The current request builder supports setting HttpHost using InetAddress, but request doesn't support HttpHost so the InetAddress is lost when creating the request. During execution, HttpHost is recreated - but with a subset of the info that was in the original HttpHost. Additionally, the socket is created using a subset of the potential in HttpHost. I've added InetAddress to HttpRequest and changed socket creation to use the address when it exists. Ideally, we'd have more control of the Host header auto-entered by the request (to not include the port), but this isn't a technical requirement. It wasn't clear how you're using branches. Master seems to be 5.2.x, but the 5.3.x branch is missing 4 months up updates to master. Though the version is 5.2.x, the javadoc entries I added say 5.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org
