ok2c commented on PR #422: URL: https://github.com/apache/httpcomponents-core/pull/422#issuecomment-1694407530
@bpitman The `#setHttpHost` method is merely a convenience method that copies the protocol scheme and the authority in one go from an existing `HttpHost`. I am not sure I agree it is useless or misleading. Please do feel free to propose a PR with Javadoc improvements. ``` public AbstractRequestBuilder<T> setHttpHost(final HttpHost httpHost) { if (httpHost == null) { return this; } this.authority = new URIAuthority(httpHost); this.scheme = httpHost.getSchemeName(); return this; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org