Re: [DISCUSSION] flink-connector-hive first release of externalized connector

2025-01-16 Thread Ahmed Hamdy
Hi Sergey, +1 for restarting this. Best Regards Ahmed Hamdy On Thu, 16 Jan 2025 at 14:02, David Radley wrote: > Hi Sergey, > I think this makes a lot of sense to get this cleared up soon. > I notice that there is a HiveCatalog referred to in the Python in core > Flink. I

Re: [VOTE] CHI: Stale PR cleanup

2025-01-07 Thread Ahmed Hamdy
Thanks Tom +1 (non-binding) Best Regards Ahmed Hamdy On Mon, 6 Jan 2025 at 16:43, David Radley wrote: > Thanks for driving this Tom. > +1 (non-binding) > David > > From: Gyula Fóra > Date: Monday, 6 January 2025 at 16:33 > To: dev@flink.apache.org > Subject: [EXTERNA

Re: [Discuss] Kafka Enumerator assigns splits based on the current assignment situation.

2024-12-30 Thread Ahmed Hamdy
nsider a simpler approach, like just a round-robin assignment for all topic/partitions instead of hash based topic assignment + round-robin partition? I am sorry if the discussion is getting more detailed, happy to move it to a FLIP if the community agrees as well. Best Regards Ahmed Hamdy On

Re: [Discuss] Kafka Enumerator assigns splits based on the current assignment situation.

2024-12-29 Thread Ahmed Hamdy
lelism change? 1- https://issues.apache.org/jira/browse/FLINK-31762 Best Regards Ahmed Hamdy On Fri, 27 Dec 2024 at 06:38, Hongshun Wang wrote: > Hi devs, > > I'd like to push a new FLIP xxx: Kafka Enumerator assigns splits based on > the current assignment situation. Curren

[jira] [Created] (FLINK-36972) Unify AWS sink implementation

2024-12-27 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-36972: --- Summary: Unify AWS sink implementation Key: FLINK-36972 URL: https://issues.apache.org/jira/browse/FLINK-36972 Project: Flink Issue Type: Technical Debt

[jira] [Created] (FLINK-36971) Add Sqs Sink SQL connector

2024-12-27 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-36971: --- Summary: Add Sqs Sink SQL connector Key: FLINK-36971 URL: https://issues.apache.org/jira/browse/FLINK-36971 Project: Flink Issue Type: Improvement

Re: [DISCUSS] Elasticsearch v3.1 release

2024-12-03 Thread Ahmed Hamdy
Hi Yanquan, I have kicked off the release process for v3.1, will try to conclude soon and announce. Sorry for the delays, it is quite hard to process the release without PMC permissions but Danny is kindly offering help when needed. Best Regards Ahmed Hamdy On Tue, 3 Dec 2024 at 12:05, Yanquan

Re: Subject: [VOTE] Release flink-connector-kafka v3.4.0, release candidate #1

2024-11-25 Thread Ahmed Hamdy
+1 (non-binding) - Validated hashes & checksums - Validated signatures - Verified no binaries in source archive - Build source with maven Best Regards Ahmed Hamdy On Mon, 25 Nov 2024 at 08:50, Martijn Visser wrote: > +1 (binding) > > - Validated hashes > - Verified signat

[jira] [Created] (FLINK-36770) Support Request Timeout for AWS sinks

2024-11-21 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-36770: --- Summary: Support Request Timeout for AWS sinks Key: FLINK-36770 URL: https://issues.apache.org/jira/browse/FLINK-36770 Project: Flink Issue Type: Improvement

Re: [DISCUSS] Flink PubSub connector bump release needed

2024-11-08 Thread Ahmed Hamdy
to start a new minor version release to land the new Sink to users like yourself. Looking forward to the feedback from the community as well. Best Regards Ahmed Hamdy On Fri, 8 Nov 2024 at 07:48, Radek Stankiewicz wrote: > Dear Flink devs, I would like to initiate a discussion about the nee

Re: [VOTE] Release flink-connector-aws v5.0.0, release candidate #3

2024-11-08 Thread Ahmed Hamdy
Thanks Hong for driving, +1 (non-binding) - Release notes look good - Verified there are no blocker issues. - Verified signatures and hashsums - No binaries in source - Build source using maven and jdk11 - Verified tag is present in repo Best Regards Ahmed Hamdy On Fri, 8 Nov 2024 at 02:28

Re: Re: [ANNOUNCE] New Apache Flink Committer - Junrui Li

2024-11-06 Thread Ahmed Hamdy
Congratulations Junrui! Best Regards Ahmed Hamdy On Wed, 6 Nov 2024 at 08:32, Xuyang wrote: > Congratulations, Junrui! > > > -- > > Best! > Xuyang > > > > > > 在 2024-11-06 14:34:36,"Yuepeng Pan" 写道: > >Congratulations! > >

[jira] [Created] (FLINK-36651) Fix CI tests for ElasticSearch Connector

2024-11-02 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-36651: --- Summary: Fix CI tests for ElasticSearch Connector Key: FLINK-36651 URL: https://issues.apache.org/jira/browse/FLINK-36651 Project: Flink Issue Type: Bug

Re: [DISCUSS] Elasticsearch v3.1 release

2024-10-29 Thread Ahmed Hamdy
Thanks Danny for the input, I figured out most of the steps require committer permissions, I will reach out offline for the next steps so thanks in advance for the assistance also. Best Regards Ahmed Hamdy On Mon, 14 Oct 2024 at 17:23, Danny Cranmer wrote: > Hey Ahmed, > > +1 for th

Re: [VOTE] Release flink-connector-kafka v3.3.0, release candidate #1

2024-10-14 Thread Ahmed Hamdy
Hi Arvid, yeah sure, thanks for following up Best Regards Ahmed Hamdy On Mon, 14 Oct 2024 at 10:52, Danny Cranmer wrote: > Hey Arvid, > > +1 (binding) > > - I left a couple of comments on the website PR that need addressing > - Release notes look good > - Source a

[DISCUSS] Elasticsearch v3.1 release

2024-10-14 Thread Ahmed Hamdy
://issues.apache.org/jira/browse/FLINK-34113 3-https://issues.apache.org/jira/browse/FLINK-26088 Best Regards Ahmed Hamdy

Re: [VOTE] Release flink-connector-kafka v3.3.0, release candidate #1

2024-10-12 Thread Ahmed Hamdy
miss something? Best Regards Ahmed Hamdy On Sat, 12 Oct 2024 at 05:23, Yanquan Lv wrote: > +1 (non-binding) > I checked: > - Review JIRA release notes > - Verify hashes > - Verify signatures > - Build from source with JDK 8/11/17 > - Source code artifacts matching the current rele

Re: [ANNOUNCE] Apache Flink CDC 3.2.0 released

2024-09-10 Thread Ahmed Hamdy
Great Milestone for the CDC project. Thanks Qingsheng and the team for the efforts. Best Regards Ahmed Hamdy On Thu, 5 Sept 2024 at 15:03, Muhammet Orazov wrote: > Amazing! > > Thanks Qingsheng and everyone for your efforts! > > Best, > Muhammet > > > On 2024-09-05

Re: [VOTE] FLIP-477: Amazon SQS Source Connector

2024-08-21 Thread Ahmed Hamdy
Thanks for driving Abhisagar, +1 (non-binding) Best Regards Ahmed Hamdy On Wed, 21 Aug 2024 at 09:11, Abhisagar Khatri wrote: > Hi Flink Devs, > > Thank you for all the feedback about FLIP-477: Amazon SQS Source Connector > [1]. The discussion thread can be found here [2]. >

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-08-20 Thread Ahmed Hamdy
Hi Abhisagar and Saurabh I have created the FLIP page and assigned it FLIP-477[1]. Feel free to resume with the next steps. 1- https://cwiki.apache.org/confluence/display/FLINK/FLIP-+477+Amazon+SQS+Source+Connector Best Regards Ahmed Hamdy On Tue, 20 Aug 2024 at 06:05, Abhisagar Khatri wrote

[jira] [Created] (FLINK-36080) Add SQL Connector for SQS

2024-08-17 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-36080: --- Summary: Add SQL Connector for SQS Key: FLINK-36080 URL: https://issues.apache.org/jira/browse/FLINK-36080 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-36079) Add Documentation for SQS Table API connector

2024-08-17 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-36079: --- Summary: Add Documentation for SQS Table API connector Key: FLINK-36079 URL: https://issues.apache.org/jira/browse/FLINK-36079 Project: Flink Issue Type: Sub

[jira] [Created] (FLINK-36078) Add Documentation for PubSubSink Table API connector

2024-08-16 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-36078: --- Summary: Add Documentation for PubSubSink Table API connector Key: FLINK-36078 URL: https://issues.apache.org/jira/browse/FLINK-36078 Project: Flink Issue

[jira] [Created] (FLINK-36077) Implement Table API support for PubSubSink V2

2024-08-16 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-36077: --- Summary: Implement Table API support for PubSubSink V2 Key: FLINK-36077 URL: https://issues.apache.org/jira/browse/FLINK-36077 Project: Flink Issue Type: Sub

Re: Re: [VOTE] FLIP-455: Declare async state processing and checkpoint the in-flight requests

2024-08-15 Thread Ahmed Hamdy
+1 (non-binding) Thanks for driving. Best Regards Ahmed Hamdy On Wed, 14 Aug 2024 at 07:33, Xuyang wrote: > +1 (non-binding) > > > -- > > Best! > Xuyang > > > > > > 在 2024-08-14 11:04:18,"Yuepeng Pan" 写道: > > > > >

Re: [DISCUSS] re-open FLINK-28842 Add client.id.prefix for the KafkaSink

2024-08-12 Thread Ahmed Hamdy
Hi Rich, I see the ticket is already stale-assigned. Feel free to raise another PR with your contribution. Best Regards Ahmed Hamdy On Sun, 11 Aug 2024 at 04:26, Rich C. wrote: > Hi all, > > I'm reaching out to you about FLINK-28842 > <https://issues.apache.org/jira/browse

Re: [DISCUSS] Release flink-connector-mongodb 2.0.0

2024-08-09 Thread Ahmed Hamdy
Hi Jiabao, Thanks for raising this, +1 for the proposal. Best Regards Ahmed Hamdy On Thu, 8 Aug 2024 at 10:33, Leonard Xu wrote: > Thanks Jiabao for kicking off this thread, +1 for the proposal. > > > Feel free to ping me if you need help from PMC member side. > > Best, >

[jira] [Created] (FLINK-36010) Duplicate Job Submission returns Succeeded on single execution even if Global state is FAILED

2024-08-08 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-36010: --- Summary: Duplicate Job Submission returns Succeeded on single execution even if Global state is FAILED Key: FLINK-36010 URL: https://issues.apache.org/jira/browse/FLINK-36010

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-08-07 Thread Ahmed Hamdy
ments. Thanks again for the effort. Best Regards Ahmed Hamdy On Wed, 31 Jul 2024 at 10:34, Saurabh Singh wrote: > Hi Ahmed, > > Thank you very much for the detailed, valuable review. Please find our > responses below: > > >- In the FLIP you mention the split is goi

Re: Discussion on Vertica-Flink Connector

2024-08-05 Thread Ahmed Hamdy
Hi Vikas, Could you address feedback from Yanquan, we can create the FLIP page later. Best Regards Ahmed Hamdy On Mon, 5 Aug 2024 at 07:17, Vikas Garg wrote: > Hello, > > We are looking forward to creating FLIP for voting. Can someone help me > with creating the FLIP since now w

Re: [ANNOUNCE] Apache Flink 1.20.0 released

2024-08-02 Thread Ahmed Hamdy
Congratulations! Thanks Weijie and the release managers for the huge efforts. Best Regards Ahmed Hamdy On Fri, 2 Aug 2024 at 10:15, Zakelly Lan wrote: > Congratulations! Thanks to release managers and everyone involved! > > > Best, > Zakelly > > On Fri, Aug 2, 2024

Re: [VOTE] Release 1.20.0, release candidate #2

2024-07-29 Thread Ahmed Hamdy
Thanks Weijie for driving +1 (non-binding) - Verified checksums - Verified signature matches Rui Fan's - Verified tag exists on Github - Build from source - Verified no binaries in source archive - Reviewed release notes PR (some nits) Best Regards Ahmed Hamdy On Thu, 25 Jul 2024 at

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-07-27 Thread Ahmed Hamdy
P-438 implementation but I echo the fact that there might be some reusable code between the 2 submodules we should make use of. Best Regards Ahmed Hamdy On Fri, 26 Jul 2024 at 17:55, Saurabh Singh wrote: > Hi Li Wang, > > Thanks for the review and appreciate your feedback. > I comple

Re: [VOTE] FLIP-460: Display source/sink I/O metrics on Flink Web UI

2024-07-16 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Tue, 16 Jul 2024 at 21:58, Becket Qin wrote: > +1 (binding) > > Thanks, > > Jiangjie (Becket) Qin > > On Tue, Jul 16, 2024 at 12:19 AM Leonard Xu wrote: > > > +1(binding) > > > > Best, > > Leonar

[jira] [Created] (FLINK-35779) Update documentation for PubSubSinkV2

2024-07-07 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35779: --- Summary: Update documentation for PubSubSinkV2 Key: FLINK-35779 URL: https://issues.apache.org/jira/browse/FLINK-35779 Project: Flink Issue Type: Sub-task

Re: [DISCUSS] FLIP-299 Pub/Sub Lite Connector

2024-07-02 Thread Ahmed Hamdy
Hi Martijn, yes, I agree, thanks for confirmation. Best Regards Ahmed Hamdy On Tue, 2 Jul 2024 at 12:30, Martijn Visser wrote: > Hi, > > Since PubSub Lite is deprecated, I think we can safely close this FLIP and > not proceed further [1] > > Best regards, > &g

Re: [ANNOUNCE] Apache Flink CDC 3.1.1 released

2024-06-27 Thread Ahmed Hamdy
Congratulations, Thanks for the efforts Best Regards Ahmed Hamdy On Thu, 20 Jun 2024 at 12:57, Muhammet Orazov wrote: > Great, thanks Qingsheng for your efforts! > > Best, > Muhammet > > On 2024-06-18 15:50, Qingsheng Ren wrote: > > The Apache Flink community is ve

Re: [VOTE] FLIP-444: Native file copy support

2024-06-27 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Thu, 27 Jun 2024 at 17:29, Martijn Visser wrote: > +1 (binding) > > On Thu, Jun 27, 2024 at 3:32 AM Rui Fan <1996fan...@gmail.com> wrote: > > > +1(binding) > > > > Best, > > Rui > > > > On W

[jira] [Created] (FLINK-35697) Release Testing: Verify FLIP-451 Introduce timeout configuration to AsyncSink

2024-06-25 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35697: --- Summary: Release Testing: Verify FLIP-451 Introduce timeout configuration to AsyncSink Key: FLINK-35697 URL: https://issues.apache.org/jira/browse/FLINK-35697 Project

Re: [ANNOUNCE] New Apache Flink Committer - Hang Ruan

2024-06-17 Thread Ahmed Hamdy
Congratulations Hang. Regards Ahmed On Mon, 17 Jun 2024, 14:01 Feifan Wang, wrote: > Congratulations Hang ! > > > —— > > Best regards, > > Feifan Wang > > > > > At 2024-06-17 11:17:13, "Leonard Xu" wrote: > >Hi everyone, > >On behalf of the PMC, I'm happy to let you know that Hang R

Re: [DISCUSS] Connector Externalization Retrospective

2024-06-11 Thread Ahmed Hamdy
hnical debt and removing it would be an Adhoc task for maintainers which I believe is an accepted tradeoff but would love to hear the feedback. 1- https://github.com/apache/flink/pull/24180/files#diff-2ffade463560e5941912b91b12a07c888313a4cc7e39ca8700398ed6975b8e90 Best Regards Ahmed Hamdy On Tue, 11

Re: [Discuss] Non-retriable (partial) errors in Elasticsearch 8 connector

2024-06-11 Thread Ahmed Hamdy
Hi Mingliang, Yes sounds like a good solution, I am not very familiar with ElasticSearch internals and APIs but will try to assist with the PR when ready. Best Regards Ahmed Hamdy On Tue, 11 Jun 2024 at 07:07, Mingliang Liu wrote: > Thank you Ahmed for the explanation. > > Th

Re: [ANNOUNCE] New Apache Flink PMC Member - Fan Rui

2024-06-10 Thread Ahmed Hamdy
Congratulations Rui! Best Regards Ahmed Hamdy On Mon, 10 Jun 2024 at 09:10, David Radley wrote: > Congratulations, Rui! > > From: Sergey Nuyanzin > Date: Sunday, 9 June 2024 at 20:33 > To: dev@flink.apache.org > Subject: [EXTERNAL] Re: [ANNOUNCE] New Apache Flink PM

Re: [VOTE] Release 1.19.1, release candidate #1

2024-06-08 Thread Ahmed Hamdy
Hi Hong, Thanks for driving +1 (non-binding) - Verified signatures and hashes - Checked github release tag - Verified licenses - Checked that the source code does not contain binaries - Reviewed Web PR, nit: Could we address the comment of adding FLINK-34633 in the release Best Regards Ahmed

Re: [VOTE] FLIP-459: Support Flink hybrid shuffle integration with Apache Celeborn

2024-06-08 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Sat, 8 Jun 2024 at 22:26, Jeyhun Karimov wrote: > Hi Yuxin, > > Thanks for driving this. > +1 (non-binding) > > Regards, > Jeyhun > > On Fri, Jun 7, 2024 at 6:05 PM Jim Hughes > wrote: > > > HI all,

Re: [DISCUSS] FLIP-299 Pub/Sub Lite Connector

2024-06-08 Thread Ahmed Hamdy
int of the discussion at the moment. I would love to hear your thoughts. 1-https://lists.apache.org/thread/63wdvo5hvr6koc3wzbqy2kw4krhmkfbx Best Regards Ahmed Hamdy On Fri, 17 Mar 2023 at 15:58, Daniel Collins wrote: > > would the repository ... be removed ... ? > > Yes, I would remov

Re: [Discuss] Non-retriable (partial) errors in Elasticsearch 8 connector

2024-06-07 Thread Ahmed Hamdy
k-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbSinkWriter.java#L227 3-https://issues.apache.org/jira/browse/FLINK-35541 Best Regards Ahmed Hamdy On Thu, 6 Jun 2024 at 06:53, Mingliang Liu wrote: > Hi all, > > Currently the Elasticsearch 8 connec

[jira] [Created] (FLINK-35548) Add E2E tests for PubSubSinkV2

2024-06-07 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35548: --- Summary: Add E2E tests for PubSubSinkV2 Key: FLINK-35548 URL: https://issues.apache.org/jira/browse/FLINK-35548 Project: Flink Issue Type: Sub-task

Re: [ANNOUNCE] New Apache Flink PMC Member - Weijie Guo

2024-06-04 Thread Ahmed Hamdy
Congratulations Weijie Best Regards Ahmed Hamdy On Tue, 4 Jun 2024 at 10:51, Matthias Pohl wrote: > Congratulations, Weijie! > > Matthias > > On Tue, Jun 4, 2024 at 11:12 AM Guowei Ma wrote: > > > Congratulations! > > > > Best, > > Guowei

[jira] [Created] (FLINK-35500) DynamoDb SinkWriter fails to delete elements due to key not found

2024-05-31 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35500: --- Summary: DynamoDb SinkWriter fails to delete elements due to key not found Key: FLINK-35500 URL: https://issues.apache.org/jira/browse/FLINK-35500 Project: Flink

Re: [DISCUSS] Add Flink CDC Channel to Apache Flink Slack Workspace

2024-05-29 Thread Ahmed Hamdy
Thanks Zhongqiang, +1 for sure. Best Regards Ahmed Hamdy On Wed, 29 May 2024 at 13:48, ConradJam wrote: > +1 best > > Hang Ruan 于2024年5月29日周三 11:28写道: > > > Hi, zhongqiang. > > > > Thanks for the proposal. +1 for it. > > > > Best, > >

[jira] [Created] (FLINK-35454) Connector ArchTests fails due to dependency on fink.util.Preconditions

2024-05-26 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35454: --- Summary: Connector ArchTests fails due to dependency on fink.util.Preconditions Key: FLINK-35454 URL: https://issues.apache.org/jira/browse/FLINK-35454 Project: Flink

[jira] [Created] (FLINK-35445) Update Async Sink documentation for Timeout configuration

2024-05-24 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35445: --- Summary: Update Async Sink documentation for Timeout configuration Key: FLINK-35445 URL: https://issues.apache.org/jira/browse/FLINK-35445 Project: Flink

[jira] [Created] (FLINK-35435) [FLIP-451] Introduce timeout configuration to AsyncSink

2024-05-23 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35435: --- Summary: [FLIP-451] Introduce timeout configuration to AsyncSink Key: FLINK-35435 URL: https://issues.apache.org/jira/browse/FLINK-35435 Project: Flink Issue

[RESULT][VOTE] FLIP-451: Introduce timeout configuration to AsyncSink

2024-05-22 Thread Ahmed Hamdy
https://lists.apache.org/thread/9mkzdv0gzssxh8p0y1cl3dvj6lvwyrc0 Best Regards Ahmed Hamdy

Re: [VOTE] FLIP-451: Introduce timeout configuration to AsyncSink

2024-05-22 Thread Ahmed Hamdy
Hi all, Thanks for all your votes, I hereby close the vote and I'll announce the results in a separate email. Best Regards Ahmed Hamdy On Wed, 22 May 2024 at 11:30, weijie guo wrote: > Thanks Ahmed for introducing this FLIP, nice improvement. > > +1(binding) > > Best

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-22 Thread Ahmed Hamdy
ward compatibility has > been considered for all public interfaces the FLIP changed. > Done Best Regards Ahmed Hamdy On Wed, 22 May 2024 at 04:16, Leonard Xu wrote: > Thanks for your reply, Ahmed. > > > (2) The FLIP-451 aims to introduce a timeout configuration, but I didn’t

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-21 Thread Ahmed Hamdy
ching, I fixed the incomplete methods, This should clarify how the new method is going to be integrated with the rest of the writer. Regarding the sendTime variable, I have replaced it with requestTimestamp; this is an unchanged part of the code to ensure the existing completeRequest method is unchanged

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-21 Thread Ahmed Hamdy
Hi Hong, Thanks for pointing that out, no we are not deprecating getFatalExceptionCons(). I have updated the FLIP Best Regards Ahmed Hamdy On Mon, 20 May 2024 at 15:40, Hong Liang wrote: > Hi Ahmed, > Thanks for putting this together! Should we still be marking > getFatalException

[jira] [Created] (FLINK-35401) Add SQS Table API support

2024-05-20 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35401: --- Summary: Add SQS Table API support Key: FLINK-35401 URL: https://issues.apache.org/jira/browse/FLINK-35401 Project: Flink Issue Type: New Feature

Re: [ANNOUNCE] Apache Flink CDC 3.1.0 released

2024-05-17 Thread Ahmed Hamdy
Congratulations, Great Work! Best Regards Ahmed Hamdy On Fri, 17 May 2024 at 10:56, ConradJam wrote: > Congratulations! > > Thanks for the great work. > > Hang Ruan 于2024年5月17日周五 17:48写道: > > > Congratulations! > > > > Thanks for the great work. > > &

Re: [VOTE] FLIP-449: Reorganization of flink-connector-jdbc

2024-05-17 Thread Ahmed Hamdy
Hi all, +1 (non-binding) Best Regards Ahmed Hamdy On Fri, 17 May 2024 at 02:13, Jiabao Sun wrote: > Thanks for driving this proposal! > > +1 (binding) > > Best, > Jiabao > > > On 2024/05/10 22:18:04 Jeyhun Karimov wrote: > > Thanks for driving this! > &g

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-15 Thread Ahmed Hamdy
Hi Lorenzo, yes it is pretty useful to start tackling the ones that still don't implement the new interface, happy so sync offline to close this task, additionally a volunteer to review the migrations would be highly appreciated. Best Regards Ahmed Hamdy On Wed, 15 May 2024 at 10:01,

Re: [DISCUSS] FLIP-XXX: Improve JDBC connector extensibility for Table API

2024-05-15 Thread Ahmed Hamdy
Hi Lorenzo, This seems like a very useful addition. +1 (non-binding) from my side. I echo Jeyhun's question about backward compatibility as it is not mentioned in the FLIP. Best Regards Ahmed Hamdy On Wed, 15 May 2024 at 08:12, wrote: > Hello Muhammet and Jeyhun! > Thanks for yo

Re: [VOTE] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-15 Thread Ahmed Hamdy
+1 (non-binding). Thanks Martijn! Best Regards Ahmed Hamdy On Wed, 15 May 2024 at 14:11, Jing Ge wrote: > +1(binding) Thanks Martijn! > > Best regards, > Jing > > On Wed, May 15, 2024 at 7:00 PM Muhammet Orazov > wrote: > > > Thanks Martijn driving this!

Re: [VOTE] FLIP-451: Introduce timeout configuration to AsyncSink

2024-05-13 Thread Ahmed Hamdy
Thanks David, I have replied to your question in the discussion thread. Best Regards Ahmed Hamdy On Mon, 13 May 2024 at 16:21, David Radley wrote: > Hi, > I raised a question on the discussion thread, around retriable errors, as > a possible alternative, > Kind regards, David

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-13 Thread Ahmed Hamdy
/blob/c6e0abb65a0e51b40dd218b890a111886fbf797f/flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkWriter.java#L106 Best Regards Ahmed Hamdy On Mon, 13 May 2024 at 16:20, David Radley wrote: > Hi, > I wonder if the way tha

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-13 Thread Ahmed Hamdy
Thanks for the clarification. +1 to starting the vote. Best Regards Ahmed Hamdy On Mon, 13 May 2024 at 09:10, Martijn Visser wrote: > Hi Ahmed, > > There's no reason to refrain from releases for Flink 1.* versions: these > connector implementations are still supported in the

[VOTE] FLIP-451: Introduce timeout configuration to AsyncSink

2024-05-13 Thread Ahmed Hamdy
/ft7wcw7kyftvww25n5fm4l925tlgdfg0 2- https://cwiki.apache.org/confluence/display/FLINK/FLIP-451%3A+Introduce+timeout+configuration+to+AsyncSink+API Best Regards Ahmed Hamdy

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-12 Thread Ahmed Hamdy
blockers are implemented? > Could you please clarify? Best Regards Ahmed Hamdy On Sun, 12 May 2024 at 14:07, Martijn Visser wrote: > Hi all, > > If there are no more considerations, I'll open up a vote in the next couple > of days. > > Best regards, > > Martijn &g

Re: Re: [VOTE] FLIP-448: Introduce Pluggable Workflow Scheduler Interface for Materialized Table

2024-05-11 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Sat, 11 May 2024 at 16:26, Keith Lee wrote: > +1 (non-binding) > > Best regards > Keith Lee > > > On Sat, 11 May 2024 at 04:58, Shengkai Fang wrote: > > > +1 (binding) > > > > Best, > > Shengkai >

[jira] [Created] (FLINK-35322) PubSub Connector Weekly build fails

2024-05-09 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35322: --- Summary: PubSub Connector Weekly build fails Key: FLINK-35322 URL: https://issues.apache.org/jira/browse/FLINK-35322 Project: Flink Issue Type: Bug

Re: [VOTE] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-05-09 Thread Ahmed Hamdy
Thanks for the effort and the data provided. +1 (non-binding) Best Regards Ahmed Hamdy On Thu, 9 May 2024 at 08:20, Keith Lee wrote: > +1 (non-binding) > > Great work on the benchmark data. > > Keith > > On Thu, May 9, 2024 at 4:53 AM 周仁祥 wrote: > > > +1 (non

[jira] [Created] (FLINK-35320) RabbitMQ Source fails to consume from quorum queues when prefetch Count is set

2024-05-09 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-35320: --- Summary: RabbitMQ Source fails to consume from quorum queues when prefetch Count is set Key: FLINK-35320 URL: https://issues.apache.org/jira/browse/FLINK-35320 Project

Re: [RESULT][VOTE] FLIP-454: New Apicurio Avro format

2024-05-08 Thread Ahmed Hamdy
Hi David, thanks for the update We should wait to reach threshold of "binding" votes as per the process[1] 1- https://cwiki.apache.org/confluence/display/FLINK/Flink+Bylaws#FlinkBylaws-Approvals Best Regards Ahmed Hamdy On Wed, 8 May 2024 at 16:06, David Radley wrote: > Hi eve

Re: [DISCUSS] FLIP-444: Native file copy support

2024-05-08 Thread Ahmed Hamdy
Hi Piotr +1 for the proposal, it seems to have a lot of gains. Best Regards Ahmed Hamdy On Mon, 6 May 2024 at 12:06, Zakelly Lan wrote: > Hi Piotrek, > > Thanks for your answers! > > Good question. The intention and use case behind `DuplicatingFileSystem` is > > d

Re: [DISCUSS] Flink CDC 3.2 Release Planning

2024-05-08 Thread Ahmed Hamdy
Thanks Qinsheng for driving, +1 for the feature freeze date. I am happy to assist with any release duties. Best Regards Ahmed Hamdy On Wed, 8 May 2024 at 10:50, Jiabao Sun wrote: > Thanks Qingsheng, > > Improving stability is crucial for Flink CDC, looking forward to this > r

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-06 Thread Ahmed Hamdy
d we add a list of possible connectors that this FLIP would improve? Good call, I have added under migration plan. Best Regards Ahmed Hamdy On Mon, 6 May 2024 at 08:49, Muhammet Orazov wrote: > Hey Ahmed, > > Thanks for the FLIP! +1 (non-binding) > > > Additionally the cu

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-05-04 Thread Ahmed Hamdy
Hi Jeyhun, I have changed the scope of FLIP to exclude problems addressed by FLIP-284 and redefined scope to introduce timeout configuration. Best Regards Ahmed Hamdy On Mon, 29 Apr 2024 at 20:57, Ahmed Hamdy wrote: > Hi Jeyhun, > Thanks for your feedback. I agree the phrasing is

Re: [Vote] FLIP-438: Amazon SQS Sink Connector

2024-05-04 Thread Ahmed Hamdy
Hi Priya, It seems that we have acquired the threshold of binding votes, Should we close the vote, announce the result and create Jiras? Best Regards Ahmed Hamdy On Wed, 17 Apr 2024 at 03:24, Leonard Xu wrote: > +1 (binding) > > Best, > Leonard > > > 2024年4月17日 上午2:

Re: [VOTE] FLIP-436: Introduce Catalog-related Syntax

2024-05-04 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Sat, 27 Apr 2024 at 02:46, Muhammet Orazov wrote: > > Hey Yubin, +1 (non-binding) > > Looks good, thanks! > > Best, > Muhammet > > On 2024-04-24 08:56, Yubin Li wrote: > > Hi everyone, > > > > Durin

Re: [VOTE] FLIP-446: Kubernetes Operator State Snapshot CRD

2024-05-04 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Sat, 27 Apr 2024 at 05:33, ConradJam wrote: > +1 (non-binding) > > Biao Geng 于2024年4月26日周五 18:45写道: > > > +1 (non-binding) > > > > Best, > > Biao Geng > > > > > > gongzhongqi

Re: [VOTE] FLIP-454: New Apicurio Avro format

2024-05-04 Thread Ahmed Hamdy
+1 (non-binding) Best Regards Ahmed Hamdy On Fri, 3 May 2024 at 15:16, Jeyhun Karimov wrote: > +1 (non binding) > > Thanks for driving this FLIP David. > > Regards, > Jeyhun > > On Fri, May 3, 2024 at 2:21 PM Mark Nuttall wrote: > > > +1, I would also like to

Re: [VOTE] Apache Flink CDC Release 3.1.0, release candidate #1

2024-05-04 Thread Ahmed Hamdy
Hi Qisheng, +1 (non-binding) - Verified checksums and hashes - Verified signatures - Verified github tag exists - Verified no binaries in source - build source Best Regards Ahmed Hamdy On Fri, 3 May 2024 at 23:03, Jeyhun Karimov wrote: > Hi Qinsheng, > > Thanks for driving th

Re: [DISCUSS] FLIP-453: Promote Unified Sink API V2 to Public and Deprecate SinkFunction

2024-05-04 Thread Ahmed Hamdy
blockers are implemented? Best Regards Ahmed Hamdy On Fri, 3 May 2024 at 14:32, Péter Váry wrote: > > With regards to FLINK-35149, the fix version indicates a change at Flink > CDC; is that indeed correct, or does it require a change in the SinkV2 > interface? > > The fix does

Re: [DISCUSS] FLIP-451: Refactor Async sink API

2024-04-29 Thread Ahmed Hamdy
Hi Jeyhun, Thanks for your feedback. I agree the phrasing is a bit confusing, the main scope for FLIP-451 is limited to introducing timeout configuration and the new "ResultHandler" to Async Sink API. I will remove reference to FLIP-284 from the FLIP to disambiguate. Best Regards Ahmed

[DISCUSS] FLIP-451: Refactor Async sink API

2024-04-29 Thread Ahmed Hamdy
requests. The FLIP targets 1.20 with backward compatible changes and we should proceed by adding support in all supporting connector repos. 1- https://cwiki.apache.org/confluence/display/FLINK/FLIP-451%3A+Refactor+Async+Sink+API Best Regards Ahmed Hamdy

Re: [ DISCUSS ] FLIP-XXX : [Plugin] Enhancing Flink Failure Management in Kubernetes with Dynamic Termination Log Integration

2024-04-24 Thread Ahmed Hamdy
enrichers into reference. Best Regards Ahmed Hamdy On Tue, 23 Apr 2024 at 15:23, Martijn Visser wrote: > From a procedural point of view, we shouldn't make FLIPs sub-tasks for > existing FLIPs that have been voted/are released. That will only cause > confusion down the line. A new FL

Re: [VOTE] Release flink-connector-cassandra v3.2.0, release candidate #1

2024-04-24 Thread Ahmed Hamdy
Thanks Danny, +1 (non-binding) - Verified Checksums and hashes - Verified Signatures - Reviewed web PR - github tag exists - Build source Best Regards Ahmed Hamdy On Tue, 23 Apr 2024 at 03:57, Muhammet Orazov wrote: > Thanks! +1 (non-binding) > > - Checked 512 hash > - Checked g

Re: [VOTE] Release flink-connector-kafka v3.2.0, release candidate #1

2024-04-24 Thread Ahmed Hamdy
Thanks Danny, +1 (non-binding) - Verified Checksums and hashes - Verified Signatures - Reviewed web PR - github tag exists - Build source Best Regards Ahmed Hamdy On Tue, 23 Apr 2024 at 03:47, Muhammet Orazov wrote: > Thanks Danny, +1 (non-binding) > > - Checked 512 hash > -

Re: [VOTE] FLIP-436: Introduce Catalog-related Syntax

2024-04-24 Thread Ahmed Hamdy
Hi, +1 (non-binding) Best Regards Ahmed Hamdy On Wed, 24 Apr 2024 at 09:58, Yubin Li wrote: > Hi everyone, > > During the implementation of the "describe catalog" syntax, it was > found that the original output style needed to be improved. > ``` >

Re: [VOTE] Release flink-connector-aws v4.3.0, release candidate #2

2024-04-22 Thread Ahmed Hamdy
Thanks Danny, +1 (non-binding) - Verified Checksums - Verified Signatures - No binaries exists in source archive - Built source - Reviewed Web PR - Run basic Kinesis example Best Regards Ahmed Hamdy On Sun, 21 Apr 2024 at 14:25, Hang Ruan wrote: > +1 (non-binding) > > - Validated

Re: [VOTE] FLIP-442: General Improvement to Configuration for Flink 2.0

2024-04-18 Thread Ahmed Hamdy
+1 (non-binding) Great work! Best Regards Ahmed Hamdy On Wed, 17 Apr 2024 at 14:36, Jeyhun Karimov wrote: > +1 (non binding) > > Regards, > Jeyhun > > On Wed, Apr 17, 2024 at 2:22 PM Zhu Zhu wrote: > > > +1 (binding) > > > > Thanks, > >

Re: [ DISCUSS ] FLIP-XXX : [Plugin] Enhancing Flink Failure Management in Kubernetes with Dynamic Termination Log Integration

2024-04-18 Thread Ahmed Hamdy
-304%3A+Pluggable+Failure+Enrichers Best Regards Ahmed Hamdy On Thu, 18 Apr 2024 at 08:23, Gyula Fóra wrote: > Hi Swathi! > > Thank you for creating this proposal. I really like the general idea of > increasing the K8s native observability of Flink job errors. > > I took a

Re: [VOTE] Release flink-connector-mongodb v1.2.0, release candidate #2

2024-04-18 Thread Ahmed Hamdy
+1 (non-binding) - verified hashes and checksums - verified signature - verified source contains no binaries - tag exists in github - reviewed web PR Best Regards Ahmed Hamdy On Thu, 18 Apr 2024 at 11:21, Danny Cranmer wrote: > Hi everyone, > > Please review and vote on th

Re: [VOTE] Release flink-connector-jdbc v3.2.0, release candidate #2

2024-04-18 Thread Ahmed Hamdy
+1 (non-binding) - Verified Checksums and hashes - Verified Signatures - No binaries in source - Build source - Github tag exists - Reviewed Web PR Best Regards Ahmed Hamdy On Thu, 18 Apr 2024 at 11:22, Danny Cranmer wrote: > Sorry for typos: > > > Please review and vote on

Re: [DISCUSS] FLIP-445: Support dynamic parallelism inference for HiveSource

2024-04-18 Thread Ahmed Hamdy
Hi Xia, I have read through the FLIP and discussion and the new version of the FLIP looks better. +1 for the proposal. Best Regards Ahmed Hamdy On Thu, 18 Apr 2024 at 12:21, Ron Liu wrote: > Hi, Xia > > Thanks for updating, looks good to me. > > Best, > Ron > > Xia Su

Re: [VOTE] Release flink-connector-gcp-pubsub v3.1.0, release candidate #1

2024-04-18 Thread Ahmed Hamdy
Hi Danny, +1 (non-binding) - verified hashes and checksums - verified signature - verified source contains no binaries - tag exists in github - reviewed web PR Best Regards Ahmed Hamdy On Thu, 18 Apr 2024 at 11:32, Danny Cranmer wrote: > Hi everyone, > > Please review and vote o

Re: [VOTE] Release flink-connector-aws v4.3.0, release candidate #1

2024-04-17 Thread Ahmed Hamdy
Hi Danny, Thanks for driving this. +1 (non-binding) - Checksum verified - Signature and Keys match - Licenses checked - Build from source - Run Kinesis example - Reviewed web PR Best Regards Ahmed Hamdy On Tue, 16 Apr 2024 at 13:01, Jeyhun Karimov wrote: > +1 (non-binding) > > -

Re: [VOTE] FLIP-435: Introduce a New Materialized Table for Simplifying Data Pipelines

2024-04-17 Thread Ahmed Hamdy
+ 1 (non-binding) Best Regards Ahmed Hamdy On Wed, 17 Apr 2024 at 08:28, Yuepeng Pan wrote: > +1(non-binding). > > > > > Best, > Yuepeng Pan > > At 2024-04-17 14:27:27, "Ron liu" wrote: > >Hi Dev, > > > >Thank you to everyone for th

  1   2   >