Hi Jeyhun, I have changed the scope of FLIP to exclude problems addressed by FLIP-284 and redefined scope to introduce timeout configuration. Best Regards Ahmed Hamdy
On Mon, 29 Apr 2024 at 20:57, Ahmed Hamdy <hamdy10...@gmail.com> wrote: > Hi Jeyhun, > Thanks for your feedback. I agree the phrasing is a bit confusing, the > main scope for FLIP-451 is limited to introducing timeout configuration and > the new "ResultHandler" to Async Sink API. > I will remove reference to FLIP-284 from the FLIP to disambiguate. > Best Regards > Ahmed Hamdy > > > On Mon, 29 Apr 2024 at 17:59, Jeyhun Karimov <je.kari...@gmail.com> wrote: > >> Hi Ahmed, >> >> Thanks a lot for the FLIP. +1 for it. >> My main concern is that the boundary/scope of the two FLIPs (451 and 284) >> and their differentiation/overlap is unclear for me from the FLIP >> document. >> Could you please elaborate more on this? >> >> Regards, >> Jeyhun >> >> >> On Mon, Apr 29, 2024 at 4:13 PM Ahmed Hamdy <hamdy10...@gmail.com> wrote: >> >> > Hi all, >> > I would like to start a discussion on FLIP-451[1] >> > The proposal comes on encountering a couple of issues while working with >> > implementers for Async Sink. >> > The FLIP mainly proposes a new API similar to AsyncFunction and >> > ResultFuture as well as introducing timeout handling for AsyncSink >> > requests. >> > The FLIP targets 1.20 with backward compatible changes and we should >> > proceed by adding support in all supporting connector repos. >> > >> > 1- >> > >> > >> https://cwiki.apache.org/confluence/display/FLINK/FLIP-451%3A+Refactor+Async+Sink+API >> > Best Regards >> > Ahmed Hamdy >> > >> >
