Hi Lorenzo, yes it is pretty useful to start tackling the ones that still don't implement the new interface, happy so sync offline to close this task, additionally a volunteer to review the migrations would be highly appreciated. Best Regards Ahmed Hamdy
On Wed, 15 May 2024 at 10:01, <lorenzo.affe...@ververica.com.invalid> wrote: > Thank you Martijn for the detailed FLIP. > Will save this for the future as an example for these kind of FLIPs :) > > This also shakes the adoption of the new interface for downstream > connectors. > Volunteered for the pubsub port (table API), and trying to assess the > current status of pending PRs. > > I give you my +1 (non-bingind) :) > On May 13, 2024 at 11:52 +0200, Ahmed Hamdy <hamdy10...@gmail.com>, wrote: > > Thanks for the clarification. > > +1 to starting the vote. > > Best Regards > > Ahmed Hamdy > > > > > > On Mon, 13 May 2024 at 09:10, Martijn Visser <martijnvis...@apache.org> > > wrote: > > > > > Hi Ahmed, > > > > > > There's no reason to refrain from releases for Flink 1.* versions: > these > > > connector implementations are still supported in the Flink 1.* series. > > > > > > Best regards, > > > > > > Martijn > > > > > > On Sun, May 12, 2024 at 5:55 PM Ahmed Hamdy <hamdy10...@gmail.com> > wrote: > > > > > > > > Thanks Martijn > > > > > I believe you missed my question, > > > > > > > > > > Should this change take place in 1.20, what are the planned > release steps > > > > > > > for connectors that only offer a deprecated interface in this > case > > > (i.e. > > > > > > > RabbitMQ, Cassandra, pusbub, Hbase)? Are we going to refrain > from > > > > > releases > > > > > > > till the blockers are implemented? > > > > > > > > > > > > > > > > > Could you please clarify? > > > > > > > > > > Best Regards > > > > > Ahmed Hamdy > > > > > > > > > > > > > > > On Sun, 12 May 2024 at 14:07, Martijn Visser < > martijnvis...@apache.org> > > > > > wrote: > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > If there are no more considerations, I'll open up a vote in > the next > > > > > couple > > > > > > > of days. > > > > > > > > > > > > > > Best regards, > > > > > > > > > > > > > > Martijn > > > > > > > > > > > > > > On Wed, May 8, 2024 at 4:08 AM Hongshun Wang < > loserwang1...@gmail.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > Hi Martijn, Thanks for the proposal +1 from me.Some sinks > still use > > > > > > > > > sinkfunction; it's time to take a step forward. > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > Hongshun > > > > > > > > > > > > > > > > > > On Mon, May 6, 2024 at 5:44 PM Leonard Xu < > xbjt...@gmail.com> wrote: > > > > > > > > > > > > > > > > > > > > +1 from my side, thanks Martijn for the effort. > > > > > > > > > > > > > > > > > > > > > > Best, > > > > > > > > > > > Leonard > > > > > > > > > > > > > > > > > > > > > > > > 2024年5月4日 下午7:41，Ahmed Hamdy <hamdy10...@gmail.com> > 写道： > > > > > > > > > > > > > > > > > > > > > > > > > > Hi Martijn > > > > > > > > > > > > > Thanks for the proposal +1 from me. > > > > > > > > > > > > > Should this change take place in 1.20, what are > the planned > > > release > > > > > > > > > steps > > > > > > > > > > > > > for connectors that only offer a deprecated > interface in this > > > case > > > > > > > > > (i.e. > > > > > > > > > > > > > RabbitMQ, Cassandra, pusbub, Hbase)? Are we going > to refrain from > > > > > > > > > > > releases > > > > > > > > > > > > > that support 1.20+ till the blockers are > implemented? > > > > > > > > > > > > > Best Regards > > > > > > > > > > > > > Ahmed Hamdy > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, 3 May 2024 at 14:32, Péter Váry < > > > > > peter.vary.apa...@gmail.com > > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > >>> With regards to FLINK-35149, the fix version > indicates a change > > > > > at > > > > > > > > > > > Flink > > > > > > > > > > > > > >> CDC; is that indeed correct, or does it require > a change in the > > > > > > > SinkV2 > > > > > > > > > > > > > >> interface? > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> The fix doesn't need change in SinkV2, so we > are good there. > > > > > > > > > > > > > >> The issue is that the new SinkV2 > > > > > > > > > > > SupportsCommitter/SupportsPreWriteTopology > > > > > > > > > > > > > >> doesn't work with the CDC yet. > > > > > > > > > > > > > >> > > > > > > > > > > > > > >> Martijn Visser <martijnvis...@apache.org> ezt > írta (időpont: > > > > > 2024. > > > > > > > > > máj. > > > > > > > > > > > > > >> 3., > > > > > > > > > > > > > >> P, 14:06): > > > > > > > > > > > > > >> > > > > > > > > > > > > > > >>> Hi Ferenc, > > > > > > > > > > > > > > >>> > > > > > > > > > > > > > > >>> You're right, 1.20 it is :) > > > > > > > > > > > > > > >>> > > > > > > > > > > > > > > >>> I've assigned the HBase one to you! > > > > > > > > > > > > > > >>> > > > > > > > > > > > > > > >>> Thanks, > > > > > > > > > > > > > > >>> > > > > > > > > > > > > > > >>> Martijn > > > > > > > > > > > > > > >>> > > > > > > > > > > > > > > >>> On Fri, May 3, 2024 at 1:55 PM Ferenc Csaky > > > > > > > > > <ferenc.cs...@pm.me.invalid > > > > > > > > > > > > > > > > > > > > > > > > > > > >>> wrote: > > > > > > > > > > > > > > >>> > > > > > > > > > > > > > > > >>>> Hi Martijn, > > > > > > > > > > > > > > > >>>> > > > > > > > > > > > > > > > >>>> +1 for the proposal. > > > > > > > > > > > > > > > >>>> > > > > > > > > > > > > > > > > >>>>> targeted for Flink 1.19 > > > > > > > > > > > > > > > >>>> > > > > > > > > > > > > > > > >>>> I guess you meant Flink 1.20 here. > > > > > > > > > > > > > > > >>>> > > > > > > > > > > > > > > > >>>> Also, I volunteer to take updating the > HBase sink, feel free > > > to > > > > > > > > > assign > > > > > > > > > > > > > > > >>>> that task to me. > > > > > > > > > > > > > > > >>>> > > > > > > > > > > > > > > > >>>> Best, > > > > > > > > > > > > > > > >>>> Ferenc > > > > > > > > > > > > > > > >>>> > > > > > > > > > > > > > > > >>>> > > > > > > > > > > > > > > > >>>> > > > > > > > > > > > > > > > >>>> > > > > > > > > > > > > > > > >>>> On Friday, May 3rd, 2024 at 10:20, > Martijn Visser < > > > > > > > > > > > > > > > >>>> martijnvis...@apache.org> wrote: > > > > > > > > > > > > > > > >>>> > > > > > > > > > > > > > > > > >>>>> > > > > > > > > > > > > > > > > >>>>> > > > > > > > > > > > > > > > > >>>>> Hi Peter, > > > > > > > > > > > > > > > > >>>>> > > > > > > > > > > > > > > > > >>>>> I'll add it for completeness, thanks! > > > > > > > > > > > > > > > > >>>>> With regards to FLINK-35149, the fix > version indicates a > > > change > > > > > > > at > > > > > > > > > > > > > > >>> Flink > > > > > > > > > > > > > > > > >>>>> CDC; is that indeed correct, or does > it require a change in > > > the > > > > > > > > > > > > > >> SinkV2 > > > > > > > > > > > > > > > > >>>>> interface? > > > > > > > > > > > > > > > > >>>>> > > > > > > > > > > > > > > > > >>>>> Best regards, > > > > > > > > > > > > > > > > >>>>> > > > > > > > > > > > > > > > > >>>>> Martijn > > > > > > > > > > > > > > > > >>>>> > > > > > > > > > > > > > > > > >>>>> > > > > > > > > > > > > > > > > >>>>> On Fri, May 3, 2024 at 7:47 AM Péter > Váry > > > > > > > > > > > > > >> peter.vary.apa...@gmail.com > > > > > > > > > > > > > > > > >>>>> > > > > > > > > > > > > > > > > >>>>> wrote: > > > > > > > > > > > > > > > > >>>>> > > > > > > > > > > > > > > > > > >>>>>> Hi Martijn, > > > > > > > > > > > > > > > > > >>>>>> > > > > > > > > > > > > > > > > > >>>>>> We might want to add FLIP-371 [1] > to the list. (Or we aim > > > only > > > > > > > for > > > > > > > > > > > > > > > >>>> higher > > > > > > > > > > > > > > > > > >>>>>> level FLIPs?) > > > > > > > > > > > > > > > > > >>>>>> > > > > > > > > > > > > > > > > > >>>>>> We are in the process of using the > new API in Iceberg > > > > > connector > > > > > > > > > > > > > >> [2] - > > > > > > > > > > > > > > > >>>> so > > > > > > > > > > > > > > > > > >>>>>> far, so good. > > > > > > > > > > > > > > > > > >>>>>> > > > > > > > > > > > > > > > > > >>>>>> I know of one minor known issue > about the sink [3], which > > > > > should > > > > > > > > > be > > > > > > > > > > > > > > > >>>> ready > > > > > > > > > > > > > > > > > >>>>>> for the release. > > > > > > > > > > > > > > > > > >>>>>> > > > > > > > > > > > > > > > > > >>>>>> All-in-all, I think we are in good > shape, and we could move > > > > > > > > > forward > > > > > > > > > > > > > > > >>>> with > > > > > > > > > > > > > > > > > >>>>>> the promotion. > > > > > > > > > > > > > > > > > >>>>>> > > > > > > > > > > > > > > > > > >>>>>> Thanks, > > > > > > > > > > > > > > > > > >>>>>> Peter > > > > > > > > > > > > > > > > > >>>>>> > > > > > > > > > > > > > > > > > >>>>>> [1] - > > > > > > > > > > > > > > > > > >>>>>> > > > > > > > > > > > > > > > > > >>>>>> > > > > > > > > > > > > > > > >>>> > > > > > > > > > > > > > > >>> > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=263430387 > > > > > > > > > > > > > > > > > >>>>>> [2] - > https://github.com/apache/iceberg/pull/10179 > > > > > > > > > > > > > > > > > >>>>>> [3] - > https://issues.apache.org/jira/browse/FLINK-35149 > > > > > > > > > > > > > > > > > >>>>>> > > > > > > > > > > > > > > > > > >>>>>> On Thu, May 2, 2024, 09:47 Muhammet > Orazov > > > > > > > > > > > > > > > >>>> mor+fl...@morazow.com.invalid > > > > > > > > > > > > > > > > > >>>>>> wrote: > > > > > > > > > > > > > > > > > >>>>>> > > > > > > > > > > > > > > > > > > >>>>>>> Got it, thanks! > > > > > > > > > > > > > > > > > > >>>>>>> > > > > > > > > > > > > > > > > > > >>>>>>> On 2024-05-02 06:53, Martijn > Visser wrote: > > > > > > > > > > > > > > > > > > >>>>>>> > > > > > > > > > > > > > > > > > > > >>>>>>>> Hi Muhammet, > > > > > > > > > > > > > > > > > > > >>>>>>>> > > > > > > > > > > > > > > > > > > > >>>>>>>> Thanks for joining the > discussion! The changes in this > > > FLIP > > > > > > > > > > > > > >> would > > > > > > > > > > > > > > > >>>> be > > > > > > > > > > > > > > > > > > > >>>>>>>> targeted for Flink 1.19, > since it's only a matter of > > > > > changing > > > > > > > > > > > > > >> the > > > > > > > > > > > > > > > > > > > >>>>>>>> annotation. > > > > > > > > > > > > > > > > > > > >>>>>>>> > > > > > > > > > > > > > > > > > > > >>>>>>>> Best regards, > > > > > > > > > > > > > > > > > > > >>>>>>>> > > > > > > > > > > > > > > > > > > > >>>>>>>> Martijn > > > > > > > > > > > > > > > > > > > >>>>>>>> > > > > > > > > > > > > > > > > > > > >>>>>>>> On Thu, May 2, 2024 at > 7:26 AM Muhammet Orazov > > > > > > > > > > > > > > > >>>> mor+fl...@morazow.com > > > > > > > > > > > > > > > > > > > >>>>>>>> wrote: > > > > > > > > > > > > > > > > > > > >>>>>>>> > > > > > > > > > > > > > > > > > > > > >>>>>>>>> Hello Martijn, > > > > > > > > > > > > > > > > > > > > >>>>>>>>> > > > > > > > > > > > > > > > > > > > > >>>>>>>>> Thanks for the FLIP and > detailed history of changes, +1. > > > > > > > > > > > > > > > > > > > > >>>>>>>>> > > > > > > > > > > > > > > > > > > > > >>>>>>>>> Would FLIP changes target > for 2.0? I think it would be > > > good > > > > > > > > > > > > > > > > > > > > >>>>>>>>> to have clear APIs on 2.0 > release. > > > > > > > > > > > > > > > > > > > > >>>>>>>>> > > > > > > > > > > > > > > > > > > > > >>>>>>>>> Best, > > > > > > > > > > > > > > > > > > > > >>>>>>>>> Muhammet > > > > > > > > > > > > > > > > > > > > >>>>>>>>> > > > > > > > > > > > > > > > > > > > > >>>>>>>>> On 2024-05-01 15:30, > Martijn Visser wrote: > > > > > > > > > > > > > > > > > > > > >>>>>>>>> > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> Hi everyone, > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> I would like to start a > discussion on FLIP-453: Promote > > > > > > > > > > > > > > > >>>> Unified Sink > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> API V2 > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> to Public and Deprecate > SinkFunction > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> > https://cwiki.apache.org/confluence/x/rIobEg > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> This FLIP proposes to > promote the Unified Sink API V2 > > > from > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> PublicEvolving > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> to Public and to mark > the SinkFunction as Deprecated. > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> I'm looking forward to > your thoughts. > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> Best regards, > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> > > > > > > > > > > > > > > > > > > > > > >>>>>>>>>> Martijn > > > > > > > > > > > > > > > >>>> > > > > > > > > > > > > > > >>> > > > > > > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
