Thanks Hong for driving,
 +1 (non-binding)

- Release notes look good
- Verified there are no blocker issues.
- Verified signatures and hashsums
- No binaries in source
- Build source using maven and jdk11
- Verified tag is present in repo


Best Regards
Ahmed Hamdy


On Fri, 8 Nov 2024 at 02:28, Xintong Song <tonysong...@gmail.com> wrote:

> +1 (binding)
>
> - verified signatures and checksum
> - built from source
> - reviewed web PR
>
> Best,
>
> Xintong
>
>
>
> On Fri, Nov 8, 2024 at 9:44 AM weijie guo <guoweijieres...@gmail.com>
> wrote:
>
> > +1(binding)
> >
> > - verified signatures
> > - verified checksums
> > - checked github release tag
> > - checked release notes
> > - reviewed the web PR
> > - built from source
> >
> > Best regards,
> >
> > Weijie
> >
> >
> > Danny Cranmer <dannycran...@apache.org> 于2024年11月7日周四 18:25写道:
> >
> > > Thanks Hong for driving and addressing the issues in the previous
> release
> > > candidate.
> > >
> > > +1 (binding)
> > >
> > > * Release notes look good
> > > * Source archive signatures and checksums match
> > > * There are no binaries in the source
> > > * Build source using Maven
> > > * Verified Apache headers exist and are correct in the new SQS
> connector
> > > * Contents of Maven repo look complete
> > > * Binary signatures and checksums match
> > > * Tag is present in repo
> > > * CI build of tag passes
> > > * Approved web PR
> > >
> > > Thanks,
> > > Danny
> > >
> > > On Wed, Nov 6, 2024 at 4:48 PM Hong Liang <hlteo...@gmail.com> wrote:
> > >
> > > > Hi everyone,
> > > > Please review and vote on release candidate #3 for
> flink-connector-aws
> > > > v5.0.0, as follows:
> > > > [ ] +1, Approve the release
> > > > [ ] -1, Do not approve the release (please provide specific comments)
> > > >
> > > >
> > > > The complete staging area is available for your review, which
> includes:
> > > > * JIRA release notes [1],
> > > > * the official Apache source release to be deployed to
> dist.apache.org
> > > > [2],
> > > > which are signed with the key with fingerprint B78A5EA1 [3],
> > > > * all artifacts to be deployed to the Maven Central Repository [4],
> > > > * source code tag v5.0.0-rc3 [5],
> > > > * website pull request listing the new release [6].
> > > > * CI build of the tag [7].
> > > >
> > > > The vote will be open for at least 72 hours. It is adopted by
> majority
> > > > approval, with at least 3 PMC affirmative votes.
> > > >
> > > > Thanks,
> > > > Hong
> > > >
> > > > [1]
> > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12355257
> > > > [2]
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/flink/flink-connector-aws-5.0.0-rc3
> > > > [3] https://dist.apache.org/repos/dist/release/flink/KEYS
> > > > [4]
> > > https://repository.apache.org/content/repositories/orgapacheflink-1767
> > > > [5]
> > > https://github.com/apache/flink-connector-aws/releases/tag/v5.0.0-rc3
> > > > [6] https://github.com/apache/flink-web/pull/760
> > > > [7]
> > > https://github.com/apache/flink-connector-aws/actions/runs/11707619997
> > > >
> > >
> >
>

Reply via email to