I did more digging. Imo the clearing of the flag is not the correct fix. It
only fixes the bug because it makes the ftetextfield switch to plain text
composition which is why the tests failed. It looks like the tcm has a weird
behavior of assuming that any existing textlines were composed from t
rigine-
De : Alex Harui [mailto:aha...@adobe.com]
Envoyé : jeudi 10 octobre 2013 18:12
À : Maurice Amsellem; dev@flex.apache.org
Objet : Re: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)
On 10/10/13 8:58 AM, "Maurice Amsellem"
wrote:
>I get it.
>
>So I wi
Hi,
>> Doesn't doing this tf.text = txt also set htmlText to null?
> I don't see that happening in the setter, but I might have missed it.
Look at all the configX (1-8) methods in global.as some set htmlText, some set
text. This is one the same text field.
Thanks,
Justin
When you try to use FTE within MX components without a stylesheet
explicitly declared it won't render any text under certain circumstances.
This was just a simple fix to force the htmlText to be regenerated and
therefore display. I ran into this issue when trying to debug an issue I
was having wi
On 10/10/13 8:58 AM, "Maurice Amsellem"
wrote:
>I get it.
>
>So I will try to change the code so that it supports both the old
>behavior (ie by subclassing) and new behavior (ie by styling).
I'm sure some users will be very happy if you do that. You don't have to,
you just have to judge how
; dev@flex.apache.org
Objet : Re: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)
On 10/9/13 11:51 PM, "Maurice Amsellem"
wrote:
>Understood.
>
>In this case, I' am changing the test code so that it matches the
>existing baseline, not changing the baseline.
>So it sh
On 10/10/13 12:17 AM, "Maurice Amsellem"
wrote:
>
>But how do I generate the 4 other ones?
>I tried different Target_os_name and adl_extras but it didn't work.
Don't worry about any other bitmaps for now. They are broken in lots of
other cases as well.
-Alex
On 10/9/13 11:51 PM, "Maurice Amsellem"
wrote:
>Understood.
>
>In this case, I' am changing the test code so that it matches the
>existing baseline, not changing the baseline.
>So it should not have any impact.
Maybe I'm not understanding you, but IMO, the test code represents a
user's applicat
On 10/10/13 12:01 AM, "Justin Mclean" wrote:
>Hi,
>
>> The test doesn't seem to be setting htmlText to null, but I haven't
>>stepped through it.
>Doesn't doing this tf.text = txt also set htmlText to null?
I don't see that happening in the setter, but I might have missed it. And
for me, the fa
On 10/10/13 4:40 AM, "Nicholas Kwiatkowski" wrote:
>My revert was on hash e3d52e485c1063a71d3682750ac0c2eb833f193a
>submitted on 10/8/13 @ 12:15am according to my git history. I haven't
>done
>a pull yet from remote. It was showing up in the logs on the website (it
>is not anymore). Maybe it
My revert was on hash e3d52e485c1063a71d3682750ac0c2eb833f193a
submitted on 10/8/13 @ 12:15am according to my git history. I haven't done
a pull yet from remote. It was showing up in the logs on the website (it
is not anymore). Maybe it got clobbered during Justin's merge fix a few
hours after t
.@adobe.com] Envoyé : jeudi 10 octobre 2013 02:43
À : dev@flex.apache.org; Maurice Amsellem Objet : RE: Build failed in Jenkins:
flex-sdk_mustella #460 (fixed)
When you change a test please consider impact on folks who might have pixel
tuned their app and may notice the difference. I'm not s
Hi,
> The test doesn't seem to be setting htmlText to null, but I haven't stepped
> through it.
Doesn't doing this tf.text = txt also set htmlText to null?
> First, I want to figure out what went wrong with Git,
There's noting wrong with it - it's git? :-)
Thanks,
Justin
43
À : dev@flex.apache.org; Maurice Amsellem
Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)
When you change a test please consider impact on folks who might have pixel
tuned their app and may notice the difference. I'm not saying don't change, but
be careful.
Sent via the
re tomorrow...
-Alex
From: Justin Mclean [jus...@classsoftware.com]
Sent: Wednesday, October 09, 2013 11:07 PM
To: dev@flex.apache.org
Subject: Re: Build failed in Jenkins: flex-sdk_mustella #460
Hi,
> When I look at the diffs, I don't see the clearFlag line until Nick adds i
Here is the commit history to the file:
https://fisheye6.atlassian.com/browse/~br=develop/flex-sdk/frameworks/projects/spark/src/mx/core/FTETextField.as
I dont see Nick's revert.
Thanks,
Om
On Wed, Oct 9, 2013 at 11:07 PM, Justin Mclean wrote:
> Hi,
>
> > When I look at the diffs, I don't see
Hi,
> When I look at the diffs, I don't see the clearFlag line until Nick adds it.
> The comment above the "if (!stylesheet)" makes me think the flag shouldn't be
> cleared, but I haven't really looked into it.
If htmlText is set to null I think the HTML flag needs to be cleared, I think
(but
now, I'm more puzzled why Nick's revert isn't showing up.
-Alex
From: Justin Mclean [jmcl...@apache.org]
Sent: Wednesday, October 09, 2013 10:21 PM
To: dev@flex.apache.org
Subject: Re: Build failed in Jenkins: flex-sdk_mustella #460
Hi,
>
Hi,
> What do you see that's wrong with the tests?
If you look at the fix:
From:
if (!styleSheet)
htmlText = null;
textfield.clearFlag(FTETextField.FLAG_HTML_TEXT_SET);
To:
if (!styleSheet)
{
htmlText = null;
textfield.clearFlag(F
[flex.muste...@gmail.com]
Sent: Tuesday, October 08, 2013 9:42 PM
To: comm...@flex.apache.org; jmcl...@apache.org; maurice.amsel...@systar.com
Subject: Build failed in Jenkins: flex-sdk_mustella #460
See <http://localhost:8080/job/flex-sdk_mustella/460/changes>
Changes:
[jmclean] Renamed
October 08, 2013 9:42 PM
To: comm...@flex.apache.org; jmcl...@apache.org; maurice.amsel...@systar.com
Subject: Build failed in Jenkins: flex-sdk_mustella #460
See <http://localhost:8080/job/flex-sdk_mustella/460/changes>
Changes:
[jmclean] Renamed supportClazzes package to be called supoortC
sssoftware.com]
Envoyé : jeudi 10 octobre 2013 01:23
À : dev@flex.apache.org
Objet : Re: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)
Hi,
> So the variable showBorder on line 579 is set to true.
If borderThinkness is 0 shouldn't showBorder be false? Then the callout should
be
Will do that tomorrow.
Have to go to bed now.
Maurice
-Message d'origine-
De : Justin Mclean [mailto:jus...@classsoftware.com]
Envoyé : jeudi 10 octobre 2013 01:48
À : dev@flex.apache.org
Objet : Re: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)
Hi,
> Should I ch
Hi,
> Should I change the test ?
Seems the right option to me, we're changed the code slightly we can change the
test to match.
Thanks,
Justin
23
À : dev@flex.apache.org
Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)
Option 1) removing the added lines, eliminates all the failures.
While Option 2) [ adding the missing borderThickness:NaN ] stills has one
failure.
So if you think the border option will be useful in mobil
: Justin Mclean [mailto:jus...@classsoftware.com]
Envoyé : jeudi 10 octobre 2013 01:23
À : dev@flex.apache.org
Objet : Re: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)
Hi,
> So the variable showBorder on line 579 is set to true.
If borderThinkness is 0 shouldn't showBorder be false?
Hi,
> So the variable showBorder on line 579 is set to true.
If borderThinkness is 0 shouldn't showBorder be false? Then the callout should
be in the right position.
Thanks,
Justin
.
Otherwise, Option 1) is fine for me...
Let me know.
Maurice
-Message d'origine-
De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
Envoyé : jeudi 10 octobre 2013 01:16
À : dev@flex.apache.org
Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)
I found out:
I
h is still
not perfect, but much better.
I am now testing option 1.
Let me know what you prefer.
Maurice
-Message d'origine-
De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
Envoyé : jeudi 10 octobre 2013 00:45
À : dev@flex.apache.org
Objet : RE: Build failed in Jenkins: fle
e 2013 00:52
À : dev@flex.apache.org
Objet : Re: Build failed in Jenkins: flex-sdk_mustella #460
Hi,
> I think when it's running on ADL on windows , it will use "win". Correct ?
I assumed it would use the android one, if emulating android it should be
comparing the andr
Hi,
> I think when it's running on ADL on windows , it will use "win". Correct ?
I assumed it would use the android one, if emulating android it should be
comparing the android images right?
On OSX.
With this local.properties:
target_os_name=android
device_name=osx
And running the tests like
ellem [mailto:maurice.amsel...@systar.com]
Envoyé : jeudi 10 octobre 2013 00:40
À : dev@flex.apache.org
Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460
Finally, the .bad.png images are also there for the 6 initial 240 ppi failures
in the baseline dirs.
YES!
Comparing them now...
Ma
matter right now.
-Alex
From: Maurice Amsellem [maurice.amsel...@systar.com]
Sent: Wednesday, October 09, 2013 3:35 PM
To: dev@flex.apache.org
Subject: RE: Build failed in Jenkins: flex-sdk_mustella #460
I will give a try to the createBitmaps option.
BTW it will show what bitmaps are
Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460
I will give a try to the createBitmaps option.
BTW it will show what bitmaps are actually used...
Maurice
-Message d'origine-
De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
Envoyé : jeudi 10 octobre 2013 00:
Hi,
> Note: the error says " created image .bad.png", does it also create these
> images when baseline is found, but compare fails ?
> If so, where do I find it ?
In the baselines directory for the test.
Justin
nkins: flex-sdk_mustella #460
But maybe it's using the "android" bitmaps, like you said, not the "win" ones.
Maurice
-Message d'origine-
De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : jeudi 10 octobre
2013 00:28 À : dev@flex.apache.org Objet :
I found the .bad.png images, they are in the same baselines directory.
Maurice
-Message d'origine-
De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
Envoyé : jeudi 10 octobre 2013 00:30
À : dev@flex.apache.org
Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460
I
But maybe it's using the "android" bitmaps, like you said, not the "win" ones.
Maurice
-Message d'origine-
De : Justin Mclean [mailto:jus...@classsoftware.com]
Envoyé : jeudi 10 octobre 2013 00:28
À : dev@flex.apache.org
Objet : Re: Build failed in Jenki
e-
De : Justin Mclean [mailto:jus...@classsoftware.com]
Envoyé : jeudi 10 octobre 2013 00:24
À : dev@flex.apache.org
Objet : Re: Build failed in Jenkins: flex-sdk_mustella #460
Hi,
> integration\baselines\Skin_test_1@win_240ppi.png
> integration\baselines\Change_skin_at_runtime@win_240
Hi,
> If I backup the baselines dir and run the test with -createImages option, I
> will be able to check the differences.
Bit hard to check the differences if they don't exist in the first place. :-)
Justin
pache.org
Objet : Re: Build failed in Jenkins: flex-sdk_mustella #460
Hi,
> integration\baselines\Skin_test_1@win_240ppi.png
> integration\baselines\Change_skin_at_runtime@win_240ppi.png
> integration\baselines\Callout_skin @win_240ppi.png
I think it should be using the @android b
: dev@flex.apache.org
Objet : Re: Build failed in Jenkins: flex-sdk_mustella #460
>From the VM's failures.txt, these are the failing tests:
mobile/SplitViewNavigator/integration/SplitViewNavigator_integration
Skin_test_1
mobile/SplitViewNavigator/integration/SplitViewNavigato
Hi,
> integration\baselines\Skin_test_1@win_240ppi.png
> integration\baselines\Change_skin_at_runtime@win_240ppi.png
> integration\baselines\Callout_skin @win_240ppi.png
I think it should be using the @android bitmaps. I have target_os_name=android
in local.properties (as mentioned before) - per
set device-name to win)
>
> -Message d'origine-
> De : Justin Mclean [mailto:jus...@classsoftware.com]
> Envoyé : jeudi 10 octobre 2013 00:16
> À : dev@flex.apache.org
> Objet : Re: Build failed in Jenkins: flex-sdk_mustella #460
>
> Hi,
>
> > Is it possi
See my next email about missing baseline bitmaps.
I am running on windows (so set device-name to win)
-Message d'origine-
De : Justin Mclean [mailto:jus...@classsoftware.com]
Envoyé : jeudi 10 octobre 2013 00:16
À : dev@flex.apache.org
Objet : Re: Build failed in Jenkins:
Hi,
> Is it possible that it's related to the Callout merge ?
Those tests do use callouts so it possible but may not be the issue.
How are you funning the tests? Running here I get no failures and all 50 odd
tests pass.
Thanks,
Justin
Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460
Hi, I have run the SplitNavigatorView and also had the 6 fails:
[java] mobile/SplitViewNavigator/integration/SplitViewNavigator_integration
Skin_test_1 Failed CompareBitmap(body:step 4) compare returned-3
[java]
m
ences are ?
Thanks
Maurice
-Message d'origine-
De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
Envoyé : mercredi 9 octobre 2013 20:04
À : dev@flex.apache.org
Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460
Ah sorry.
That what happens when you don't
something ?
>
>
Alex mentioned that it could be related to the supportClasses vs.
supportClazzes change.
Thanks,
Om
> Maurice
>
> -Message d'origine-
> De : Erik de Bruin [mailto:e...@ixsoftware.nl] Envoyé : mercredi 9
> octobre 2013 19:33 À : dev@flex.apache.org O
mentioned that it could be related to the supportClasses vs.
supportClazzes change.
Thanks,
Om
> Maurice
>
> -Message d'origine-
> De : Erik de Bruin [mailto:e...@ixsoftware.nl]
> Envoyé : mercredi 9 octobre 2013 19:33
> À : dev@flex.apache.org
> Objet : Re: Build f
33
À : dev@flex.apache.org
Objet : Re: Build failed in Jenkins: flex-sdk_mustella #460
Develop branch, of course.
And the current status is that both 'main' and 'mobile' have failing tests.
Where the 'main' failures seem mostly related to FTETextField and
Develop branch, of course.
And the current status is that both 'main' and 'mobile' have failing
tests. Where the 'main' failures seem mostly related to FTETextField
and the failures for 'mobile' center around SplitViewNavigator.
The VM runs on Windows Server 2008. The three Mustella test suites r
I will try to dig around this evening (9pm west coast) when I can get to my
Windows computer.
From: Nicholas Kwiatkowski [nicho...@spoon.as]
Sent: Wednesday, October 09, 2013 8:48 AM
To: dev@flex.apache.org
Subject: Re: Build failed in Jenkins: flex
That would be good to know... I could never get the FTETextField tests to
fail on my own copy of Mustella. Seems odd that the tests passed once then
failed again later...
On Wed, Oct 9, 2013 at 2:37 AM, Justin Mclean wrote:
> Hi,
>
> Is the testing VM using the master or develop branch of TLF?
On Tue, Oct 8, 2013 at 11:25 PM, Justin Mclean wrote:
> Hi,
>
> Can someone do a git status on the VM and check that the develop branch is
> where is suppose to be - perhaps something got out of sync?
>
> Justin
Erik, holler if you are around. I dont want to boot you out. If not I
will log in
Hi,
Is the testing VM using the master or develop branch of TLF?
Justin
Hi,
Can someone do a git status on the VM and check that the develop branch is
where is suppose to be - perhaps something got out of sync?
Justin
Hi,
> I think the other errors were related to SplitViewNavigators - which is
> mobile only.
I forgot it was a different set of tests.
But I've run them locally here and they pass fine as do the FTETextField tests,
so I think something is up.
Justin
On Tue, Oct 8, 2013 at 11:13 PM, Justin Mclean wrote:
> Hi,
>
> And what's happened to the other errors? Seem there something a bit odd
> going on to me.
>
> justin
I think the other errors were related to SplitViewNavigators - which is
mobile only. Are we missing anything else?
Thanks,
Om
Hi,
And what's happened to the other errors? Seem there something a bit odd going
on to me.
justin
Interesting... The revert of FTETextField doesn't seem to have solved
the failing of the FTETextField text.
And this run of Mustella decided to throw in a D&D failure as well,
but that occasionally seems to happen, so that isn't reason for
immediate worry.
However, with failing Mustella tests, we
61 matches
Mail list logo
