Ok, finally found out for the last failure:
Actually, one of the tests in using a custom callout skin,
SplitViewNavigator/swfs/skins/MyCalloutSkin.as which constructor is the
following:
public function MyCalloutSkin()
{
super();
contentCornerRadius=20;
frameThickness=10;
arrowWidth = 50;
arrowHeight = 50;
borderThickness = 10;
borderColor = 0xFF0000;
dropShadowVisible=true;
backgroundCornerRadius=30;
}
So of course, this does not work with option 2) as the values retrieved from
the css will overwrite the values set in the constructor.
And in effect, the 10 pixels red border around the Callout does not appear.
I can fix by settings the styles instead of the properties in the Constructor
above.
Again, let me know what you prefer. It's equal for me.
Maurice
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
Envoyé : jeudi 10 octobre 2013 01:23
À : dev@flex.apache.org
Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)
Option 1) removing the added lines, eliminates all the failures.
While Option 2) [ adding the missing borderThickness:NaN ] stills has one
failure.
So if you think the border option will be useful in mobile skins as well (
maybe on Android...) I can work on removing the last failure.
Otherwise, Option 1) is fine for me...
Let me know.
Maurice
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
Envoyé : jeudi 10 octobre 2013 01:16
À : dev@flex.apache.org
Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460 (fixed)
I found out:
I have added "borderStyle" and "borderThickness" styles to Callout class, so
that desktop skin have a 1pix border and look more like other components skins.
For consistency, I also changed the Callout and CalloutArrow mobile skins code
as well, so that it uses these styles:
411 borderThickness = getStyle("borderThickness");
412 borderColor = getStyle("borderColor");
Unfortunately, I forgot to set borderThickness in the defauls.css, thinking
that it would default to NaN; But when Number getStyle(...) is missing, it
convert to 0, not NaN :-(.
So the variable showBorder on line 579 is set to true.
So I have two options:
1) either I remove the added lines in the mobile skins
2) or I set borderThickness to NaN in the default css
Note: I have tried option 2, and the failures dropped to "1" , which is still
not perfect, but much better.
I am now testing option 1.
Let me know what you prefer.
Maurice
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
Envoyé : jeudi 10 octobre 2013 00:45
À : dev@flex.apache.org
Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460
I found out at list one difference:
In change_skin_at_runtime, the callout in exactly the same, but shifted one
pixel to the right.
Will try some changes in the mobile callout skin to see if the difference
disappears.
Will let you know.
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
Envoyé : jeudi 10 octobre 2013 00:40
À : dev@flex.apache.org
Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460
Finally, the .bad.png images are also there for the 6 initial 240 ppi failures
in the baseline dirs.
YES!
Comparing them now...
Maurice
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
Envoyé : jeudi 10 octobre 2013 00:36
À : dev@flex.apache.org
Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460
I will give a try to the createBitmaps option.
BTW it will show what bitmaps are actually used...
Maurice
-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsel...@systar.com]
Envoyé : jeudi 10 octobre 2013 00:33
À : dev@flex.apache.org
Objet : RE: Build failed in Jenkins: flex-sdk_mustella #460
But maybe it's using the "android" bitmaps, like you said, not the "win" ones.
Maurice
-----Message d'origine-----
De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : jeudi 10 octobre
2013 00:28 À : dev@flex.apache.org Objet : Re: Build failed in Jenkins:
flex-sdk_mustella #460
Hi,
> If I backup the baselines dir and run the test with -createImages option, I
> will be able to check the differences.
Bit hard to check the differences if they don't exist in the first place. :-)
Justin
