after rebase
Arnon Warshavsky (10):
crypto/dpaa: replace rte_panic instances in crypto/dpaa driver
bond: replace rte_panic instances in bonding driver
e1000: replace rte_panic instances in e1000 driver
ixgbe: replace rte_panic instances in ixgbe driver
eal: replace rte_panic instanc
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c | 10 ++
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/ixgbe/ixgbe_ethdev.c | 6 --
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
drivers/net/ixgbe/ixgbe_pf.c | 15
Replace panic calls with log and return value.
Local functions to this file,
changing from void to int are non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++-
drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/e1000/e1000_ethdev.h | 2 +-
drivers/net/e1000/igb_ethdev.c | 4 +++-
drivers/net/e1000/igb_pf.c | 15
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +---
lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eventdev
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_kni/rte_kni.c | 18 --
lib/librte_kni/rte_kni_fifo.h | 11 ---
2 files changed, 20 insertions
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 +
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
b/lib/librte_eal
Change some local functions return type from void to int.
This change does not break ABI as the functions are internal.
Panic thrown from threads was not handled in this patch
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/bsdapp/eal/eal.c | 69 +++---
lib/librte_eal
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_ether/rte_ethdev.c | 42 ++
lib/librte_ether/rte_ethdev.h | 4 +++-
2 files changed, 33 insertions(+), 13 deletions(-)
diff --git a
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
---
devtools/checkpatches.sh | 95
> I think i've already acked this. You should keep acks etc. between
> versions (unless you're making significant enough changes that you think
> would invalidate a prior ack). Having acks makes it easier to track what
> still needs to be reviewed and what is good to go, and it makes it easier
> to
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
Acked-by: Akhil Goyal
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c | 10 ++
2 files changed, 11 insertions(+), 7 deletions(-)
diff --git a
Replace panic calls with log and return value.
Local functions to this file,
changing from void to int are non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++-
drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/e1000/e1000_ethdev.h | 2 +-
drivers/net/e1000/igb_ethdev.c | 4 +++-
drivers/net/e1000/igb_pf.c | 15
after rebase
v9:
- Add missing file descriptor closing when retruning with error
Arnon Warshavsky (10):
crypto/dpaa: replace rte_panic instances in crypto/dpaa driver
bond: replace rte_panic instances in bonding driver
e1000: replace rte_panic instances in e1000 driver
ixgbe: replace rte_
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/ixgbe/ixgbe_ethdev.c | 6 --
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
drivers/net/ixgbe/ixgbe_pf.c | 15
replace panic calls with log and return value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_kni/rte_kni.c | 18 --
lib/librte_kni/rte_kni_fifo.h | 11 ---
2 files changed, 20 insertions
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
Acked-by: Anatoly Burakov
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 +
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal
replace panic calls with log and return value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +---
lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eventdev
Change some local functions return type from void to int.
This change does not break ABI as the functions are internal.
Panic thrown from threads was not handled in this patch
Signed-off-by: Arnon Warshavsky
Acked-by: Anatoly Burakov
---
lib/librte_eal/bsdapp/eal/eal.c | 71
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_ether/rte_ethdev.c | 42 ++
lib/librte_ether/rte_ethdev.h | 4 +++-
2 files changed, 33 insertions(+), 13 deletions(-)
diff --git a
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
---
devtools/checkpatches.sh | 95
Hi Kevin
> /* Any memory allocation failure in initialization is critical
> because
> >* resources can't be free, so reinitialization is impossible. */
>
> What about this comment? Not sure if it is just stale or if there is
> something else you need to do.
>
This comment was origin
> > - if (cryptodev->data->dev_private == NULL)
> > - rte_panic("Cannot allocate memzone for private "
> > - "device data");
> > + if (cryptodev->data->dev_private == NULL) {
> > + DPAA_SEC_ERR("%s() Canno
> > -void __rte_experimental
> > +int __rte_experimental
> > rte_eth_dev_owner_delete(const uint64_t owner_id)
> > {
> > uint16_t port_id;
> > + int error;
>
> it's inconsistent that this function returns the error code from
> rte_eth_dev_shared_data_prepare() and all these other functi
>
> Similar to 1/11 in that there is some allocate before this and maybe you
> should jump to the release at the end of the function
>
> >
>
Same as I wrote in 1/10 - I want to handle this not in this patchset
On Thu, Apr 26, 2018 at 7:08 PM, Kevin Traynor wrote:
> I think the first line of the commit msg ^^^ should change as it no
> longer prevents but just warns
>
> Actually the return value did not change, only the warning text did.
I would rather keep the word 'prevents' as an intention declaration
Hi Kevin
> > + if (rte_config_init() != 0)
> > + return -1;
> > +
>
> I'm confused, is this deliberate? there is now two rte_config_init()
> calls.
Please note that there are 2 eal.c files. One under linux and one under bsd
There is a copy of rte_config_init() in each.
> Aaron'
On Fri, Apr 27, 2018 at 1:08 AM, Arnon Warshavsky wrote:
> Hi Kevin
>
>> > + if (rte_config_init() != 0)
>> > + return -1;
>> > +
>>
>> I'm confused, is this deliberate? there is now two rte_config_init()
>> calls.
>
&g
On Fri, Apr 27, 2018, 17:22 Thomas Monjalon wrote:
> 26/04/2018 08:20, Arnon Warshavsky:
> > The purpose of this patch series is to cleanup the library code
> > from paths that end up aborting the process,
> > and move to checking error values, in order to allow the runnin
On Fri, Apr 27, 2018, 19:40 Thomas Monjalon wrote:
> 27/04/2018 18:31, Arnon Warshavsky:
> > On Fri, Apr 27, 2018, 17:22 Thomas Monjalon wrote:
> > > What is the status of this patchset?
> > > It seems not ready for RC1 (today).
> > > I don't want to p
So will it fail checkpatch in patchwork? I agree with Aaron and Anatoly
> that patches with rte_panic/exit should flag some warning message, but
> the maintainer should have final say. I don't think failing checkpatch
> is the solution for that.
>
Ok. will leave that to the maintainers and change t
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
Reviewed-by: Stephen Hemminger
I get some warning when running this on Ubuntu 18.04.
>
> marchand@gribouille:~/git/dpdk$ ./devtools/checkpatches.sh
> sanity/0001-mbuf-add-sanity-checks-on-segment-metadata.patch
> ./devtools/checkpatches.sh: 52: read: Illegal option -d
>
> Hi,
A patch that fixes that was already sent a few days
> HI
> >
> > Let's use single quotes instead of variable.
> >
> >
> > Using the script directly with single quotes loses the ability to reuse
> it
> > with an additional set of folders , expressions and RET_ON_FAIL.
>
> I don't know awk. Please could you explain what we are loosing and why?
>
The a
> > I was under the wrong impression the opposite was desired, so yes,
> > moving the entire awk code to a separate file would indeed be the
> cleanest.
>
> OK, who can do this change please?
>
>
> I will do the move to a different file later on this week
thanks
/Arnon
The awk code previously read inline in checkpatches.pl
was using -d which is a bash option,
while bash is not the default shell in all distributions.
Now moved to be read from a separate file.
Signed-off-by: Arnon Warshavsky
---
devtools/check-forbidden-tokens.awk | 68
On Fri, Sep 21, 2018 at 2:37 PM, Andrzej Ostruszka wrote:
> Acked-by: Andrzej Ostruszka
>
> However you might consider keeping this comment in the awk script.
>
> On 20.09.2018 23:11, Arnon Warshavsky wrote:
> [...]
> > @@ -44,
The awk code previously read inline in checkpatches.pl
was using -d which is a bash option,
while bash is not the default shell in all distributions.
Now moved to be read from a separate file.
Signed-off-by: Arnon Warshavsky
---
v2 - place original comment in the awk file
devtools/check
The awk code previously read inline in checkpatches.pl
was using -d which is a bash option,
while bash is not the default shell in all distributions.
Now moved to be read from a separate file.
Signed-off-by: Arnon Warshavsky
Acked-by: Andrzej Ostruszka
---
v2 - place original comment in the
This is consuming stdin.
> I guess the checkpatch.pl will have nothing to check in the next step.
> We should merge Neil's patch first, because he is adding a tmpfile
> to solve the issue of stdin read only once.
>
Yup. Missed the fact stdin is consumed. temp file is a good idea
>
> > +
- A new function was added to devtools/checkpatches.sh
in order to prevent new additions of calls to rte_panic
under lib and drivers.
Keep calm and don't panic.
Arnon Warshavsky (13):
crypto: replace rte_panic instances in crypto driver
bond: replace rte_panic instances in bonding d
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
b/drivers/crypto/dpaa2_sec
replace panic calls with log and retrun value.
Local functions to this file,
changing from void to int are non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 30 +++
drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2
replace panic calls with log and retrun value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/e1000/e1000_ethdev.h | 2 +-
drivers/net/e1000/igb_ethdev.c | 3 ++-
drivers/net/e1000/igb_pf.c | 15
replace panic calls with log and retrun value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_kni/rte_kni.c | 18 --
lib/librte_kni/rte_kni_fifo.h | 11 ---
2 files changed, 20 insertions
replace panic calls with log and retrun value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/common/rte_malloc.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/rte_malloc.c
b/lib/librte_eal/common/rte_malloc.c
index e0e0d0b..34d438a 100644
replace panic calls with log and retrun value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
drivers/net/ixgbe/ixgbe_pf.c | 13
replace panic calls with log and retrun value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +---
lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eventdev
replace panic calls with log and retrun value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
b/lib/librte_eal
replace panic calls with log and retrun value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/common/eal_common_memzone.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_memzone.c
b/lib/librte_eal/common/eal_common_memzone.c
index
replace panic calls with log and retrun value.
Thread function removes the noretrun attribute.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 27 ---
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/lib/librte_eal
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_ether/rte_ethdev.c | 36 +---
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
---
devtools/checkpatches.sh | 94
-off-by: Arnon Warshavsky
---
lib/librte_eal/bsdapp/eal/eal.c | 87 ++---
lib/librte_eal/bsdapp/eal/eal_thread.c| 65 +++-
lib/librte_eal/common/eal_common_launch.c | 21 ++
lib/librte_eal/common/include/rte_debug.h | 12 +++
lib/librte_eal
Cool.I assumed worst than needed when the checkpatches lady was not
satisfied.
Will fix that.
On Wed, Apr 4, 2018 at 4:10 PM, Bruce Richardson wrote:
> On Wed, Apr 04, 2018 at 02:27:25PM +0300, Arnon Warshavsky wrote:
> > Signed-off-by: Arnon Warshavsky
> > ---
> > dri
Thanks. Will update the doxigen
On Wed, Apr 4, 2018 at 3:34 PM, Thomas Monjalon wrote:
> 04/04/2018 14:09, Burakov, Anatoly:
> > On 04-Apr-18 12:27 PM, Arnon Warshavsky wrote:
> > > replace panic calls with log and retrun value.
> > >
> > > Signed-off-by: Arn
de to doxigen of rte_memzone_free()
Arnon Warshavsky (13):
crypto: replace rte_panic instances in crypto driver
bond: replace rte_panic instances in bonding driver
e1000: replace rte_panic instances in e1000 driver
ixgbe: replace rte_panic instances in ixgbe driver
eal: replace rte_
replace panic calls with log and return value.
--
v2:
- update doxigen to include new error value
- reformat error message to include literal string in a single line
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/common/eal_common_memzone.c | 3 ++-
lib/librte_eal/common/include
replace panic calls with log and return value.
--
v2:
- reformat error message to include literal string in a single line
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +---
2 files changed, 10
Hi Arnon,
>
> When sending new versions, the entire patchset must be sent. It makes it
> easier for maintainers to apply patches this way.
>
> Thanks Anatoly
Will do
de to doxigen of rte_memzone_free()
v3:
- submit all 13 patches changed and unchanged in the same patchset
Arnon Warshavsky (13):
crypto: replace rte_panic instances in crypto driver
bond: replace rte_panic instances in bonding driver
e1000: replace rte_panic instances in e1000 driver
replace panic calls with log and retrun value.
Local functions to this file,
changing from void to int are non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 30 +++
drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2
replace panic calls with log and retrun value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/e1000/e1000_ethdev.h | 2 +-
drivers/net/e1000/igb_ethdev.c | 3 ++-
drivers/net/e1000/igb_pf.c | 15
replace panic calls with log and return value.
--
v2:
- reformat error message to include literal string in a single line
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +---
drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +---
2 files changed, 10
replace panic calls with log and retrun value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 ++-
drivers/net/ixgbe/ixgbe_ethdev.h | 2 +-
drivers/net/ixgbe/ixgbe_pf.c | 13
replace panic calls with log and retrun value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +---
lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +---
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eventdev
replace panic calls with log and retrun value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/common/rte_malloc.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/rte_malloc.c
b/lib/librte_eal/common/rte_malloc.c
index e0e0d0b..34d438a 100644
replace panic calls with log and retrun value.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c
b/lib/librte_eal
replace panic calls with log and retrun value.
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_kni/rte_kni.c | 18 --
lib/librte_kni/rte_kni_fifo.h | 11 ---
2 files changed, 20 insertions
replace panic calls with log and return value.
--
v2:
- update doxigen to include new error value
- reformat error message to include literal string in a single line
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/common/eal_common_memzone.c | 3 ++-
lib/librte_eal/common/include
This patch adds a new function that is called
per every checked patch,
and alerts for new instances of rte_panic/rte_exit.
The check excludes comments, and alerts in the case
of a positive balance between additions and removals.
Signed-off-by: Arnon Warshavsky
---
devtools/checkpatches.sh | 94
replace panic calls with log and retrun value.
Thread function removes the noretrun attribute.
Signed-off-by: Arnon Warshavsky
---
lib/librte_eal/linuxapp/eal/eal_interrupts.c | 27 ---
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/lib/librte_eal
Local function to this file,
changing from void to int is non-abi-breaking
Signed-off-by: Arnon Warshavsky
---
lib/librte_ether/rte_ethdev.c | 36 +---
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.c b/lib
-off-by: Arnon Warshavsky
---
lib/librte_eal/bsdapp/eal/eal.c | 87 ++---
lib/librte_eal/bsdapp/eal/eal_thread.c| 65 +++-
lib/librte_eal/common/eal_common_launch.c | 21 ++
lib/librte_eal/common/include/rte_debug.h | 12 +++
lib/librte_eal
This patchset needs to be rebased. There were a few changes that make some
of the patches unnecessary.
> Changes in patch 7 and 9 were addressed in earlier memory hotplug
> patchset, and are no longer applicable. Some things may have changed for
> patch 12 as well
Thanks Anatoly
Will do
This function is only called from locations that return a -errno code, not
just
> -1.
>
> Neil
Hi Neil
Looking up the references I see that some of the places looking at this
return value from the probe function
simply return their own -1 , and some return different enums relevant for
their cont
Thanks Anatoly
Will do
On Mon, Apr 16, 2018 at 2:30 PM, Burakov, Anatoly wrote:
> On 13-Apr-18 7:30 PM, Arnon Warshavsky wrote:
>
>> replace panic calls with log and retrun value.
>>
>> Signed-off-by: Arnon Warshavsky
>> ---
>> lib/librte_eal/l
org> wrote:
> On Fri, 13 Apr 2018 21:30:34 +0300
> Arnon Warshavsky wrote:
>
> > + if (*vfinfo == NULL) {
> > + RTE_LOG(CRIT, PMD, "%s(): Cannot allocate memory for
> private "
> > + "VF data\n", __func_
be submitted in order to prevent new additions of calls to rte_panic
under lib and drivers.
Keep calm and don't panic.
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
drivers/crypto/dpaa_sec/dpaa_sec.c| 2 +-
drivers/net/bo
/checkpatches.sh
will be submitted in order to prevent new additions of calls to rte_panic
under lib and drivers.
Keep calm and don't panic.
---
V2: Fix typos in commit message
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +-
drivers/crypto/dpaa_sec/dpaa_
/checkpatches.sh
will be submitted in order to prevent new additions of calls to rte_panic
under lib and drivers.
Keep calm and don't panic.
---
V2: Fix typos in commit message
---
V3: More commit message formatting
Signed-off-by: Arnon Warshavsky
---
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> Thanks for working on this important topic.
> With pleasure :)
>
...
> My feeling is that we could replace most of them by a log + return.
> I did not think you would add a new macro. Why you chose this way?
> This was meant to keep the code shorter, and imply to the reader that this
> return i
>
> You are talking about API, and I agree the old applications can keep
> considering the functions as void.
> But I was talking about ABI, meaning: can we use an old application
> without recompiling and update only the DPDK (in .so file)?
>
>
> You are right of course. Once again I mixed the two
I don't know what needs to be modified.
> I think the first step is to clearly identified the different kind
> of changes by splitting your patch.
> Then we will decide how to integrate them.
>
>
> Ok.Will split the commit with no abi handling and continue from there
I'm a fan of such 1:1 baby steps, but I guess I will stick with the flavor
of majority here.
Will shift those to explicit log and return.
On Wed, Mar 21, 2018 at 11:11 AM, Bruce Richardson <
bruce.richard...@intel.com> wrote:
> On Tue, Mar 20, 2018 at 11:53:08PM +0200, Arnon Wa
I now have a set of several patches which pass the abi-validation , 1 patch
of checkpatches.sh to prevent future panic instances
and the set of abi-breaking changes which are included the init sequence.
1.
I assume it is best to bundle all to a single patchset. Please correct me
otherwise
2.
Tryi
.
This patch defines a couple of callback registration functions,
one for panic and one for exit
in case one wishes to distinguish between these events.
Once a callback is set and panic takes place,
it will be called prior to calling abort.
Maiden voyage patch for Qwilt and myself.
Signed-off-by: Arnon
>
>
> Are you OK to visit the other side of the solution?
>
>
Sure. If no one is emotionally attached to those panic aborts,
this patch can be discarded and I will create a new one with the license to
break.
> > Can this really go into current release without deprecation notices?
>
> If such an exception is done, it must be approved by the technical board.
> We need to check few criterias:
> - which functions need to be changed
> - how the application is impacted
> - what is the
>
> Can we add a compile warning for adding new rte_panic's into code? It's a
> nice tool while debugging, but it probably shouldn't be in any new
> production code.
>
I thought about renaming the current function and calls to something like
deprecated_rte_panic()
, and keep the old API with __rte
> > maybe we should keep the callback patch until all the remains are gone.
>
> Why introducing a new API for a temporary solution?
> It has always been like that, so the remaining occurences could wait
> one more release, isn't it?
>
> Yes.
I guess I am over excited to get rid of my local changes
> > Can we add a compile warning for adding new rte_panic's into code? It's
a
> > > nice tool while debugging, but it probably shouldn't be in any new
> > > production code.
>
> Yes could be nice to automatically detect it in drivers/ or lib/
> directories.
>
How do we apply a warning only to new
Hi Swamy
A somewhat similar degradation (though not with l2fwd) was experienced by
us as described here
http://dev.dpdk.narkive.com/OL0KiHns/dpdk-dev-missing-prefetch-in-non-vector-rx-function
In our case it surfaced for not using the default configuration and working
in non-vector mode, and it b
until I blindly run the reset command.
>
> Did anybody else try it on a black background? Did anybody else see these
> issues with it as well?
>
> Matthew.
>
--
*Arnon Warshavsky*
*Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon at qwilt.com
*
minal type used, versions, ?
>
>
> Thanks
> ++Keith
> >
> >If you quit the app it does not reset the colors so my shell is also
> >invisible, until I blindly run the reset command.
> >
> >Did anybody else try it on a black background? Did anybody else see
> >these issues with it as well?
> >
> >Matthew.
> >
>
>
> Regards,
> Keith
>
>
>
>
>
--
*Arnon Warshavsky*
*Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon at qwilt.com
*
; From: Arnon Warshavsky mailto:arnon at qwilt.com>>
> Date: Thursday, January 21, 2016 at 9:04 AM
> To: "Keith Wiles (Intel)" keith.wiles at intel.com>>
> Cc: Matthew Hall mailto:mhall at mhcomputing.net>>,
> "
> dev at dpdk.org<mailto:dev at dpdk.o
On Wed, Jun 15, 2016 at 4:03 PM, Dumitrescu, Cristian <
cristian.dumitrescu at intel.com> wrote:
>
>
> > -Original Message-
> > From: Yerden Zhumabekov [mailto:e_zhumabekov at sts.kz]
> > Sent: Wednesday, June 15, 2016 1:55 PM
> > To: Dumitrescu, Cristian ; Panu
> Matilainen
> > ; dev at d
nding from the API manual is that the rte_eth_stats q_errors
> array should count the packets missed because software isn't polling fast
> enough, but that doesn't seem to be the case? Is there a standard DPDK way
> to check this? The application is a forwarding one so there&#
101 - 200 of 230 matches
Mail list logo
