Hi Kevin
> /* Any memory allocation failure in initialization is critical
> because
> > * resources can't be free, so reinitialization is impossible. */
>
> What about this comment? Not sure if it is just stale or if there is
> something else you need to do.
>
This comment was originally in the code to explain why is a panic being
thrown.
By returning from this function in this patch I also aim to terminate the
process, but through the door rather than out the window,
so It still makes sense there
>
> > * @return
> > * 0 on success, negative value otherwise.
>
> ^^^ you inadvertently fixed a doxygen bug :-)
> I consider this doxygen tightly coupled with the code in this change so I
> will not charge twice here :)
>
>
> > + if (rc == internals->active_slave_count) {
> > + int rc = activate_slave(bonded_eth_dev,
> > + slave_port_id);
> > + if (rc != 0)
> > + return -1;
> > + }
>
> Not functionally wrong, but commented about no need for variables here
> in v4 and seems to have been missed
>
Indeed missed that one. Will fix
Thanks
/Arnon
