Thanks Stephen
I thought I handled all the split strings. Apparently checkpatches
overlooked it.
Will do a rescan on the entire patchset and fix those in v4.
Missed the separate log macro. Will change that as well
On Mon, Apr 16, 2018 at 6:34 PM, Stephen Hemminger <
step...@networkplumber.org> wrote:
> On Fri, 13 Apr 2018 21:30:34 +0300
> Arnon Warshavsky <ar...@qwilt.com> wrote:
>
> > + if (*vfinfo == NULL) {
> > + RTE_LOG(CRIT, PMD, "%s(): Cannot allocate memory for
> private "
> > + "VF data\n", __func__);
> > + return -1;
> > + }
> >
> Don't split strings across lines. Checkpatch should complain about that.
> It makes searching for error messages in source harder.
>
> Instead do:
> if (!*vfinfo) {
> RTE_LOG(CRIT, PMD,
> "%s(): Cannot allocate memory for private VF
> data\n",
> __func__);
> return -1;
> }
>
> Also why not use PMD_DRV_LOG() macro.
>
--
*Arnon Warshavsky*
*Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | ar...@qwilt.com
<ar...@qwilt.com>*
