[dpdk-dev] [v3] crypto/cnxk: add telemetry endpoints to cryptodev

2021-09-29 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to cryptodev. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: patch-19252 ("cryptodev: add telemetry endpoint for cryptodev info") Depends-on: series-19253 ("cnxk: enable telemetry endpoints") v3: - common info moved to lib/cryptodev endpoint. --- .../crypto/c

Re: [dpdk-dev] [PATCH v2] examples/vhost: fix use-after-free on drain vhost

2021-09-29 Thread Xia, Chenbo
> -Original Message- > From: Ma, WenwuX > Sent: Saturday, September 25, 2021 1:23 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Jiang, > Cheng1 ; Hu, Jiayu ; Yang, YvonneX > ; Ma, WenwuX ; sta...@dpdk.org > Subject: [PATCH v2] examples/vhost: fix use-after-free on d

Re: [dpdk-dev] [PATCH v2 5/5] app/testpmd: add missing flow types in port info

2021-09-29 Thread Maxime Coquelin
On 9/22/21 13:31, Li, Xiaoyun wrote: Hi -Original Message- From: Maxime Coquelin Sent: Wednesday, September 22, 2021 17:58 To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; david.march...@redhat.com; andrew.rybche...@oktetlabs.ru; Yigit, Ferruh ; michae...@nvidia.com; viachesl...

Re: [dpdk-dev] [PATCH v5 1/2] eventdev: add rx queue conf get api

2021-09-29 Thread Jerin Jacob
On Tue, Sep 28, 2021 at 3:04 PM Jayatheerthan, Jay wrote: > > > -Original Message- > > From: Kundapura, Ganapati > > Sent: Thursday, September 16, 2021 6:21 PM > > To: Jayatheerthan, Jay ; jerinjac...@gmail.com > > Cc: dev@dpdk.org; Yigit, Ferruh > > Subject: [PATCH v5 1/2] eventdev: add

Re: [dpdk-dev] [PATCH v2 0/7] Removal of PCI bus ABIs

2021-09-29 Thread Xia, Chenbo
Gentle ping for comments.. @David, could you help me understand what is the compile error in Fedora 31? DPDK_compile_spdk failure is expected as the header name for SPDK is changed, I am not sure if it's the same error... Thanks, Chenbo > -Original Message- > From: dev On Behalf Of Chen

[dpdk-dev] [PATCH] mbuf: remove deprecated bad outer IPv4 checksum flag on Rx

2021-09-29 Thread Andrew Rybchenko
Removed offload flag PKT_RX_EIP_CKSUM_BAD. PKT_RX_OUTER_IP_CKSUM_BAD should be used as a replacement. Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst | 7 +-- doc/guides/rel_notes/release_21_11.rst | 3 +++ lib/mbuf/rte_mbuf_core.h | 7 --- 3 file

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-29 Thread Xueming(Steven) Li
On Tue, 2021-09-28 at 20:29 +0530, Jerin Jacob wrote: > On Tue, Sep 28, 2021 at 8:10 PM Xueming(Steven) Li > wrote: > > > > On Tue, 2021-09-28 at 13:59 +, Ananyev, Konstantin wrote: > > > > > > > > On Tue, Sep 28, 2021 at 6:55 PM Xueming(Steven) Li > > > > wrote: > > > > > > > > > > On Tu

Re: [dpdk-dev] [EXT] [PATCH] cryptodev: add telemetry callbacks

2021-09-29 Thread Bruce Richardson
On Wed, Sep 29, 2021 at 05:14:38AM +, Gowrishankar Muthukrishnan wrote: > > An example usage can be seen below: > > > > Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 > > {"version": "DPDK 21.11.0-rc0", "pid": 1135019, "max_output_len": 16384} > > --> / > > {"/": ["/", "/cryptodev/list", "/

Re: [dpdk-dev] [PATCH v4] efd: change data type of parameter

2021-09-29 Thread De Lara Guarch, Pablo
Hi > -Original Message- > From: David Christensen > Sent: Tuesday, September 28, 2021 4:53 PM > To: De Lara Guarch, Pablo ; Wang, Yipeng1 > ; Marohn, Byron > Cc: dev@dpdk.org; Mcnamara, John > Subject: Re: [PATCH v4] efd: change data type of parameter > > > > On 9/28/21 6:58 AM, Pabl

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-09-29 Thread Ali Alnubani
Hi Olivier, I wanted to retest the patch on latest main, but it no longer applies, could you please rebase it? Thanks, Ali > -Original Message- > From: Morten Brørup > Sent: Tuesday, September 28, 2021 12:40 PM > To: Slava Ovsiienko ; NBU-Contact-Thomas > Monjalon ; Olivier Matz ; > Al

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-29 Thread Jerin Jacob
On Wed, Sep 29, 2021 at 1:11 PM Xueming(Steven) Li wrote: > > On Tue, 2021-09-28 at 20:29 +0530, Jerin Jacob wrote: > > On Tue, Sep 28, 2021 at 8:10 PM Xueming(Steven) Li > > wrote: > > > > > > On Tue, 2021-09-28 at 13:59 +, Ananyev, Konstantin wrote: > > > > > > > > > > On Tue, Sep 28, 2021

Re: [dpdk-dev] [PATCH] ethdev: remove legacy mirroring API

2021-09-29 Thread Thomas Monjalon
Hi Andrew, Thanks a lot for working on this. I had sent the deprecation notice and forgot about it, apologies. 28/09/2021 18:16, Andrew Rybchenko: > A more file grain flow API should be used instead of it. Do you mean "fine-grain"? I think we can reference the rte_flow action to be used:

Re: [dpdk-dev] [PATCH v4 06/13] net/bnxt: add support for tunnel offload API

2021-09-29 Thread Thomas Monjalon
28/09/2021 23:32, Ajit Khaparde: > On Tue, Sep 28, 2021 at 5:43 AM Ferruh Yigit wrote: > > Following warning is reported by Jerin & Thomas: > > > > $ ./devtools/check-doc-vs-code.sh > > rte_flow doc out of sync for bnxt > > action shared > > > > > > This is mainly saying 'RTE_FLOW_ACTION_T

[dpdk-dev] [PATCH v2] ethdev: remove legacy mirroring API

2021-09-29 Thread Andrew Rybchenko
A more fine-grain flow API action RTE_FLOW_ACTION_TYPE_SAMPLE should be used instead of it. Signed-off-by: Andrew Rybchenko --- v2: - fix description - mention RTE_FLOW_ACTION_TYPE_SAMPLE in the descriptor and release notes - fix net/txgbe broken build app/test-pmd/cmdline.c

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-29 Thread Xueming(Steven) Li
On Wed, 2021-09-29 at 00:26 +, Ananyev, Konstantin wrote: > > > > > > > > > > > > > > > In current DPDK framework, each RX queue > > > > > > > > > > > > > > > is > > > > > > > > > > > > > > > pre-loaded with mbufs > > > > > > > > > > > > > > > for incoming packets. When number of > > > > > > >

Re: [dpdk-dev] [PATCH] ethdev: remove legacy mirroring API

2021-09-29 Thread Andrew Rybchenko
Hi Thomas, On 9/29/21 11:17 AM, Thomas Monjalon wrote: > Hi Andrew, > Thanks a lot for working on this. > I had sent the deprecation notice and forgot about it, apologies. No worries. I always liked to delete some code. I think it is my favorite in programming :-) > > 28/09/2021 18:16, Andrew R

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 2/2] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-09-29 Thread Ferruh Yigit
On 9/28/2021 5:53 PM, Andrew Rybchenko wrote: > On 9/28/21 7:50 PM, Ferruh Yigit wrote: >> On 9/28/2021 1:05 PM, Andrew Rybchenko wrote: >>> From: Ivan Ilchenko >>> >>> Update xstats by IDs callbacks documentation in accordance with >>> ethdev usage of these callbacks. Document valid combinations

Re: [dpdk-dev] [PATCH v2] telemetry: fix "in-memory" process socket conflicts

2021-09-29 Thread Power, Ciara
Hi Bruce, >-Original Message- >From: Richardson, Bruce >Sent: Friday 24 September 2021 17:19 >To: dev@dpdk.org >Cc: Power, Ciara ; Burakov, Anatoly >; Richardson, Bruce >; sta...@dpdk.org; David Marchand > >Subject: [PATCH v2] telemetry: fix "in-memory" process socket conflicts > >When DP

[dpdk-dev] [v4] crypto/cnxk: add telemetry endpoints to cryptodev

2021-09-29 Thread Gowrishankar Muthukrishnan
Add telemetry endpoints to cryptodev. Signed-off-by: Gowrishankar Muthukrishnan --- Depends-on: patch-19252 ("cryptodev: add telemetry endpoint for cryptodev info") Depends-on: series-19253 ("cnxk: enable telemetry endpoints") v4: - fix compilation issue. --- .../crypto/cnxk/cnxk_cryptodev_tel

Re: [dpdk-dev] [PATCH v2] ethdev: remove legacy mirroring API

2021-09-29 Thread Thomas Monjalon
29/09/2021 10:39, Andrew Rybchenko: > A more fine-grain flow API action RTE_FLOW_ACTION_TYPE_SAMPLE should > be used instead of it. > > Signed-off-by: Andrew Rybchenko > --- > v2: > - fix description > - mention RTE_FLOW_ACTION_TYPE_SAMPLE in the descriptor and > release notes >

Re: [dpdk-dev] [PATCH v2 1/5] net/virtio: add initial RSS support

2021-09-29 Thread Maxime Coquelin
On 9/23/21 09:35, Xia, Chenbo wrote: Hi Maxime, -Original Message- From: Maxime Coquelin Sent: Wednesday, September 22, 2021 5:58 PM To: dev@dpdk.org; Xia, Chenbo ; amore...@redhat.com; david.march...@redhat.com; andrew.rybche...@oktetlabs.ru; Yigit, Ferruh ; michae...@nvidia.com; v

[dpdk-dev] [PATCH v2 0/3] add SA config option for inner pkt csum

2021-09-29 Thread Archana Muniganti
Add inner packet IPv4 hdr and L4 checksum enable options in conf. These will be used in case of protocol offload. Per SA, application could specify whether the checksum(compute/verify) can be offloaded to security device. Depends on https://patches.dpdk.org/project/dpdk/list/?series=19243 Changes

[dpdk-dev] [PATCH v2 1/3] security: add SA config option for inner pkt csum

2021-09-29 Thread Archana Muniganti
Add inner packet IPv4 hdr and L4 checksum enable options in conf. These will be used in case of protocol offload. Per SA, application could specify whether the checksum(compute/verify) can be offloaded to security device. Signed-off-by: Archana Muniganti --- doc/guides/cryptodevs/features/defaul

[dpdk-dev] [PATCH v2 2/3] crypto/cnxk: add inner checksum

2021-09-29 Thread Archana Muniganti
Add inner checksum support for cn10k. Signed-off-by: Archana Muniganti --- doc/guides/cryptodevs/features/cn10k.ini | 1 + doc/guides/rel_notes/release_21_11.rst| 1 + drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 65 +++ drivers/crypto/cnxk/cn10k_ipsec.c

[dpdk-dev] [PATCH v2 3/3] test/crypto: add inner checksum cases

2021-09-29 Thread Archana Muniganti
This patch adds tests for inner IP and inner L4 checksum in IPsec mode. Signed-off-by: Archana Muniganti --- app/test/test_cryptodev.c | 34 +++ app/test/test_cryptodev_security_ipsec.c | 195 ++ app/test/test_cryptodev_security_ipsec.h | 2 + ...

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-29 Thread Xueming(Steven) Li
On Wed, 2021-09-29 at 00:26 +, Ananyev, Konstantin wrote: > > > > > > > > > > > > > > > In current DPDK framework, each RX queue > > > > > > > > > > > > > > > is > > > > > > > > > > > > > > > pre-loaded with mbufs > > > > > > > > > > > > > > > for incoming packets. When number of > > > > > > >

[dpdk-dev] [PATCH v3 0/5] Virtio PMD RSS support & RSS fixes

2021-09-29 Thread Maxime Coquelin
This series is mainly adding support for RSS to Virtio PMD driver. The two last patches are fixing an issue in testpmd that could cause out of bounds access, and fix an issue spotted in the mlx5 driver while looking for inspiration. The first motivation for this series is to eventually support RSS

[dpdk-dev] [PATCH v3 1/5] net/virtio: add initial RSS support

2021-09-29 Thread Maxime Coquelin
Provide the capability to update the hash key, hash types and RETA table on the fly (without needing to stop/start the device). However, the key length and the number of RETA entries are fixed to 40B and 128 entries respectively. This is done in order to simplify the design, but may be revisited la

[dpdk-dev] [PATCH v3 2/5] app/testpmd: fix RSS key length

2021-09-29 Thread Maxime Coquelin
port_rss_hash_key_update() initializes rss_conf with the RSS key configuration provided by the user, but it calls rte_eth_dev_rss_hash_conf_get() before calling rte_eth_dev_rss_hash_update(), which overrides the parsed RSS config. While the RSS key value is set again after, this is not the case o

[dpdk-dev] [PATCH v3 3/5] app/testpmd: fix RSS type display

2021-09-29 Thread Maxime Coquelin
This patch fixes the display of the RSS hash types configured in the port, which displayed "all" even if only a single type was configured Fixes: 3c90743dd3b9 ("app/testpmd: support more types for flow RSS") Cc: sta...@dpdk.org Signed-off-by: Maxime Coquelin Acked-by: Xiaoyun Li Reviewed-by: Ch

[dpdk-dev] [PATCH v3 4/5] net/mlx5: fix RSS RETA update

2021-09-29 Thread Maxime Coquelin
This patch fixes RETA updating for entries above 64. Without ithat, these entries are never updated as calculated mask value will always be 0. Fixes: 634efbc2c8c0 ("mlx5: support RETA query and update") Cc: sta...@dpdk.org Cc: nelio.laranje...@6wind.com Signed-off-by: Maxime Coquelin Acked-by: V

[dpdk-dev] [PATCH v3 5/5] app/testpmd: add missing flow types in port info

2021-09-29 Thread Maxime Coquelin
This patch adds missing IPv6-Ex and GPTU flow types to port info command. It also add the same definitions to str2flowtype(), used to configure flow director. Signed-off-by: Maxime Coquelin --- app/test-pmd/cmdline.c | 4 app/test-pmd/config.c | 4 2 files changed, 8 insertions(+) di

Re: [dpdk-dev] [PATCH] net/bnxt: fix tunnel port accounting

2021-09-29 Thread Ajit Khaparde
On Mon, Sep 27, 2021 at 3:48 PM Ajit Khaparde wrote: > > Fix the tunnel port counting logic. > Currently we are incrementing the port count without checking > the if bnxt_hwrm_tunnel_dst_port_alloc would return success or failure. > Modify the logic to increment it only if the firmware returns suc

Re: [dpdk-dev] cannot use virtio-user pmd in IOVA=PA mode anymore

2021-09-29 Thread Maxime Coquelin
Hi Olivier, On 9/24/21 10:21, Olivier Matz wrote: Hello, I recently tested a use-case with our application using the main branch of dpdk.org. - the application runs inside a standard x86 VM (no IOMMU) - there are emulated physical NICs inside the VM - we use virtio-user pmds connected to tap i

Re: [dpdk-dev] [PATCH v6 2/2] vhost: enable IOMMU for async vhost

2021-09-29 Thread Burakov, Anatoly
On 29-Sep-21 7:12 AM, Hu, Jiayu wrote: Hi Xuan, -Original Message- From: Ding, Xuan Sent: Wednesday, September 29, 2021 10:41 AM To: dev@dpdk.org; Burakov, Anatoly ; maxime.coque...@redhat.com; Xia, Chenbo Cc: Hu, Jiayu ; Jiang, Cheng1 ; Richardson, Bruce ; Pai G, Sunil ; Wang, Yinan

Re: [dpdk-dev] [PATCH v4 06/13] net/bnxt: add support for tunnel offload API

2021-09-29 Thread Ferruh Yigit
On 9/29/2021 9:20 AM, Thomas Monjalon wrote: > 28/09/2021 23:32, Ajit Khaparde: >> On Tue, Sep 28, 2021 at 5:43 AM Ferruh Yigit wrote: >>> Following warning is reported by Jerin & Thomas: >>> >>> $ ./devtools/check-doc-vs-code.sh >>> rte_flow doc out of sync for bnxt >>> action shared >>>

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-29 Thread Ananyev, Konstantin
> -Original Message- > From: Xueming(Steven) Li > Sent: Wednesday, September 29, 2021 10:13 AM > To: jerinjac...@gmail.com; Ananyev, Konstantin > Cc: NBU-Contact-Thomas Monjalon ; > andrew.rybche...@oktetlabs.ru; dev@dpdk.org; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH v1] ethde

[dpdk-dev] [PATCH] doc/guides: update dev list with Marvell crypto PMDs

2021-09-29 Thread Anoob Joseph
Update list with following PMDs, - crypto_cn9k - crypto_cn10k - crypto_octeontx - crypto_octeontx2 Also made the list alphabetical. Signed-off-by: Anoob Joseph --- doc/guides/tools/cryptoperf.rst | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/doc/guide

Re: [dpdk-dev] [PATCH v2] net/af_packet: fix ignoring full ring on tx

2021-09-29 Thread Tudor Cornea
Hi Ferruh, What you described above looks like a ring buffer with single producer and > single consumer, and producer overwrites the not consumed items. Indeed. This is also my understanding of the bug. I am going to try to isolate the issue, and should probably be able to come up with a script

Re: [dpdk-dev] [PATCH v1 1/1] vfio: add page-by-page mapping API

2021-09-29 Thread Burakov, Anatoly
On 10-Sep-21 12:27 PM, Anatoly Burakov wrote: Currently, there is no way to map memory for DMA in a way that allows unmapping it partially later, because some IOMMU's do not support partial unmapping. There is a workaround of mapping all of these segments separately, but this is inconvenient and

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-29 Thread Ananyev, Konstantin
> > > > > > > > > > > > > > > > In current DPDK framework, each RX queue > > > > > > > > > > > > > > > > is > > > > > > > > > > > > > > > > pre-loaded with mbufs > > > > > > > > > > > > > > > > for incoming packets. When number of > > > > > > > > > > > > > > > > representors scale out in a > > > >

Re: [dpdk-dev] [PATCH v3 4/8] examples/ioat: add cmd line option to control stats print interval

2021-09-29 Thread Conor Walsh
On 28/09/2021 17:29, Kevin Laatz wrote: Add a command line option to control the interval between stats prints. Signed-off-by: Kevin Laatz --- Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v3 5/8] examples/ioat: add signal-triggered device dumps

2021-09-29 Thread Conor Walsh
On 28/09/2021 17:29, Kevin Laatz wrote: Enable dumping device info via the signal handler. With this change, when a SIGUSR1 is issued, the application will print a dump of all devices being used by the application. Signed-off-by: Kevin Laatz --- Reviewed-by: Conor Walsh

Re: [dpdk-dev] [PATCH v2 1/3] security: add SA config option for inner pkt csum

2021-09-29 Thread Ananyev, Konstantin
> Add inner packet IPv4 hdr and L4 checksum enable options > in conf. These will be used in case of protocol offload. > Per SA, application could specify whether the > checksum(compute/verify) can be offloaded to security device. > > Signed-off-by: Archana Muniganti > --- > doc/guides/cryptodevs

Re: [dpdk-dev] [PATCH v2 1/3] security: add SA config option for inner pkt csum

2021-09-29 Thread Anoob Joseph
Hi Konstanin, Please see inline. Thanks, Anoob > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, September 29, 2021 4:26 PM > To: Archana Muniganti ; Akhil Goyal > ; Nicolau, Radu ; Zhang, Roy > Fan ; hemant.agra...@nxp.com > Cc: Anoob Joseph ; Tejasree Kondoj > ; Anku

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-29 Thread Bruce Richardson
On Wed, Sep 29, 2021 at 09:52:20AM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Xueming(Steven) Li > > Sent: Wednesday, September 29, 2021 10:13 AM > > > + /* Locate real source fs according to mbuf->port. */ > > > + for (i = 0; i < nb_rx; ++i) { > > > +

Re: [dpdk-dev] [PATCH v5] ethdev: fix representor port ID search by name

2021-09-29 Thread Singh, Aman Deep
On 9/13/2021 4:56 PM, Andrew Rybchenko wrote: From: Viacheslav Galaktionov Getting a list of representors from a representor does not make sense. Instead, a parent device should be used. To this end, extend the rte_eth_dev_data structure to include the port ID of the backing device for repre

[dpdk-dev] [PATCH v3 0/3] add SA config option for inner pkt csum

2021-09-29 Thread Archana Muniganti
Add inner packet IPv4 hdr and L4 checksum enable options in conf. These will be used in case of protocol offload. Per SA, application could specify whether the checksum(compute/verify) can be offloaded to security device. Depends on https://patches.dpdk.org/project/dpdk/list/?series=19243 Changes

[dpdk-dev] [PATCH v3 1/3] security: add SA config option for inner pkt csum

2021-09-29 Thread Archana Muniganti
Add inner packet IPv4 hdr and L4 checksum enable options in conf. These will be used in case of protocol offload. Per SA, application could specify whether the checksum(compute/verify) can be offloaded to security device. Signed-off-by: Archana Muniganti --- doc/guides/cryptodevs/features/defaul

[dpdk-dev] [PATCH v3 2/3] crypto/cnxk: add inner checksum

2021-09-29 Thread Archana Muniganti
Add inner checksum support for cn10k. Signed-off-by: Archana Muniganti --- doc/guides/cryptodevs/features/cn10k.ini | 1 + doc/guides/rel_notes/release_21_11.rst| 1 + drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 65 +++ drivers/crypto/cnxk/cn10k_ipsec.c

[dpdk-dev] [PATCH v3 3/3] test/crypto: add inner checksum cases

2021-09-29 Thread Archana Muniganti
This patch adds tests for inner IP and inner L4 checksum in IPsec mode. Signed-off-by: Archana Muniganti --- app/test/test_cryptodev.c | 34 +++ app/test/test_cryptodev_security_ipsec.c | 195 ++ app/test/test_cryptodev_security_ipsec.h | 2 + ...

Re: [dpdk-dev] [PATCH v2 1/3] security: add SA config option for inner pkt csum

2021-09-29 Thread Ananyev, Konstantin
Hi Anoob, > Hi Konstanin, > > Please see inline. > > Thanks, > Anoob > > > -Original Message- > > From: Ananyev, Konstantin > > Sent: Wednesday, September 29, 2021 4:26 PM > > To: Archana Muniganti ; Akhil Goyal > > ; Nicolau, Radu ; Zhang, Roy > > Fan ; hemant.agra...@nxp.com > > Cc:

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-29 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, September 29, 2021 12:08 PM > To: Ananyev, Konstantin > Cc: Xueming(Steven) Li ; jerinjac...@gmail.com; > NBU-Contact-Thomas Monjalon ; > andrew.rybche...@oktetlabs.ru; dev@dpdk.org; Yigit, Ferruh > > Subject: Re: [dp

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 2/2] ethdev: fix docs of drivers callbacks getting xstats by IDs

2021-09-29 Thread Andrew Rybchenko
On 9/29/21 11:44 AM, Ferruh Yigit wrote: > On 9/28/2021 5:53 PM, Andrew Rybchenko wrote: >> On 9/28/21 7:50 PM, Ferruh Yigit wrote: >>> On 9/28/2021 1:05 PM, Andrew Rybchenko wrote: From: Ivan Ilchenko Update xstats by IDs callbacks documentation in accordance with ethdev usage

Re: [dpdk-dev] [PATCH] net/mlx5: fix flow tables double release

2021-09-29 Thread Matan Azrad
From: Bing Zhao > In the function mlx5_alloc_shared_dr(), there are various reasons to result in > a failure and error clean up process. While in the caller of mlx5_dev_spawn(), > once there is a error occurring after the mlx5_alloc_shared_dr(), the > mlx5_os_free_shared_dr() is called to releas

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-29 Thread Xueming(Steven) Li
On Wed, 2021-09-29 at 09:52 +, Ananyev, Konstantin wrote: > > > -Original Message- > > From: Xueming(Steven) Li > > Sent: Wednesday, September 29, 2021 10:13 AM > > To: jerinjac...@gmail.com; Ananyev, Konstantin > > > > Cc: NBU-Contact-Thomas Monjalon ; > > andrew.rybche...@oktetla

[dpdk-dev] Questions about vm2vm vhost-user/virtio-net test

2021-09-29 Thread Min Hu (Connor)
Hi, Coquelin, Chenbo, all, I want to seek help about vm2vm vhost-user/virtio-net test from you. When I set up vm2vm vhost-user/virtio-net test, I cannot ping vm2 in vm1. That is, ping failed between vm1 and vm2. Detailed description are as flows: host configuration: Linux

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-29 Thread Bruce Richardson
On Wed, Sep 29, 2021 at 12:46:51PM +0100, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Wednesday, September 29, 2021 12:08 PM > > To: Ananyev, Konstantin > > Cc: Xueming(Steven) Li ; jerinjac...@gmail.com; > > NBU-Contact-Thomas Monjalon ;

Re: [dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support

2021-09-29 Thread Thomas Monjalon
27/09/2021 15:34, Srikanth Kaka: > This patch series adds support for MLX5 PMD on FreeBSD > > drivers/common/mlx5/freebsd/meson.build | 189 ++ > drivers/common/mlx5/freebsd/mlx5_common_os.c | 387 +++ > drivers/common/mlx5/freebsd/mlx5_common_os.h | 304 ++ > .../common/mlx5/freebsd/m

Re: [dpdk-dev] [RFC 3/3] app/testpmd: fix hex string parser in flow commands

2021-09-29 Thread Singh, Aman Deep
Hi Ovsiienko, Can you please provide the flow command which causes "segmentation fault". Thanks Aman

Re: [dpdk-dev] [PATCH v2] telemetry: fix "in-memory" process socket conflicts

2021-09-29 Thread Kevin Traynor
Hi Bruce, On 24/09/2021 17:18, Bruce Richardson wrote: When DPDK is run with --in-memory mode, multiple processes can run simultaneously using the same runtime dir. This leads to each process removing another process' telemetry socket as it started up, giving unexpected behaviour. This patch ch

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-29 Thread Ananyev, Konstantin
> -Original Message- > From: Xueming(Steven) Li > Sent: Wednesday, September 29, 2021 1:09 PM > To: jerinjac...@gmail.com; Ananyev, Konstantin > Cc: NBU-Contact-Thomas Monjalon ; > andrew.rybche...@oktetlabs.ru; dev@dpdk.org; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH v1] ethdev

[dpdk-dev] [PATCH 1/2] net/i40e: fix generic build on FreeBSD

2021-09-29 Thread Leyi Rong
The common header file for vectorization is included in multiple files, and so must use macros for the current compilation unit, rather than the compiler-capability flag set for the whole driver. With the current, incorrect, macro, the AVX512 or AVX2 flags may be set when compiling up SSE code, lea

[dpdk-dev] [PATCH 2/2] net/ice: fix generic build on FreeBSD

2021-09-29 Thread Leyi Rong
The common header file for vectorization is included in multiple files, and so must use macros for the current compilation unit, rather than the compiler-capability flag set for the whole driver. With the current, incorrect, macro, the AVX512 or AVX2 flags may be set when compiling up SSE code, lea

Re: [dpdk-dev] [PATCH 00/27] net/cnxk: support for inline ipsec

2021-09-29 Thread Jerin Jacob
On Thu, Sep 2, 2021 at 7:46 AM Nithin Dabilpuram wrote: > > Support for inline ipsec in CN9K event mode and in Cn10K event mode and > poll mode. > > Depends-on: series-18524 ("Crypto adapter support for Marvell CNXK driver) > Depends-on: series-18262 ("security: Improve inline fast path routines")

Re: [dpdk-dev] [PATCH v2] net/virtio: fix virtio-user init when using existing tap

2021-09-29 Thread Ferruh Yigit
On 9/28/2021 9:51 AM, David Marchand wrote: > When attaching to an existing mono queue tap, the virtio-user was not > reporting that the virtio device was not properly initialised which > prevented from starting the port later. > > $ ip tuntap add test mode tap > $ dpdk-testpmd --vdev \ > net_vi

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-29 Thread Xueming(Steven) Li
On Wed, 2021-09-29 at 10:20 +, Ananyev, Konstantin wrote: > > > > > > > > > > > > > > > > > In current DPDK framework, each RX > > > > > > > > > > > > > > > > > queue > > > > > > > > > > > > > > > > > is > > > > > > > > > > > > > > > > > pre-loaded with mbufs > > > > > > > > > > > > > > > > > f

Re: [dpdk-dev] [PATCH v2] telemetry: fix "in-memory" process socket conflicts

2021-09-29 Thread Bruce Richardson
On Wed, Sep 29, 2021 at 01:28:53PM +0100, Kevin Traynor wrote: > Hi Bruce, > > On 24/09/2021 17:18, Bruce Richardson wrote: > > When DPDK is run with --in-memory mode, multiple processes can run > > simultaneously using the same runtime dir. This leads to each process > > removing another process'

Re: [dpdk-dev] [PATCH v2] telemetry: fix "in-memory" process socket conflicts

2021-09-29 Thread Bruce Richardson
On Wed, Sep 29, 2021 at 02:32:02PM +0100, Bruce Richardson wrote: > On Wed, Sep 29, 2021 at 01:28:53PM +0100, Kevin Traynor wrote: > > Hi Bruce, > > > > On 24/09/2021 17:18, Bruce Richardson wrote: > > > When DPDK is run with --in-memory mode, multiple processes can run > > > simultaneously using

[dpdk-dev] [PATCH v3] telemetry: fix "in-memory" process socket conflicts

2021-09-29 Thread Bruce Richardson
When DPDK is run with --in-memory mode, multiple processes can run simultaneously using the same runtime dir. This leads to each process, as it starts up, removing the telemetry socket of another process, giving unexpected behaviour. This patch changes that behaviour to first check if the existing

Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback

2021-09-29 Thread Xueming(Steven) Li
On Wed, 2021-09-22 at 12:54 +, Xueming(Steven) Li wrote: > On Wed, 2021-09-22 at 11:57 +0100, Ferruh Yigit wrote: > > > > > > > > <...> > > > > > > > > > void > > > > > -i40e_dev_rx_queue_release(void *rxq) > > > > > +i40e_dev_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid) > > > > >

[dpdk-dev] [PATCH v4] net/af_packet: reinsert the stripped vlan tag

2021-09-29 Thread Tudor Cornea
The af_packet pmd driver binds to a raw socket and allows sending and receiving of packets through the kernel. Since commit [1], the kernel strips the vlan tags early in __netif_receive_skb_core(), so we receive untagged packets while running with the af_packet pmd. Luckily for us, the skb vlan-r

Re: [dpdk-dev] [PATCH v3] net/af_packet: reinsert the stripped vlan tag

2021-09-29 Thread Tudor Cornea
Thanks Stephen, for the suggestion I've sent v4 of the patch, which adds the succinct description in the af_packet documentation.. On Fri, 24 Sept 2021 at 18:11, Stephen Hemminger wrote: > On Fri, 24 Sep 2021 14:44:45 +0300 > Tudor Cornea wrote: > > > +Features and Limitations of the af_packe

[dpdk-dev] [PATCH 0/4] net/mlx5: implicit mempool registration

2021-09-29 Thread dkozlyuk
From: Dmitry Kozlyuk MLX5 hardware has its internal IOMMU where PMD registers the memory. On the data path, PMD translates VA into a key consumed by the device IOMMU. It is impractical for the PMD to register all allocated memory because of increased lookup cost both in HW and SW. Most often mb

[dpdk-dev] [PATCH v2 1/4] mempool: add event callbacks

2021-09-29 Thread dkozlyuk
From: Dmitry Kozlyuk Performance of MLX5 PMD of different classes can benefit if PMD knows which memory it will need to handle in advance, before the first mbuf is sent to the PMD. It is impractical, however, to consider all allocated memory for this purpose. Most often mbuf memory comes from mem

[dpdk-dev] [PATCH v2 2/4] mempool: add non-IO flag

2021-09-29 Thread dkozlyuk
From: Dmitry Kozlyuk Mempool is a generic allocator that is not necessarily used for device IO operations and its memory for DMA. Add MEMPOOL_F_NON_IO flag to mark such mempools. Signed-off-by: Dmitry Kozlyuk Acked-by: Matan Azrad --- doc/guides/rel_notes/release_21_11.rst | 3 +++ lib/mempoo

[dpdk-dev] [PATCH v2 3/4] common/mlx5: add mempool registration facilities

2021-09-29 Thread dkozlyuk
From: Dmitry Kozlyuk Add internal API to register mempools, that is, to create memory regions (MR) for their memory and store them in a separate database. Implementation deals with multi-process, so that class drivers don't need to. Each protection domain has its own database. Memory regions can

[dpdk-dev] [PATCH v2 4/4] net/mlx5: support mempool registration

2021-09-29 Thread dkozlyuk
From: Dmitry Kozlyuk When the first port in a given protection domain (PD) starts, install a mempool event callback for this PD and register all existing memory regions (MR) for it. When the last port in a PD closes, remove the callback and unregister all mempools for this PD. This behavior can b

Re: [dpdk-dev] [PATCH v2 0/3] add option to configure UDP ports verification

2021-09-29 Thread Akhil Goyal
> Add option to indicate whether UDP encapsulation ports verification > need to be done as part of inbound IPsec processing. > CNXK PMD support and unit tests are also added for the same. > > Depends on > https://patches.dpdk.org/project/dpdk/list/?series=18755 > Series Acked-by: Akhil Goyal Ap

Re: [dpdk-dev] [PATCH v1] ethdev: introduce shared Rx queue

2021-09-29 Thread Xueming(Steven) Li
On Wed, 2021-09-29 at 12:35 +, Ananyev, Konstantin wrote: > > > -Original Message- > > From: Xueming(Steven) Li > > Sent: Wednesday, September 29, 2021 1:09 PM > > To: jerinjac...@gmail.com; Ananyev, Konstantin > > > > Cc: NBU-Contact-Thomas Monjalon ; > > andrew.rybche...@oktetlab

Re: [dpdk-dev] [PATCH v2] telemetry: fix "in-memory" process socket conflicts

2021-09-29 Thread Kevin Traynor
On 29/09/2021 14:32, Bruce Richardson wrote: On Wed, Sep 29, 2021 at 01:28:53PM +0100, Kevin Traynor wrote: Hi Bruce, On 24/09/2021 17:18, Bruce Richardson wrote: When DPDK is run with --in-memory mode, multiple processes can run simultaneously using the same runtime dir. This leads to each pr

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/i40e: fix risk in Rx descriptor read in scalar path

2021-09-29 Thread Ferruh Yigit
On 9/15/2021 9:33 AM, Ruifeng Wang wrote: > Rx descriptor is 16B/32B in size. If the DD bit is set, it indicates > that the rest of the descriptor words have valid values. Hence, the > word containing DD bit must be read first before reading the rest of > the descriptor words. > > Since the entire

Re: [dpdk-dev] [PATCH v2] telemetry: fix "in-memory" process socket conflicts

2021-09-29 Thread Bruce Richardson
On Wed, Sep 29, 2021 at 03:54:48PM +0100, Kevin Traynor wrote: > On 29/09/2021 14:32, Bruce Richardson wrote: > > On Wed, Sep 29, 2021 at 01:28:53PM +0100, Kevin Traynor wrote: > > > Hi Bruce, > > > > > > On 24/09/2021 17:18, Bruce Richardson wrote: > > > > When DPDK is run with --in-memory mode,

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/2] net/i40e: fix risk in Rx descriptor read in scalar path

2021-09-29 Thread Honnappa Nagarahalli
> > On 9/15/2021 9:33 AM, Ruifeng Wang wrote: > > Rx descriptor is 16B/32B in size. If the DD bit is set, it indicates > > that the rest of the descriptor words have valid values. Hence, the > > word containing DD bit must be read first before reading the rest of > > the descriptor words. > > > >

Re: [dpdk-dev] [PATCH v2] telemetry: fix "in-memory" process socket conflicts

2021-09-29 Thread Bruce Richardson
On Wed, Sep 29, 2021 at 04:24:06PM +0100, Bruce Richardson wrote: > On Wed, Sep 29, 2021 at 03:54:48PM +0100, Kevin Traynor wrote: > > On 29/09/2021 14:32, Bruce Richardson wrote: > > > On Wed, Sep 29, 2021 at 01:28:53PM +0100, Kevin Traynor wrote: > > > > Hi Bruce, > > > > > > > > On 24/09/2021 1

[dpdk-dev] [dpdk-dev v1] test/crypto: maxlen calculation update

2021-09-29 Thread Kai Ji
Update the calculation of the max length needed when converting mbuf to data vec in partial digest test case. This update make sure the enough vec buffers are allocated for the appended digest in sgl op for QAT raw datapath api. Fixes: 4868f6591c6f ("test/crypto: add cases for raw datapath API") C

Re: [dpdk-dev] [PATCH v1 1/3] common/cnxk: set key length setting for PDCP algos

2021-09-29 Thread Akhil Goyal
> Subject: [PATCH v1 1/3] common/cnxk: set key length setting for PDCP algos > > Set proper bits in the context based on key length for PDCP > > Signed-off-by: Vidya Sagar Velumuri > Series Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v4 10/18] net/i40e/base: fix headers to match functions

2021-09-29 Thread Ferruh Yigit
On 9/6/2021 3:02 AM, Robin Zhang wrote: > Fix several kernel-doc warnings when building with W=1. These changes > are only to comments. > Same here, why shared code drop has Linux kernel specific updates? > Fixes: 8db9e2a1b232 ("i40e: base driver") > Fixes: 842ea1996335 ("i40e/base: save link mo

Re: [dpdk-dev] [PATCH v2] telemetry: fix "in-memory" process socket conflicts

2021-09-29 Thread Kevin Traynor
On 29/09/2021 16:31, Bruce Richardson wrote: On Wed, Sep 29, 2021 at 04:24:06PM +0100, Bruce Richardson wrote: On Wed, Sep 29, 2021 at 03:54:48PM +0100, Kevin Traynor wrote: On 29/09/2021 14:32, Bruce Richardson wrote: On Wed, Sep 29, 2021 at 01:28:53PM +0100, Kevin Traynor wrote: Hi Bruce,

Re: [dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support

2021-09-29 Thread Thomas Monjalon
29/09/2021 17:56, Srikanth K: > Hi Thomas, > > PFA the test report. It covers all the features that were tested across > various platforms. > > The features mentioned in the test report depend on a modified FreeBSD > OFED. There is an ongoing review of these changes by the FreeBSD community. > ht

Re: [dpdk-dev] [PATCH v4 01/18] net/i40e/base: add new versions of send ASQ command functions

2021-09-29 Thread Ferruh Yigit
On 9/6/2021 3:02 AM, Robin Zhang wrote: > ASQ send command functions are returning only i40e status codes > yet some calling functions also need Admin Queue status > that is stored in hw->aq.asq_last_status. Since hw object > is stored on a heap it introduces a possibility for > a race condition in

Re: [dpdk-dev] [PATCH v4 00/18] i40e base code update

2021-09-29 Thread Ferruh Yigit
On 9/6/2021 3:02 AM, Robin Zhang wrote: > update i40e base code. > > source code of i40e driver: > cid-i40e.2021.08.16.tar.gz > > changelog in i40e share repo: > From 59a080f4fafe ("i40e-shared: Add opcode 0x0406 and 0x0416 to Linux > support") To 2c7aab559654 ("i40e-shared: Add defines related t

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 05/18] net/i40e/base: fix PHY type identifiers for 2.5G and 5G adapters

2021-09-29 Thread Ferruh Yigit
On 9/6/2021 3:02 AM, Robin Zhang wrote: > Unlike other supported adapters, 2.5G and 5G use different > PHY type identifiers for reading/writing PHY settings > and for reading link status. This commit intruduces s/intruduces/introduces/ > separate PHY identifiers for these two operation types. >

Re: [dpdk-dev] [PATCH v4 02/18] net/i40e/base: add support for Min Rollback Revision for 4 more X722 modules

2021-09-29 Thread Ferruh Yigit
On 9/6/2021 3:02 AM, Robin Zhang wrote: > This change increments X722 API version and adds new constants related to > the extended implementation of Security Version Opt-In. > There are new 'I40E_AQ_RREV_MODULE_PHY_*' macros, what is their relation with "Security Version Opt-In"? Also title ment

Re: [dpdk-dev] [PATCH v4 03/18] net/i40e/base: set TSA table values when parsing CEE configuration

2021-09-29 Thread Ferruh Yigit
On 9/6/2021 3:02 AM, Robin Zhang wrote: > Driver did not Set TSA table values when parsing CEE configuration > obtained from FW. > > Signed-off-by: Pawel Malinowski > Signed-off-by: Robin Zhang Can you please long version of the 'TSA' & 'CEE' abbreviations in the commit log? There are more in

Re: [dpdk-dev] [PATCH v4 08/18] net/i40e/base: fix AOC media type reported by ethtool

2021-09-29 Thread Ferruh Yigit
On 9/6/2021 3:02 AM, Robin Zhang wrote: > For Active Optical Cable (AOC) the correct media type is "Fibre", > not "Direct Attach Copper". > > Fixes: d749d4d89969 ("i40e/base: add AOC PHY types") > Fixes: aa153cc89ff0 ("net/i40e/base: add new PHY types for 25G AOC and > ACC") > Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH v4 04/18] net/i40e/base: define new Shadow RAM pointers

2021-09-29 Thread Ferruh Yigit
On 9/6/2021 3:02 AM, Robin Zhang wrote: > Add definitions for Shadow RAM pointers: 6th FPA module, 5th FPA module > in X722 and Preservation Rules Module. > > Signed-off-by: Stanislaw Grzeszczak > Signed-off-by: Robin Zhang Can you please update patch title to use all lowercase except abbreviat

Re: [dpdk-dev] [PATCH v4 14/18] net/i40e/base: separate kernel allocated rx_bi rings from AF_XDP rings

2021-09-29 Thread Ferruh Yigit
On 9/6/2021 3:02 AM, Robin Zhang wrote: > Continuing the path to support MEM_TYPE_XSK_BUFF_POOL, the AF_XDP > zero-copy/sk_buff rx_bi rings are now separate. Functions to properly > allocate the different rings are added as well. > > Signed-off-by: Björn Töpel > Signed-off-by: Robin Zhang Again

Re: [dpdk-dev] [dpdk-stable] [PATCH v4 06/18] net/i40e/base: fix PF reset failed

2021-09-29 Thread Ferruh Yigit
On 9/6/2021 3:02 AM, Robin Zhang wrote: > PF has to delete all the filters during reset. > If it is fully loaded with filters then it is possible > that it will take more than 200 ms to finish the reset > resulting in timeout during pf_reset and > PF reset failed, -15 error indication. > Increasing

Re: [dpdk-dev] [PATCH v4 09/18] net/i40e/base: add flags and fields for double vlan processing

2021-09-29 Thread Ferruh Yigit
On 9/6/2021 3:02 AM, Robin Zhang wrote: > Add flags for outer vlan and include set port parameters in Linux > compilation. Isn't this a shared code drop, why it has changes specific to Linux compilation? > Add flags, which describe port and switch state for both double vlan > functionality and ou

  1   2   >