Hi Thomas, On 9/29/21 11:17 AM, Thomas Monjalon wrote: > Hi Andrew, > Thanks a lot for working on this. > I had sent the deprecation notice and forgot about it, apologies.
No worries. I always liked to delete some code. I think it is my favorite in programming :-) > > 28/09/2021 18:16, Andrew Rybchenko: >> A more file grain flow API should be used instead of it. > > Do you mean "fine-grain"? Thanks. Fixed. > I think we can reference the rte_flow action to be used: > RTE_FLOW_ACTION_TYPE_SAMPLE Yes, I think is useful, added in v2. > >> --- a/doc/guides/rel_notes/release_21_11.rst >> +++ b/doc/guides/rel_notes/release_21_11.rst >> +* ethdev: Removed the port mirroring API. A more fine grain flow API may >> + be used instead. The structures ``rte_eth_mirror_conf`` and >> + ``rte_eth_vlan_mirror`` and the functions ``rte_eth_mirror_rule_set`` >> + and ``rte_eth_mirror_rule_reset`` along with the associated macros >> + ``ETH_MIRROR_*`` are removed. > > Here as well we can mention the replacement RTE_FLOW_ACTION_TYPE_SAMPLE. Yes, added in v2.
