Re: [dpdk-dev] [PATCH v4 06/13] net/bnxt: add support for tunnel offload API

[Ferruh Yigit]

On 9/29/2021 9:20 AM, Thomas Monjalon wrote:
> 28/09/2021 23:32, Ajit Khaparde:
>> On Tue, Sep 28, 2021 at 5:43 AM Ferruh Yigit <ferruh.yi...@intel.com> wrote:
>>> Following warning is reported by Jerin & Thomas:
>>>
>>> $ ./devtools/check-doc-vs-code.sh
>>> rte_flow doc out of sync for bnxt
>>>         action shared
>>>
>>>
>>> This is mainly saying 'RTE_FLOW_ACTION_TYPE_SHARED' flow action is 
>>> supported but
>>> not documented. But from code I am not sure if shared action is used, there 
>>> is
>>> only one range check using this enum in the code, can you please clarify?
>>
>> Correct. RTE_FLOW_ACTION_TYPE_SHARED is being used only for a range check.
>> It is not really a supported action right now as far as the code is 
>> concerned.
>> As of now, no document update is necessary. Thanks
> 
> You need to update something to make the check OK.
> If it is a false positive, it can be handled in the script,
> but we cannot let the script returning an error.
> 
>

I will add following exception to the script (suggested by Thomas) in the 
next-net:

diff --git a/devtools/parse-flow-support.sh b/devtools/parse-flow-support.sh
index 8462abe53603..63c0b20e234f 100755
--- a/devtools/parse-flow-support.sh
+++ b/devtools/parse-flow-support.sh
@@ -25,7 +25,8 @@ exclude() # <pattern>
                                $dir/tf_ulp/ulp_rte_handler_tbl.c |
                                grep -wo "$1[[:alnum:]_]*" | sort -u |
                                tr '\n' '|' | sed 's,.$,\n,')
-                       grep -vE "$filter";;
+                       exceptions='RTE_FLOW_ACTION_TYPE_SHARED'
+                       grep -vE "$filter" | grep -vE $exceptions;;
                *) cat
        esac
 }