Hi Bruce, >-----Original Message----- >From: Richardson, Bruce <[email protected]> >Sent: Friday 24 September 2021 17:19 >To: [email protected] >Cc: Power, Ciara <[email protected]>; Burakov, Anatoly ><[email protected]>; Richardson, Bruce ><[email protected]>; [email protected]; David Marchand ><[email protected]> >Subject: [PATCH v2] telemetry: fix "in-memory" process socket conflicts > >When DPDK is run with --in-memory mode, multiple processes can run >simultaneously using the same runtime dir. This leads to each process >removing another process' telemetry socket as it started up, giving >unexpected behaviour. > >This patch changes that behaviour to first check if the existing socket is >active. >If not, it's an old socket to be cleaned up and can be removed. If it is >active, >telemetry initialization fails and an error message is printed out giving >instructions on how to remove the error; either by using file-prefix to have a >different runtime dir (and therefore socket path) or by disabling telemetry if >it >not needed. > >Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") >Cc: [email protected] > >Reported-by: David Marchand <[email protected]> >Signed-off-by: Bruce Richardson <[email protected]> >--- >v2: fix build error on FreeBSD >--- <snip>
Acked-by: Ciara Power <[email protected]> Thanks!
