29/09/2021 17:56, Srikanth K: > Hi Thomas, > > PFA the test report. It covers all the features that were tested across > various platforms. > > The features mentioned in the test report depend on a modified FreeBSD > OFED. There is an ongoing review of these changes by the FreeBSD community. > https://reviews.freebsd.org/p/vag.singh_oneconvergence.com/
OK, this dependency is very important to notify in this patchset. For next version, please add it in the cover letter. The supported features (MTU, MAC, VLAN, RSS, fragments, jumbo, stats and trust mode) should be listed in the cover letter as well as in the mlx5 documentation. Please follow what was done for Windows. About the patches organization, please do not fix or remove something which was added in a previous patch. You need to have logical steps done in each patch without going backward. Please start with enabling compilation in first patch, so each step can be tested. Thanks
