Re: [dpdk-dev] [PATCH v4 01/11] ethdev: add extensions attributes to IPv6 item

2020-10-08 Thread Dekel Peled
Thanks, PSB. > -Original Message- > From: Ajit Khaparde > Sent: Thursday, October 8, 2020 6:14 AM > To: Dekel Peled > Cc: Ori Kam ; NBU-Contact-Thomas Monjalon > ; Ferruh Yigit ; Andrew > Rybchenko ; Ananyev, Konstantin > ; Olivier Matz ; > Wenzhuo Lu ; Beilei Xing ; > Iremonger, Bernard

Re: [dpdk-dev] [PATCH v2 4/5] vhost: add packed ring vectorized dequeue

2020-10-08 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 6, 2020 10:59 PM > To: Liu, Yong ; Xia, Chenbo ; > Wang, Zhihong > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 4/5] vhost: add packed ring vectorized dequeue > > > > On 9/21/20 8:48 AM, Marvin Liu wrote: > > Optimize

Re: [dpdk-dev] [PATCH v2 5/5] vhost: add packed ring vectorized enqueue

2020-10-08 Thread Liu, Yong
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, October 6, 2020 11:00 PM > To: Liu, Yong ; Xia, Chenbo ; > Wang, Zhihong > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 5/5] vhost: add packed ring vectorized enqueue > > > > On 9/21/20 8:48 AM, Marvin Liu wrote: > > Optimize

Re: [dpdk-dev] [PATCH v5] eal: add cache-line demote support

2020-10-08 Thread David Marchand
On Thu, Oct 1, 2020 at 2:30 AM Omkar Maslekar wrote: > > rte_cldemote is similar to a prefetch hint - in reverse. cldemote(addr) > enables software to hint to hardware that line is likely to be shared. > Useful in core-to-core communications where cache-line is likely to be > shared. ARM and PPC i

Re: [dpdk-dev] [PATCH v1] net/iavf: fix flow flush after PF reset

2020-10-08 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Jia > Sent: Wednesday, September 30, 2020 1:44 PM > To: Wu, Jingjing ; Zhang, Qi Z ; > Xing, Beilei > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH v1] net/iavf: fix flow flush after PF reset > > When VF begin reset after PF reset, VF will be uninitia

Re: [dpdk-dev] [PATCH v4 01/11] ethdev: add extensions attributes to IPv6 item

2020-10-08 Thread Ajit Khaparde
On Wed, Oct 7, 2020 at 3:55 AM Dekel Peled wrote: > > Using the current implementation of DPDK, an application cannot match on > IPv6 packets, based on the existing extension headers, in a simple way. > > Field 'Next Header' in IPv6 header indicates type of the first extension > header only. Follo

Re: [dpdk-dev] [PATCH v3 1/3] test/event_crypto_adapter: return error with unsupported mode

2020-10-08 Thread Gujjar, Abhinandan S
acked-by: abhinandan.guj...@intel.com > -Original Message- > From: Ankur Dwivedi > Sent: Wednesday, October 7, 2020 10:56 AM > To: dev@dpdk.org > Cc: Gujjar, Abhinandan S ; jer...@marvell.com; > ano...@marvell.com; Ankur Dwivedi > Subject: [PATCH v3 1/3] test/event_crypto_adapter: return

Re: [dpdk-dev] [PATCH v3 3/3] test/event_crypto_adapter: free resources during exit

2020-10-08 Thread Gujjar, Abhinandan S
acked-by: abhinandan.guj...@intel.com > -Original Message- > From: Ankur Dwivedi > Sent: Wednesday, October 7, 2020 10:56 AM > To: dev@dpdk.org > Cc: Gujjar, Abhinandan S ; jer...@marvell.com; > ano...@marvell.com; Ankur Dwivedi > Subject: [PATCH v3 3/3] test/event_crypto_adapter: free r

Re: [dpdk-dev] [PATCH v3 2/3] test/event_crypto_adapter: fix function arguments

2020-10-08 Thread Gujjar, Abhinandan S
acked-by: abhinandan.guj...@intel.com > -Original Message- > From: Ankur Dwivedi > Sent: Wednesday, October 7, 2020 10:56 AM > To: dev@dpdk.org > Cc: Gujjar, Abhinandan S ; jer...@marvell.com; > ano...@marvell.com; Ankur Dwivedi > Subject: [PATCH v3 2/3] test/event_crypto_adapter: fix fu

Re: [dpdk-dev] [PATCH v12 0/5] eal: add WC store functions

2020-10-08 Thread David Marchand
On Wed, Sep 23, 2020 at 4:23 PM Radu Nicolau wrote: > > Implement 2 new functions that will enable write combining > stores depending on architecture. The functions are provided > as a generic stub and a x86 specific implementation. > > The reason to implement these functions is to improve perform

Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add flow shared action API

2020-10-08 Thread Andrey Vesnovaty
Hi, Ajit. All spelling & rephrases will be fixed in next couple of hours & v7 will be sent. PSB response on shared action configuration documentation. Please respond ASAP since RC1 window about to close very soon. Thanks, Andrey > -Original Message- > From: Ajit Khaparde > Sent: Thurs

Re: [dpdk-dev] [PATCH v5 00/15] fix distributor synchronization issues

2020-10-08 Thread David Marchand
On Thu, Oct 8, 2020 at 7:24 AM Lukasz Wojciechowski wrote: > > During review and verification of the patch created by Sarosh Arif: > "test_distributor: prevent memory leakages from the pool" I found out > that running distributor unit tests multiple times in a row causes fails. > So I investigated

Re: [dpdk-dev] [PATCH 1/1] eal: increase TRACE CTF SIZE to recommended size

2020-10-08 Thread David Marchand
On Mon, Oct 5, 2020 at 10:16 PM Timothy McDaniel wrote: > > Increase TRACE_CTF_FIELD_SIZE to 448, the recommended size. > Fixes "CTF field is too long" error when running with trace enabled. > > Signed-off-by: Timothy McDaniel Applied with added acks from Jerin and Sunil, thanks. -- David Mar

Re: [dpdk-dev] [PATCH v2] eal: add new prefetch write variants

2020-10-08 Thread David Marchand
On Mon, Sep 14, 2020 at 5:09 PM Harry van Haaren wrote: > > This commit adds a new rte_prefetch0_write() variants, suggesting to the > compiler to use a prefetch instruction with intention to write. As a > compiler builtin, the compiler can choose based on compilation target > what the best implem

Re: [dpdk-dev] [PATCH v2 1/1] librte_eal: rte_intr_callback_unregister_sync() - wrapper around rte_intr_callback_unregister().

2020-10-08 Thread David Marchand
On Mon, Aug 17, 2020 at 4:09 PM Renata Saiakhova wrote: > > Avoid race with unregister interrupt hanlder if interrupt > source has some active callbacks at the moment, use wrapper > around rte_intr_callback_unregister() to check for -EAGAIN > return value and to loop until rte_intr_callback_unregi

Re: [dpdk-dev] [PATCH v2] eal: simplify exit functions

2020-10-08 Thread David Marchand
On Mon, Sep 28, 2020 at 2:01 AM Thomas Monjalon wrote: > > The option RTE_EAL_ALWAYS_PANIC_ON_ERROR was off by default, > and not customizable with meson. It is completely removed. > > The function rte_dump_registers is a trace of the bare metal support > era, and was not supported in userland. It

Re: [dpdk-dev] [PATCH v5 03/15] distributor: do not use oldpkt when not needed

2020-10-08 Thread David Hunt
Hi Lukasz, On 8/10/2020 6:23 AM, Lukasz Wojciechowski wrote: rte_distributor_request_pkt and rte_distributor_get_pkt dereferenced oldpkt parameter when in RTE_DIST_ALG_SINGLE even if number of returned buffers from worker to distributor was 0. This patch passes NULL to the legacy API when numbe

[dpdk-dev] [PATCH v2 1/1] cryptodev: remove v20 ABI compatibility

2020-10-08 Thread Adam Dybkowski
This reverts commit a0f0de06d457753c94688d551a6e8659b4d4e041 as the rte_cryptodev_info_get function versioning was a temporary solution to maintain ABI compatibility for ChaCha20-Poly1305 and is not needed in 20.11. Fixes: a0f0de06d457 ("cryptodev: fix ABI compatibility for ChaCha20-Poly1305") Si

[dpdk-dev] [PATCH v2 0/1] cryptodev: remove v20 ABI compatibility

2020-10-08 Thread Adam Dybkowski
This reverts commit cryptodev: fix ABI compatibility for ChaCha20-Poly1305 as the rte_cryptodev_info_get function versioning was a temporary solution to maintain ABI compatibility for ChaCha20-Poly1305 and is not needed in 20.11. Adam Dybkowski (1): cryptodev: remove v20 ABI compatibility -- v

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-08 Thread Thomas Monjalon
> Add two new power management intrinsics, and provide an implementation > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > are implemented as raw byte opcodes because there is not yet widespread > compiler support for these instructions. > > The power management instructions p

Re: [dpdk-dev] [PATCH v2] eal: add new prefetch write variants

2020-10-08 Thread Van Haaren, Harry
> -Original Message- > From: David Marchand > Sent: Thursday, October 8, 2020 8:43 AM > To: Van Haaren, Harry ; Richardson, Bruce > ; Ananyev, Konstantin > ; Jerin Jacob Kollanukkaran > ; > Ruifeng Wang (Arm Technology China) ; Jan Viktorin > ; David Christensen ; > Honnappa Nagarahalli

Re: [dpdk-dev] [PATCH v2] eal: add new prefetch write variants

2020-10-08 Thread Van Haaren, Harry
> -Original Message- > From: Van Haaren, Harry > Sent: Thursday, October 8, 2020 9:34 AM > To: David Marchand ; Richardson, Bruce > ; Ananyev, Konstantin > ; Jerin Jacob Kollanukkaran > ; > Ruifeng Wang (Arm Technology China) ; Jan Viktorin > ; David Christensen ; > Honnappa Nagarahalli >

Re: [dpdk-dev] [PATCH v5 1/3] app/testpmd: add GENEVE parsing

2020-10-08 Thread Ophir Munk
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, October 7, 2020 7:25 PM > To: Ophir Munk ; dev@dpdk.org; Wenzhuo Lu <...> > Only when user set via "--geneve-port=N", it is the port for testpmd to parse > (same for 'geneve_udp_port' global variable), but when user give comman

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-08 Thread Jerin Jacob
On Thu, Oct 8, 2020 at 2:04 PM Thomas Monjalon wrote: > > > Add two new power management intrinsics, and provide an implementation > > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > > are implemented as raw byte opcodes because there is not yet widespread > > compiler support

Re: [dpdk-dev] [PATCH v4 03/10] ethdev: add simple power management API

2020-10-08 Thread Thomas Monjalon
> +/** > + * Retrieve the wake up address from specific queue > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param queue_id > + * The Tx queue on the Ethernet device for which information > + * will be retrieved. > + * @param wake_addr > + * The pointer

Re: [dpdk-dev] [PATCH 2/3] examples/fips_validation: ignore \r in input files

2020-10-08 Thread Zhang, Roy Fan
Hi Olivier, Anood and us had the similar discussion. Can we change the sample application to parse version data instead, and for the version specific code changes we will wrap them by a branch to compare the parsed version and the expected version? (we probably should have done that long time ag

[dpdk-dev] [PATCH v2 0/6] introduce support for hairpin between two ports

2020-10-08 Thread Bing Zhao
The patches contain the following changes: 1. new APIs to bind and unbind hairpin ports in manual binding mode. 2. new API to get the hairpin peer ports list. 3. new internal APIs for PMD to pass the queue information and configure the queue pair. 4. new attribute members in the hairpin queue co

[dpdk-dev] [PATCH v2 1/6] ethdev: add hairpin bind and unbind APIs

2020-10-08 Thread Bing Zhao
In single port hairpin mode, all the hairpin TX and RX queues belong to the same device. After the queues are set up properly, there is no other dependency between the TX queue and its RX peer queue. The binding process that connected the TX and RX queues together from hardware level will be done a

[dpdk-dev] [PATCH v2 2/6] ethdev: add new attributes to hairpin config

2020-10-08 Thread Bing Zhao
To support two ports hairpin mode and keep the backward compatibility for the application, two new attribute members of hairpin queue configuration structure are added. `tx_explicit` means if the application itself will insert the TX part flow rules. If not set, PMD will insert the rules implicitl

[dpdk-dev] [PATCH v2 3/6] ethdev: add API to get hairpin peer ports list

2020-10-08 Thread Bing Zhao
After hairpin queues are configured, in general, the application will maintain the ports topology and even the queues configuration for hairpin. But sometimes it will not. If there is no hot-plug, it is easy to bind and unbind hairpin among all the ports. The application can just connect or discon

[dpdk-dev] [PATCH v2 6/6] doc: update for two ports hairpin mode

2020-10-08 Thread Bing Zhao
In the release notes, 2 ports hairpin mode feature is added. In rte flow part, one suggestion is added to mention that metadata could be used to connect the hairpin RX and TX flows if the hairpin is working in explicit TX flow rule mode. In the testpmd command line, the new parameter to set hairp

[dpdk-dev] [PATCH v2 4/6] ethdev: add APIs for hairpin queue operation

2020-10-08 Thread Bing Zhao
Every hairpin queue pair should be configured properly and the connection between TX and RX queues should be established, before hairpin function works. In single port hairpin mode, the queues of each pair belong to the same device. It is easy to get the hardware and software information of each qu

[dpdk-dev] [PATCH v2 5/6] app/testpmd: change hairpin queues setup

2020-10-08 Thread Bing Zhao
A new parameter `hairpin-mode` is introduced to the testpmd command line. Bitmask value is used to provide more flexible configuration. This parameter should be used when `hairpinq` is specified in the command line. Bit 0 in the LSB indicates the hairpin will use the loop mode. The previous port R

Re: [dpdk-dev] [PATCH 1/3 v2] ethdev: add rx offload to drop error packets

2020-10-08 Thread Nipun Gupta
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, October 6, 2020 6:44 PM > To: Nipun Gupta > Cc: Stephen Hemminger ; dpdk-dev > ; Thomas Monjalon ; Ferruh Yigit > ; Andrew Rybchenko ; > Hemant Agrawal ; Sachin Saxena > ; Rohit Raj > Subject: Re: [dpdk-dev] [PATCH 1/3 v2] ethde

Re: [dpdk-dev] [PATCH v2] eal: add new prefetch write variants

2020-10-08 Thread Jerin Jacob
On Mon, Sep 14, 2020 at 8:39 PM Harry van Haaren wrote: > > This commit adds a new rte_prefetch0_write() variants, suggesting to the > compiler to use a prefetch instruction with intention to write. As a > compiler builtin, the compiler can choose based on compilation target > what the best implem

Re: [dpdk-dev] [PATCH 1/3 v2] ethdev: add rx offload to drop error packets

2020-10-08 Thread Jerin Jacob
On Thu, Oct 8, 2020 at 2:23 PM Nipun Gupta wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Tuesday, October 6, 2020 6:44 PM > > To: Nipun Gupta > > Cc: Stephen Hemminger ; dpdk-dev > > ; Thomas Monjalon ; Ferruh Yigit > > ; Andrew Rybchenko ; > > Hemant Agrawal ; Sach

Re: [dpdk-dev] [PATCH 2/7] security: modify PDCP xform to support SDAP

2020-10-08 Thread Akhil Goyal
Hi David, > Hi Akhil > > > > @@ -693,6 +693,23 @@ PDCP related configuration parameters are defined > > in ``rte_security_pdcp_xform`` > > uint32_t hfn; > > /** HFN Threshold for key renegotiation */ > > uint32_t hfn_threshold; > > +/** HFN can be given as a per

Re: [dpdk-dev] [PATCH v5] eal: add cache-line demote support

2020-10-08 Thread Bruce Richardson
On Thu, Oct 08, 2020 at 09:09:52AM +0200, David Marchand wrote: > On Thu, Oct 1, 2020 at 2:30 AM Omkar Maslekar > wrote: > > > > rte_cldemote is similar to a prefetch hint - in reverse. cldemote(addr) > > enables software to hint to hardware that line is likely to be shared. > > Useful in core-to

Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add hairpin bind and unbind APIs

2020-10-08 Thread Ori Kam
Hi Bing > -Original Message- > From: Bing Zhao > Sent: Thursday, October 8, 2020 11:52 AM > Subject: [PATCH v2 1/6] ethdev: add hairpin bind and unbind APIs > > In single port hairpin mode, all the hairpin TX and RX queues belong > to the same device. After the queues are set up properly

Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue

2020-10-08 Thread Bruce Richardson
On Wed, Oct 07, 2020 at 11:48:48PM +0200, Thomas Monjalon wrote: > As described in doc/guides/prog_guide/poll_mode_drv.rst, > the naming scheme for the xstats is parts separated with underscore: > * direction > * detail 1 > * detail 2 > * detail n > * unit > where deta

Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue

2020-10-08 Thread Kevin Traynor
On 07/10/2020 22:48, Thomas Monjalon wrote: > As described in doc/guides/prog_guide/poll_mode_drv.rst, > the naming scheme for the xstats is parts separated with underscore: > * direction > * detail 1 > * detail 2 > * detail n > * unit > where detail 1 can be "q" follo

Re: [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode

2020-10-08 Thread Jerin Jacob
On Tue, Sep 8, 2020 at 2:48 PM Ankur Dwivedi wrote: > > The capability of a event device should be checked before creating > a event crypto adapter in a particular mode. The test case returns > error if the mode is not supported. > > Signed-off-by: Ankur Dwivedi Hi Ankur, Please fix git-log.sh

Re: [dpdk-dev] [PATCH 2/3] examples/fips_validation: ignore \r in input files

2020-10-08 Thread Olivier Matz
Hi, On Thu, Oct 08, 2020 at 08:50:25AM +, Zhang, Roy Fan wrote: > Hi Olivier, > > Anood and us had the similar discussion. > > Can we change the sample application to parse version data instead, > and for the version specific code changes we will wrap them by a > branch to compare the parsed

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add new attributes to hairpin config

2020-10-08 Thread Ori Kam
Hi Bing, > -Original Message- > From: Bing Zhao > Sent: Thursday, October 8, 2020 11:52 AM > Subject: [PATCH v2 2/6] ethdev: add new attributes to hairpin config > > To support two ports hairpin mode and keep the backward compatibility > for the application, two new attribute members of

Re: [dpdk-dev] [PATCH v3 01/18] eal: add max SIMD bitwidth

2020-10-08 Thread Power, Ciara
Hi Olivier, >-Original Message- >From: Olivier Matz >Sent: Wednesday 7 October 2020 12:18 >To: Power, Ciara >Cc: dev@dpdk.org; Ray Kinsella ; Neil Horman >; Richardson, Bruce >Subject: Re: [dpdk-dev] [PATCH v3 01/18] eal: add max SIMD bitwidth > >Hi Ciara, > >On Wed, Oct 07, 2020 at 10

Re: [dpdk-dev] [PATCH 1/2] app/test: uninit vdevs in event eth Rx adapter autotest

2020-10-08 Thread Jerin Jacob
On Wed, Oct 7, 2020 at 3:43 PM Rao, Nikhil wrote: > > > > > -Original Message- > > From: Jayatheerthan, Jay > > Sent: Saturday, October 3, 2020 2:36 PM > > To: jer...@marvell.com; tho...@monjalon.net; Rao, Nikhil > > > > Cc: dev@dpdk.org; sta...@dpdk.org; Jayatheerthan, Jay > > > > Subj

Re: [dpdk-dev] [PATCH v3 1/1] vfio: modify spapr iommu support to use static window sizing

2020-10-08 Thread Burakov, Anatoly
On 07-Oct-20 6:44 PM, David Christensen wrote: On 9/17/20 4:13 AM, Burakov, Anatoly wrote: On 10-Aug-20 10:07 PM, David Christensen wrote: The SPAPR IOMMU requires that a DMA window size be defined before memory can be mapped for DMA. Current code dynamically modifies the DMA window size in r

[dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module

2020-10-08 Thread Hariprasad Govindharajan
With DPDK 20.11 release, the igb_uio module is no more part of DPDK. There are use cases where this module is required, for example while testing the virtual ports in OvS, the virtual ports are bound to igb_uio module inside a VM. So, this patch provides a Makefile which can be used to build this m

Re: [dpdk-dev] [PATCH v2 3/6] ethdev: add API to get hairpin peer ports list

2020-10-08 Thread Ori Kam
Hi Bing, PSB, Best, Ori > -Original Message- > From: Bing Zhao > Sent: Thursday, October 8, 2020 11:52 AM > Subject: [PATCH v2 3/6] ethdev: add API to get hairpin peer ports list > > After hairpin queues are configured, in general, the application will > maintain the ports topology and e

Re: [dpdk-dev] [PATCH v4 02/10] eal: add power management intrinsics

2020-10-08 Thread Thomas Monjalon
08/10/2020 10:44, Jerin Jacob: > On Thu, Oct 8, 2020 at 2:04 PM Thomas Monjalon wrote: > > > > > Add two new power management intrinsics, and provide an implementation > > > in eal/x86 based on UMONITOR/UMWAIT instructions. The instructions > > > are implemented as raw byte opcodes because there i

[dpdk-dev] [PATCH] net/af_xdp: Don't allow umem sharing for xsks with same netdev, qid

2020-10-08 Thread Ciara Loftus
Supporting this would require locks, which would impact the performance of the more typical cases - xsks with different qids and netdevs. Signed-off-by: Ciara Loftus Fixes: 74b46340e2d4 ("net/af_xdp: support shared UMEM") --- drivers/net/af_xdp/rte_eth_af_xdp.c | 44 +++--

Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module

2020-10-08 Thread Burakov, Anatoly
On 08-Oct-20 10:40 AM, Hariprasad Govindharajan wrote: With DPDK 20.11 release, the igb_uio module is no more part of DPDK. There are use cases where this module is required, for example while testing the virtual ports in OvS, the virtual ports are bound to igb_uio module inside a VM. So, this pa

Re: [dpdk-dev] [PATCH v2 4/6] ethdev: add APIs for hairpin queue operation

2020-10-08 Thread Ori Kam
Hi Bing, > -Original Message- > From: Bing Zhao > Sent: Thursday, October 8, 2020 11:52 AM > Subject: [PATCH v2 4/6] ethdev: add APIs for hairpin queue operation > > Every hairpin queue pair should be configured properly and the > connection between TX and RX queues should be established

Re: [dpdk-dev] [PATCH v2 5/6] app/testpmd: change hairpin queues setup

2020-10-08 Thread Ori Kam
Hi Bing > -Original Message- > From: Bing Zhao > Sent: Thursday, October 8, 2020 11:52 AM > Subject: [PATCH v2 5/6] app/testpmd: change hairpin queues setup > > A new parameter `hairpin-mode` is introduced to the testpmd command > line. Bitmask value is used to provide more flexible conf

Re: [dpdk-dev] [PATCH v2 6/6] doc: update for two ports hairpin mode

2020-10-08 Thread Ori Kam
Hi Bing, > -Original Message- > From: Bing Zhao > Sent: Thursday, October 8, 2020 11:52 AM > Subject: [PATCH v2 6/6] doc: update for two ports hairpin mode > > In the release notes, 2 ports hairpin mode feature is added. > > In rte flow part, one suggestion is added to mention that meta

[dpdk-dev] [PATCH v6 00/25] raw/ioat: enhancements and new hardware support

2020-10-08 Thread Bruce Richardson
This patchset adds some small enhancements, some rework and also support for new hardware to the ioat rawdev driver. Most rework and enhancements are largely self-explanatory from the individual patches. The new hardware support is for the Intel(R) DSA accelerator which will be present in future I

Re: [dpdk-dev] [PATCH v12 0/5] eal: add WC store functions

2020-10-08 Thread Nicolau, Radu
On 10/8/2020 8:28 AM, David Marchand wrote: On Wed, Sep 23, 2020 at 4:23 PM Radu Nicolau wrote: Implement 2 new functions that will enable write combining stores depending on architecture. The functions are provided as a generic stub and a x86 specific implementation. The reason to implement

[dpdk-dev] [PATCH v6 01/25] doc/api: add ioat driver to index

2020-10-08 Thread Bruce Richardson
Add the ioat driver to the doxygen documentation. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz Acked-by: Radu Nicolau --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf.in | 1 + 2 files changed, 2 insertions(+) diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-in

[dpdk-dev] [PATCH v6 03/25] raw/ioat: enable use from C++ code

2020-10-08 Thread Bruce Richardson
To allow the header file to be used from C++ code we need to ensure all typecasts are explicit, and include an 'extern "C"' guard. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz Acked-by: Radu Nicolau --- drivers/raw/ioat/rte_ioat_rawdev.h | 23 +-- 1 file changed

[dpdk-dev] [PATCH v6 02/25] raw/ioat: fix missing close function

2020-10-08 Thread Bruce Richardson
From: Kevin Laatz When rte_rawdev_pmd_release() is called, rte_rawdev_close() looks for a dev_close function for the device causing a segmentation fault when no close() function is implemented for a driver. This patch resolves the issue by adding a stub function ioat_dev_close(). Fixes: f687e84

[dpdk-dev] [PATCH v6 04/25] raw/ioat: include extra info in error messages

2020-10-08 Thread Bruce Richardson
In case of any failures, include the function name and the line number of the error message in the message, to make tracking down the failure easier. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz Acked-by: Radu Nicolau --- drivers/raw/ioat/ioat_rawdev_test.c | 53 +++

[dpdk-dev] [PATCH v6 06/25] raw/ioat: split header for readability

2020-10-08 Thread Bruce Richardson
Rather than having a single long complicated header file for general use we can split things so that there is one header with all the publicly needed information - data structs and function prototypes - while the rest of the internal details are put separately. This makes it easier to read, underst

[dpdk-dev] [PATCH v6 05/25] raw/ioat: add a flag to control copying handle parameters

2020-10-08 Thread Bruce Richardson
From: Cheng Jiang Add a flag which controls whether rte_ioat_enqueue_copy and rte_ioat_completed_copies function should process handle parameters. Not doing so can improve the performance when handle parameters are not necessary. Signed-off-by: Cheng Jiang Signed-off-by: Bruce Richardson Revie

[dpdk-dev] [PATCH v6 07/25] raw/ioat: rename functions to be operation-agnostic

2020-10-08 Thread Bruce Richardson
Since the hardware supported by the ioat driver is capable of operations other than just copies, we can rename the doorbell and completion-return functions to not have "copies" in their names. These functions are not copy-specific, and so would apply for other operations which may be added later to

[dpdk-dev] [PATCH v6 09/25] raw/ioat: make the HW register spec private

2020-10-08 Thread Bruce Richardson
Only a few definitions from the hardware spec are actually used in the driver runtime, so we can copy over those few and make the rest of the spec a private header in the driver. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz Acked-by: Radu Nicolau --- drivers/raw/ioat/ioat_rawdev.c

[dpdk-dev] [PATCH v6 08/25] raw/ioat: add separate API for fence call

2020-10-08 Thread Bruce Richardson
Rather than having the fence signalled via a flag on a descriptor - which requires reading the docs to find out whether the flag needs to go on the last descriptor before, or the first descriptor after the fence - we can instead add a separate fence API call. This becomes unambiguous to use, since

[dpdk-dev] [PATCH v6 10/25] usertools/dpdk-devbind.py: add support for DSA HW

2020-10-08 Thread Bruce Richardson
From: Kevin Laatz Intel Data Streaming Accelerator (Intel DSA) is a high-performance data copy and transformation accelerator which will be integrated in future Intel processors [1]. Add DSA device support to dpdk-devbind.py script. [1] https://01.org/blogs/2019/introducing-intel-data-streaming

[dpdk-dev] [PATCH v6 12/25] raw/ioat: add vdev probe for DSA/idxd devices

2020-10-08 Thread Bruce Richardson
From: Kevin Laatz The Intel DSA devices can be exposed to userspace via kernel driver, so can be used without having to bind them to vfio/uio. Therefore we add support for using those kernel-configured devices as vdevs, taking as parameter the individual HW work queue to be used by the vdev. Sig

[dpdk-dev] [PATCH v6 11/25] raw/ioat: add skeleton for VFIO/UIO based DSA device

2020-10-08 Thread Bruce Richardson
Add in the basic probe/remove skeleton code for DSA devices which are bound directly to vfio or uio driver. The kernel module for supporting these uses the "idxd" name, so that name is used as function and file prefix to avoid conflict with existing "ioat" prefixed functions. Since we are adding n

[dpdk-dev] [PATCH v6 14/25] raw/ioat: create rawdev instances on idxd PCI probe

2020-10-08 Thread Bruce Richardson
When a matching device is found via PCI probe create a rawdev instance for each queue on the hardware. Use empty self-test function for these devices so that the overall rawdev_autotest does not report failures. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz Acked-by: Radu Nicolau ---

[dpdk-dev] [PATCH v6 13/25] raw/ioat: include example configuration script

2020-10-08 Thread Bruce Richardson
Devices managed by the idxd kernel driver must be configured for DPDK use before it can be used by the ioat driver. This example script serves both as a quick way to get the driver set up with a simple configuration, and as the basis for users to modify it and create their own configuration scripts

[dpdk-dev] [PATCH v6 15/25] raw/ioat: create rawdev instances for idxd vdevs

2020-10-08 Thread Bruce Richardson
From: Kevin Laatz For each vdev (DSA work queue) instance, create a rawdev instance. Signed-off-by: Kevin Laatz Signed-off-by: Bruce Richardson Acked-by: Radu Nicolau --- drivers/raw/ioat/idxd_vdev.c| 106 +++- drivers/raw/ioat/ioat_private.h | 4 ++ 2 files

[dpdk-dev] [PATCH v6 17/25] raw/ioat: add configure function for idxd devices

2020-10-08 Thread Bruce Richardson
Add configure function for idxd devices, taking the same parameters as the existing configure function for ioat. The ring_size parameter is used to compute the maximum number of bursts to be supported by the driver, given that the hardware works on individual bursts of descriptors at a time. Signe

[dpdk-dev] [PATCH v6 16/25] raw/ioat: add datapath data structures for idxd devices

2020-10-08 Thread Bruce Richardson
Add in the relevant data structures for the data path for DSA devices. Also include a device dump function to output the status of each device. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz Acked-by: Radu Nicolau --- drivers/raw/ioat/idxd_pci.c| 1 + drivers/raw/ioat/id

[dpdk-dev] [PATCH v6 18/25] raw/ioat: add start and stop functions for idxd devices

2020-10-08 Thread Bruce Richardson
Add the start and stop functions for DSA hardware devices using the vfio/uio kernel drivers. For vdevs using the idxd kernel driver, the device must be started using sysfs before the device node appears for vdev use - making start/stop functions in the driver unnecessary. Signed-off-by: Bruce Rich

[dpdk-dev] [PATCH v6 20/25] raw/ioat: add info function for idxd devices

2020-10-08 Thread Bruce Richardson
Add the info get function for DSA devices, returning just the ring size info about the device, same as is returned for existing IOAT/CBDMA devices. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz Acked-by: Radu Nicolau --- drivers/raw/ioat/idxd_pci.c | 1 + drivers/raw/ioat/idxd_

[dpdk-dev] [PATCH v6 21/25] raw/ioat: create separate statistics structure

2020-10-08 Thread Bruce Richardson
Rather than having the xstats as fields inside the main driver structure, create a separate structure type for them. As part of the change, when updating the stats functions referring to the stats by the old path, we can simplify them to use the id to directly index into the stats structure, makin

[dpdk-dev] [PATCH v6 19/25] raw/ioat: add data path for idxd devices

2020-10-08 Thread Bruce Richardson
Add support for doing copies using DSA hardware. This is implemented by just switching on the device type field at the start of the inline functions. Since there is no hardware which will have both device types present this branch will always be predictable after the first call, meaning it has litt

[dpdk-dev] [PATCH v6 22/25] raw/ioat: move xstats functions to common file

2020-10-08 Thread Bruce Richardson
The xstats functions can be used by all ioat devices so move them from the ioat_rawdev.c file to ioat_common.c, and add the function prototypes to the internal header file. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz Acked-by: Radu Nicolau --- drivers/raw/ioat/ioat_common.c | 59

[dpdk-dev] [PATCH v6 23/25] raw/ioat: add xstats tracking for idxd devices

2020-10-08 Thread Bruce Richardson
Add update of the relevant stats for the data path functions and point the overall device struct xstats function pointers to the existing ioat functions. At this point, all necessary hooks for supporting the existing unit tests are in place so call them for each device. Signed-off-by: Bruce Richa

[dpdk-dev] [PATCH v6 24/25] raw/ioat: clean up use of common test function

2020-10-08 Thread Bruce Richardson
Now that all devices can pass the same set of unit tests, eliminate the temporary idxd_rawdev_test function and move the prototype for ioat_rawdev_test to the proper internal header file, to be used by all device instances. Signed-off-by: Bruce Richardson Reviewed-by: Kevin Laatz Acked-by: Radu

[dpdk-dev] [PATCH v6 25/25] raw/ioat: add fill operation

2020-10-08 Thread Bruce Richardson
From: Kevin Laatz Add fill operation enqueue support for IOAT and IDXD. The fill enqueue is similar to the copy enqueue, but takes a 'pattern' rather than a source address to transfer to the destination address. This patch also includes an additional test case for the new operation type. Signed-

[dpdk-dev] [PATCH V16 0/3] add FEC support

2020-10-08 Thread Min Hu (Connor)
This series add FEC support for ethdev. Min Hu (Connor) (3): ethdev: introduce FEC API net/hns3: support FEC app/testpmd: add FEC command app/test-pmd/cmdline.c | 232 ++ app/test-pmd/config.c | 91 +++ app/test-pmd/testpmd.h

[dpdk-dev] [PATCH V16 3/3] app/testpmd: add FEC command

2020-10-08 Thread Min Hu (Connor)
This commit adds testpmd capability to query and config FEC function of device. This includes: - show FEC capabilities, example: testpmd> show port 0 fec capabilities - show FEC mode, example: testpmd> show port 0 fec_mode - config FEC mode, example: testpmd> set port fec_m

[dpdk-dev] [PATCH V16 2/3] net/hns3: support FEC

2020-10-08 Thread Min Hu (Connor)
Forward error correction (FEC) is a bit error correction mode. It adds error correction information to data packets at the transmit end, and uses the error correction information to correct the bit errors generated during data packet transmission at the receive end. This improves signal quality but

Re: [dpdk-dev] [PATCH v3 01/18] eal: add max SIMD bitwidth

2020-10-08 Thread Olivier Matz
Hi Ciara, On Thu, Oct 08, 2020 at 09:25:42AM +, Power, Ciara wrote: > Hi Olivier, > > > >-Original Message- > >From: Olivier Matz > >Sent: Wednesday 7 October 2020 12:18 > >To: Power, Ciara > >Cc: dev@dpdk.org; Ray Kinsella ; Neil Horman > >; Richardson, Bruce > >Subject: Re: [dpd

[dpdk-dev] [PATCH V16 1/3] ethdev: introduce FEC API

2020-10-08 Thread Min Hu (Connor)
This patch adds Forward error correction(FEC) support for ethdev. Introduce APIs which support query and config FEC information in hardware. Signed-off-by: Min Hu (Connor) Reviewed-by: Wei Hu (Xavier) Reviewed-by: Chengwen Feng Reviewed-by: Chengchang Tang Acked-by: Andrew Rybchenko Reviewed-

Re: [dpdk-dev] [PATCH V15 3/3] app/testpmd: add FEC command

2020-10-08 Thread Min Hu (Connor)
Hi, Ferruh, I have sent patches of new version named V16. Please check it out, thanks. 在 2020/10/8 7:38, humin (Q) 写道: HI,Ferry,      thank you very much. this is good news to me. I promise the new version will be sent in these two days.       thanks again. ---

Re: [dpdk-dev] [PATCH v4] doc: add stack mempool guide

2020-10-08 Thread David Marchand
On Wed, Oct 7, 2020 at 4:41 PM Olivier Matz wrote: > > On Wed, Oct 07, 2020 at 09:18:32AM -0500, Gage Eads wrote: > > This guide describes the two stack modes, their tradeoffs, and (via a > > reference to the mempool guide) how to enable them. > > > > Signed-off-by: Gage Eads > > Reviewed-by: Oli

Re: [dpdk-dev] [PATCH 2/3] examples/fips_validation: ignore \r in input files

2020-10-08 Thread Zhang, Roy Fan
Hi Olivier, Sorry I didn't state myself clear in the first place. My intention is '\r' check, or any future CAVS version specific change to the application should be wrapped into a branch that is checked with parsed version number. With this way the original application's behavior should remain t

Re: [dpdk-dev] [PATCH 1/1] timer: add limitation note for sync stop and reset

2020-10-08 Thread David Marchand
On Thu, Sep 10, 2020 at 3:23 AM Honnappa Nagarahalli wrote: > > If a timer's callback function calls rte_timer_reset_sync() or > > rte_timer_stop_sync() on another timer that is in the RUNNING state and > > owned by the current lcore, the *_sync() calls will loop indefinitely. > > > > Relatedly, i

Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per queue

2020-10-08 Thread Asaf Penso
>-Original Message- >From: dev On Behalf Of Kevin Traynor >Sent: Thursday, October 8, 2020 12:10 PM >To: NBU-Contact-Thomas Monjalon ; dev@dpdk.org >Cc: ferruh.yi...@intel.com; arybche...@solarflare.com >Subject: Re: [dpdk-dev] [PATCH] ethdev: fix xstat name of basic stats per >queue > >On

[dpdk-dev] [PATCH v4 0/3] event/octeontx2: add support for event crypto adapter

2020-10-08 Thread Ankur Dwivedi
This patch series adds support for event crypto adapter in op new mode in the OCTEON TX2 event PMD. The functionality has been verified with event crypto adapter test application. Build with meson and ninja is supported. v4: * In the "event/octeontx2: add crypto adapter datapath" patch, replaced

[dpdk-dev] [PATCH v4 2/3] event/octeontx2: add crypto adapter framework

2020-10-08 Thread Ankur Dwivedi
The crypto adapter callback functions and associated data structures are added. Signed-off-by: Ankur Dwivedi --- drivers/crypto/octeontx2/meson.build | 1 + .../octeontx2/otx2_cryptodev_hw_access.h | 12 +++ .../crypto/octeontx2/otx2_cryptodev_mbox.h| 2 + drivers/crypto/octe

[dpdk-dev] [PATCH v4 1/3] crypto/octeontx2: move functions to helper file

2020-10-08 Thread Ankur Dwivedi
Some functions are common across cryptodev pmd and the event crypto adapter. This patch moves them into a helper file. Signed-off-by: Ankur Dwivedi --- drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 65 +--- .../octeontx2/otx2_cryptodev_ops_helper.h | 74 +++ 2 f

[dpdk-dev] [PATCH v4 3/3] event/octeontx2: add crypto adapter datapath

2020-10-08 Thread Ankur Dwivedi
In the op new mode of crypto adapter, the completed crypto operation is submitted to the event device by the OCTEON TX2 crypto PMD. During event device dequeue the result of crypto operation is checked. Signed-off-by: Ankur Dwivedi --- drivers/common/cpt/cpt_common.h | 1 + driver

Re: [dpdk-dev] [PATCH 2/4] raw/dpaa2: fix build with gcc 11

2020-10-08 Thread David Marchand
On Thu, Oct 8, 2020 at 11:08 AM Nipun Gupta wrote: > > Hi David, > > https://patchwork.dpdk.org/patch/76983/ - this patch have same changes? > Please check and let me know what shall be done. Ok, I'll mark Ferruh patch as rejected. Thank you. -- David Marchand

Re: [dpdk-dev] [PATCH 3/4] app/testpmd: fix build with gcc 11

2020-10-08 Thread David Marchand
On Mon, Sep 21, 2020 at 3:39 PM Ferruh Yigit wrote: > > Error observed with gcc 11 under development > gcc (GCC) 11.0.0 20200920 (experimental) > > ../app/test-pmd/config.c:1777:61: > warning: argument 3 of type ‘const uint32_t[n]’ > {aka ‘const unsigned int[n]’} declared as a vari

Re: [dpdk-dev] [PATCH 4/4] pmdinfogen: fix build with gcc 11

2020-10-08 Thread David Marchand
On Thu, Sep 24, 2020 at 11:32 AM David Marchand wrote: > On Mon, Sep 21, 2020 at 3:39 PM Ferruh Yigit wrote: > > > > Error observed with gcc 11 under development > > gcc (GCC) 11.0.0 20200920 (experimental) > > > > build error: > > In file included from ../buildtools/pmdinfogen/pmdinfogen.c:17: >

Re: [dpdk-dev] [PATCH v3 00/14] acl: introduce AVX512 classify methods

2020-10-08 Thread David Marchand
On Tue, Oct 6, 2020 at 6:13 PM Ananyev, Konstantin wrote: > > > v2 -> v3: > > > Fix checkpatch warnings > > > Split AVX512 algorithm into two and deduplicate common code > > > > Patch 7 still references a RTE_MACHINE_CPUFLAG flag. > > Can you rework now that those flags have been dropped? > >

  1   2   3   4   >