acked-by: abhinandan.guj...@intel.com

> -----Original Message-----
> From: Ankur Dwivedi <adwiv...@marvell.com>
> Sent: Wednesday, October 7, 2020 10:56 AM
> To: dev@dpdk.org
> Cc: Gujjar, Abhinandan S <abhinandan.guj...@intel.com>; jer...@marvell.com;
> ano...@marvell.com; Ankur Dwivedi <adwiv...@marvell.com>
> Subject: [PATCH v3 2/3] test/event_crypto_adapter: fix function arguments
> 
> The arguments passed to rte_event_crypto_adapter_caps_get() and
> rte_event_crypto_adapter_create() are incorrect.
> 
> In the rte_event_crypto_adapter_caps_get(), event device id should be the 
> first
> argument and cryptodev id should be the second argument.
> In the rte_event_crypto_adapter_create(), the event device id should be the
> second argument.
> 
> Signed-off-by: Ankur Dwivedi <adwiv...@marvell.com>
> ---
>  app/test/test_event_crypto_adapter.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 3c64742b3..87a67139d 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -209,8 +209,8 @@ test_op_forward_mode(uint8_t session_less)
>                               &cipher_xform, params.session_priv_mpool);
>               TEST_ASSERT_SUCCESS(ret, "Failed to init session\n");
> 
> -             ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID,
> -                                                     evdev, &cap);
> +             ret = rte_event_crypto_adapter_caps_get(evdev,
> TEST_CDEV_ID,
> +                                                     &cap);
>               TEST_ASSERT_SUCCESS(ret, "Failed to get adapter
> capabilities\n");
> 
>               if (cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA) { @@ -296,7
> +296,7 @@ test_sessionless_with_op_forward_mode(void)
>       uint32_t cap;
>       int ret;
> 
> -     ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev,
> &cap);
> +     ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
>       TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> 
>       if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ -
> 321,7 +321,7 @@ test_session_with_op_forward_mode(void)
>       uint32_t cap;
>       int ret;
> 
> -     ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev,
> &cap);
> +     ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
>       TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> 
>       if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ -
> 410,8 +410,8 @@ test_op_new_mode(uint8_t session_less)
>                               params.session_mpool);
>               TEST_ASSERT_NOT_NULL(sess, "Session creation failed\n");
> 
> -             ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID,
> -                                                     evdev, &cap);
> +             ret = rte_event_crypto_adapter_caps_get(evdev,
> TEST_CDEV_ID,
> +                                                     &cap);
>               TEST_ASSERT_SUCCESS(ret, "Failed to get adapter
> capabilities\n");
> 
>               if (cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA) { @@ -460,7
> +460,7 @@ test_sessionless_with_op_new_mode(void)
>       uint32_t cap;
>       int ret;
> 
> -     ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev,
> &cap);
> +     ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
>       TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> 
>       if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ -
> 486,7 +486,7 @@ test_session_with_op_new_mode(void)
>       uint32_t cap;
>       int ret;
> 
> -     ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev,
> &cap);
> +     ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
>       TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> 
>       if (!(cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ -
> 706,7 +706,7 @@ test_crypto_adapter_create(void)
> 
>       /* Create adapter with default port creation callback */
>       ret = rte_event_crypto_adapter_create(TEST_ADAPTER_ID,
> -                                           TEST_CDEV_ID,
> +                                           evdev,
>                                             &conf, 0);
>       TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto adapter\n");
> 
> @@ -719,7 +719,7 @@ test_crypto_adapter_qp_add_del(void)
>       uint32_t cap;
>       int ret;
> 
> -     ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev,
> &cap);
> +     ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
>       TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> 
>       if (cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) {
> --
> 2.28.0

Reply via email to