On Tue, Sep 8, 2020 at 2:48 PM Ankur Dwivedi <adwiv...@marvell.com> wrote:
>
> The capability of a event device should be checked before creating
> a event crypto adapter in a particular mode. The test case returns
> error if the mode is not supported.
>
> Signed-off-by: Ankur Dwivedi <adwiv...@marvell.com>
Hi Ankur,
Please fix git-log.sh error[1] the following in this series and send
the version.
Headline too long:
test/event_crypto_adapter: return error with unsupported mode
Wrong tag:
acked-by: abhinandan.guj...@intel.com
acked-by: abhinandan.guj...@intel.com
acked-by: abhinandan.guj...@intel.com
Missing 'Fixes' tag:
test/event_crypto_adapter: fix function arguments
[1]
./devtools/check-git-log.sh -n 3
./devtools/checkpatches.sh -n 3
> ---
> app/test/test_event_crypto_adapter.c | 30 ++++++++++++++++++----------
> 1 file changed, 20 insertions(+), 10 deletions(-)
>
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 8d42462d8..930c2a9bc 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -750,15 +750,23 @@ configure_event_crypto_adapter(enum
> rte_event_crypto_adapter_mode mode)
> uint32_t cap;
> int ret;
>
> + ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, &cap);
> + TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> +
> + if ((mode == RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) &&
> + !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD))
> + return -ENOTSUP;
> +
> + if ((mode == RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) &&
> + !(cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW))
> + return -ENOTSUP;
> +
> /* Create adapter with default port creation callback */
> ret = rte_event_crypto_adapter_create(TEST_ADAPTER_ID,
> - TEST_CDEV_ID,
> + evdev,
> &conf, mode);
> TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto adapter\n");
>
> - ret = rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, &cap);
> - TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> -
> if (cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) {
> ret = rte_event_crypto_adapter_queue_pair_add(TEST_ADAPTER_ID,
> TEST_CDEV_ID, TEST_CDEV_QP_ID,
> &response_info);
> @@ -813,6 +821,8 @@ test_crypto_adapter_conf(enum
> rte_event_crypto_adapter_mode mode)
> TEST_ASSERT(ret >= 0, "Failed to link queue %d "
> "port=%u\n", qid,
> params.crypto_event_port_id);
> + } else {
> + return ret;
> }
> crypto_adapter_setup_done = 1;
> }
> @@ -845,24 +855,24 @@ static int
> test_crypto_adapter_conf_op_forward_mode(void)
> {
> enum rte_event_crypto_adapter_mode mode;
> + int ret;
>
> mode = RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD;
> - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
> - "Failed to config crypto adapter");
> + ret = test_crypto_adapter_conf(mode);
>
> - return TEST_SUCCESS;
> + return ret;
> }
>
> static int
> test_crypto_adapter_conf_op_new_mode(void)
> {
> enum rte_event_crypto_adapter_mode mode;
> + int ret;
>
> mode = RTE_EVENT_CRYPTO_ADAPTER_OP_NEW;
> - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode),
> - "Failed to config crypto adapter");
> + ret = test_crypto_adapter_conf(mode);
>
> - return TEST_SUCCESS;
> + return ret;
> }
>
>
> --
> 2.28.0
>
