[dpdk-dev] [PATCH 00/70] update e1000 base code

2020-06-22 Thread Guinan Sun
update e1000 base code. Guinan Sun (70): net/e1000/base: i210 slow system clock update net/e1000/base: add initial support for Foxville net/e1000/base: add ICL device id's net/e1000/base: remove shadowing variable declarations net/e1000/base: introduce flag net/e1000/base: modify MAC i

[dpdk-dev] [PATCH 02/70] net/e1000/base: add initial support for Foxville

2020-06-22 Thread Guinan Sun
Add Foxville device's ID and mac type, bind device's ID and MAC type. Add basic Foxville functionality. Add phy ID's for Foxville. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/Makefile |1 + drivers/net/e1000/base/e1000_82575.c | 10 +- drivers

[dpdk-dev] [PATCH 03/70] net/e1000/base: add ICL device id's

2020-06-22 Thread Guinan Sun
This patch contains a preliminary support for new LAN device ID's. Signed-off-by: Lotem Leder Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.c | 4 drivers/net/e1000/base/e1000_hw.h | 4 2 files changed, 8 insertions(+) diff --git a/drivers/net/e1000/base/e1000_api.c

[dpdk-dev] [PATCH 05/70] net/e1000/base: introduce flag

2020-06-22 Thread Guinan Sun
Introduce E1000_TARC0_CB_MULTIQ_2_REQ flag to make flexible adjusting number of outstanding requests. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e

[dpdk-dev] [PATCH 01/70] net/e1000/base: i210 slow system clock update

2020-06-22 Thread Guinan Sun
This code is required for the update to i210 errata #25. Signed-off-by: Todd Fujinaka Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_i210.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e

[dpdk-dev] [PATCH 04/70] net/e1000/base: remove shadowing variable declarations

2020-06-22 Thread Guinan Sun
The variable phy_reg is already declared at the top of e1000_check_for_copper_link_ich8lan() and we don't need to re-declare it in the inner if{} scope. Remove the unnecessary extra declarations which fixes the sparse warning generated by shadowed variable names. Signed-off-by: Jacob Keller Signe

[dpdk-dev] [PATCH 07/70] net/e1000/base: modify flash presence for i225 devices

2020-06-22 Thread Guinan Sun
ntroduce flash presence method for i225 devices. Resolve conflict with legacy i210. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_nvm.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e1000_nvm.c b/driv

[dpdk-dev] [PATCH 08/70] net/e1000/base: add i225 devices PHY type

2020-06-22 Thread Guinan Sun
add i225 devices PHY type. Initialization phy's ops.read and ops.write pointers. Add relevant MMD registers and masks for i225 devices. Implemented GPY methods for read and write PHY registers. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 5

[dpdk-dev] [PATCH 09/70] net/e1000/base: expose xmdio methods

2020-06-22 Thread Guinan Sun
move read and write xmdio methods to e1000_phy.* These methods implement PHY clause 45 access via clause 22 MMD registers (13 and 14). We now need it for i225 devices access to GPY, but the approach is actually IEEE-standardized and can be used by various PHY's. Make these methods common accessible

[dpdk-dev] [PATCH 06/70] net/e1000/base: modify MAC initialization

2020-06-22 Thread Guinan Sun
Fix mac initialization for i225 and i211 devices. Fix parens to match the rest of the MAC checks. Signed-off-by: Todd Fujinaka Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff

[dpdk-dev] [PATCH 10/70] net/e1000/base: modify negotiation advertisement

2020-06-22 Thread Guinan Sun
Add 2.5G auto negotiation advertisement. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 2 ++ drivers/net/e1000/base/e1000_phy.c | 33 ++ 2 files changed, 35 insertions(+) diff --git a/drivers/net/e1000/base/e1000

[dpdk-dev] [PATCH 11/70] net/e1000/base: fall through explicitly

2020-06-22 Thread Guinan Sun
This patch adds/changes fall through comments to address new warnings produced by gcc 7. Signed-off-by: Todd Fujinaka Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 4 ++-- drivers/net/e1000/base/e1000_mbx.c | 1 + drivers/net/e1000/base/e1000_phy.c | 1 + 3 files chan

Re: [dpdk-dev] [PATCH v3 2/7] ethdev: add a link status textrepresentation

2020-06-22 Thread Ferruh Yigit
On 6/18/2020 1:32 PM, Morten Brørup wrote: >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >> Sent: Thursday, June 18, 2020 2:03 PM >> >> On 6/18/2020 11:08 AM, Ivan Dyukov wrote: >>> Hi Ferruh, >>> >>> Thank you for the comments. >>> >>> My answers are inlined. >>> >>> Best re

[dpdk-dev] [PATCH 15/70] net/e1000/base: setup copper link function for i225

2020-06-22 Thread Guinan Sun
A dedicated function for i225 that Configures the link for auto-neg or forced speed and duplex. It was taken from the e1000_setup_copper_link_82575 function in e1000_82575 file and was refactored for i225 only. Signed-off-by: Dany Trakhtenberg Signed-off-by: Guinan Sun --- drivers/net/e1000/bas

[dpdk-dev] [PATCH 12/70] net/e1000/base: add function parameter descriptions

2020-06-22 Thread Guinan Sun
Add function parameter descriptions to address gcc 7 warnings. Signed-off-by: Todd Fujinaka Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 11 +-- drivers/net/e1000/base/e1000_mac.c | 8 drivers/net/e1000/base/e1000_mbx.c | 4 drivers/net/e1000/

[dpdk-dev] [PATCH 13/70] net/e1000/base: modify klocwork errors

2020-06-22 Thread Guinan Sun
This patch fixes klocwork scans errors relating to operands in bitwise operations having different sizes. Signed-off-by: Robert Konklewski Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 2 +- drivers/net/e1000/base/e1000_i210.c | 2 +- drivers/net/e1000/base/e1000_phy.c

[dpdk-dev] [PATCH 14/70] net/e1000/base: add 2.5G speed advertisement

2020-06-22 Thread Guinan Sun
This patch defines the flags for 2.5G speed advertisement. Currently this speed is supported only on i225 (Foxville) devices. In this mode, the speed selection bits in the status register will be the same as in 1 Gbps mode, and, additionally, bit 22 in the status register will be turned on. Signed

[dpdk-dev] [PATCH 17/70] net/e1000/base: add new wakeup/proxy registers for i225

2020-06-22 Thread Guinan Sun
I225 expands wakeup and proxy capabilities compared to previous generations. The new capabilities are exposed via additional registers. Signed-off-by: Dima Ruinskiy Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 18 +- drivers/net/e1000/base/e1000_regs.h

[dpdk-dev] [PATCH 16/70] net/e1000/base: implement Low-Power-Link-Up (LPLU) for i225

2020-06-22 Thread Guinan Sun
I225 introduces a new mechanism for Low-Power-Link-Up (LPLU) control. This patch implements the new functions and sets the PHY OPS pointers. Signed-off-by: Dima Ruinskiy Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_i225.c | 58 + 1 file changed, 58 inse

[dpdk-dev] [PATCH 18/70] net/e1000/base: modify klockwork about unused return values

2020-06-22 Thread Guinan Sun
Klockwork found unreachable code since *clock_in_i2c_* always return success. Don't return unused s32 and don't check for constants. Signed-off-by: Todd Fujinaka Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletio

[dpdk-dev] [PATCH 21/70] net/e1000/base: modify description

2020-06-22 Thread Guinan Sun
Wrong description was found in the mentioned file, so fix them. Signed-off-by: Lifshits Vitaly Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_80003es2lan.c | 1 - drivers/net/e1000/base/e1000_ich8lan.c | 6 -- drivers/net/e1000/base/e1000_phy.c | 3 +++ 3 files chang

[dpdk-dev] [PATCH 19/70] net/e1000/base: improve coding style

2020-06-22 Thread Guinan Sun
fix typo in piece of code of NVM access for SPT. And cleans up the remaining instances in the shared code where it was not adhering to the Linux code standard. Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_i210.c| 4 ++-- drivers/net/e1000/base/e1000_ich8lan.c | 32

[dpdk-dev] [PATCH 20/70] net/e1000/base: modify HW level time sync mechanisms

2020-06-22 Thread Guinan Sun
Add additinal configuration space access to allow HW level time sync mechanism. Signed-off-by: Efimov Evgeny Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.c | 18 ++ drivers/net/e1000/base/e1000_ich8lan.h | 2 +- 2 files changed, 19 insertions(+), 1 deletio

[dpdk-dev] [PATCH 22/70] net/e1000/base: add EEE support for i225

2020-06-22 Thread Guinan Sun
This patch adds function e1000_set_eee_i225 which support EEE advertisement for 2.5G. Signed-off-by: Lotem Leder Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 1 + drivers/net/e1000/base/e1000_i225.c| 70 ++ 2 files changed, 71 insertions(+)

[dpdk-dev] [PATCH 23/70] net/e1000/base: remove duplicated codes from 82575

2020-06-22 Thread Guinan Sun
These files will improve e1000_82575 codes. Remove the code duplication from e1000_82575 files. Remove the licenses. Clean family specific functions from base. Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/Makefile | 1 + dr

[dpdk-dev] [PATCH 24/70] net/e1000/base: add info structure

2020-06-22 Thread Guinan Sun
Add the info structure which will contain structure pointers for MAC, PHY and NVM structures for i225 devices. Signed-off-by: Jeff Kirsher Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_hw.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/e1000/base/e1000_hw

[dpdk-dev] [PATCH 27/70] net/e1000/base: cleanup duplicate declaration

2020-06-22 Thread Guinan Sun
Fix up a stray and duplicate function declaration. Signed-off-by: Jeff Kirsher Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/e1000/base/e1000_api.h b/drivers/net/e1000/base/e1000_api.h index 34e065054..0b7b9016a

[dpdk-dev] [PATCH 26/70] net/e1000/base: wrap the e1000 regs.h file

2020-06-22 Thread Guinan Sun
Allow the e1000_regs.h be processed by build.mk and be closest as possible to the upstream igc_regs.h file Fix the duplication and redefinition. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.h | 2 +- drivers/net/e1000/base/e1000_regs.h | 42

[dpdk-dev] [PATCH 29/70] net/e1000/base: more function name cleanup

2020-06-22 Thread Guinan Sun
Now that several functions are "generic" or "base" functions, drop the family specific names to make more generic. This is another step closer to making the family specific files independent from other silicon specific family files and only include the "common" functions and files. Signed-off-by:

[dpdk-dev] [PATCH 28/70] net/e1000/base: modify wrapper for registers and definitions

2020-06-22 Thread Guinan Sun
Edit e1000_regs.h and e1000_defines.h files. Add miss registers and definition. Fix wrapper. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e1000_defi

[dpdk-dev] [PATCH 30/70] net/e1000/base: expose EEE defines

2020-06-22 Thread Guinan Sun
Expose the needed EEE register and defines. Signed-off-by: Jeff Kirsher Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 3 +++ drivers/net/e1000/base/e1000_i225.c| 12 +++- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/net/e1000/base/

[dpdk-dev] [PATCH 25/70] net/e1000/base: wrap the e1000 defines.h

2020-06-22 Thread Guinan Sun
Allow the e1000_defines.h to be processed by build.mk and be closest as possible to the upstream igc_defines.h file Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --

[dpdk-dev] [PATCH 31/70] net/e1000/base: expose the manage functionality

2020-06-22 Thread Guinan Sun
Add the manage header to the base file. Rid of compilation errors. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_manage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e1000_manage.c b/drivers/net/e1000/b

[dpdk-dev] [PATCH 33/70] net/e1000/base: wrap the unneeded code

2020-06-22 Thread Guinan Sun
The default flow control settings for i225 should be set up as 'full' for a request mode and do not depend from a NVM. '_set_default_fc_generic' method took value from NVM and set a wrong default flow control settings. Therefore driver up with none flow control settings. Setting up '_fc_full' direc

[dpdk-dev] [PATCH 32/70] net/e1000/base: modify the wrong return value

2020-06-22 Thread Guinan Sun
Make 'init_phy_hw_reset_generic' method to be closest to the upstream method. Fix the return value to be same as in upstream. Fix unable to handle kernel NULL pointer dereference at 0x0 caused to kernel panic. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e100

[dpdk-dev] [PATCH 35/70] net/e1000/base: expose more time synchronization registers

2020-06-22 Thread Guinan Sun
Legacy PTP support for i225 device required time synchronization registers. This patch add wrap to expose these registers to igc core files. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.h | 8 --- drivers/net/e1000/base/e1000_defines.h | 69 +++

[dpdk-dev] [PATCH 34/70] net/e1000/base: clean family specific functions from base

2020-06-22 Thread Guinan Sun
Clean family specific functions. Signed-off-by: Jeff Kirsher Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_i210.c | 2 -- drivers/net/e1000/base/e1000_i225.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e1000_i2

[dpdk-dev] [PATCH 39/70] net/e1000/base: increased timeout for ME ULP exit

2020-06-22 Thread Guinan Sun
Due timing issues in WHL and since recovery by host is not always supported, increased timeout for ME to finish ULP exit flow for Nahum before timer expiration. Signed-off-by: Efrati Nir Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.c | 7 +-- 1 file changed, 5 insertio

[dpdk-dev] [PATCH 36/70] net/e1000/base: add define to PCIm function state

2020-06-22 Thread Guinan Sun
Added define to pcim function state Signed-off-by: Lifshits Vitaly Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_defines.h b/drivers/net/e1000/base/e1000_defines.h index b132d5ee2..a909aa979

[dpdk-dev] [PATCH 37/70] net/e1000/base: add missing register defines

2020-06-22 Thread Guinan Sun
Added defines for the EEC, SHADOWINF and FLFWUPDATE registers needed for the nvmupd_validate_offset function to correctly validate the NVM update offset. Signed-off-by: Jeff Kirsher Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_regs.h | 8 +++- 1 file changed, 7 insertions(+),

[dpdk-dev] [PATCH 40/70] net/e1000/base: add missing device ID

2020-06-22 Thread Guinan Sun
Adding Intel(R) I210 Gigabit Network Connection 15F6 device ID for SGMII flashless automotive device. Signed-off-by: Kamil Bednarczyk Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.c | 1 + drivers/net/e1000/base/e1000_hw.h | 1 + 2 files changed, 2 insertions(+) diff --git a/

[dpdk-dev] [PATCH 38/70] net/e1000/base: move the device reset definition

2020-06-22 Thread Guinan Sun
Design change request. i225 devices going to use device reset instead of port soft reset. Move the device reset definition from _82575.h file to _defines.h file and add appropriate wrap. The reset flow changes for i225 will be submitted in separate patch. Signed-off-by: Sasha Neftin Signed-off-by

[dpdk-dev] [PATCH 42/70] net/e1000/base: expose more future extended NVM

2020-06-22 Thread Guinan Sun
Future extended NVM 5 (five) required for a Dynamic Power Gating control in the MAC. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_regs.h b/drivers/net/e1000/base/e1

[dpdk-dev] [PATCH 41/70] net/e1000/base: add Foxville device IDs

2020-06-22 Thread Guinan Sun
Add Foxville device IDs definitions according to the SKUs described in EAS. Signed-off-by: Lotem Leder Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.c | 3 +++ drivers/net/e1000/base/e1000_hw.h | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/n

[dpdk-dev] [PATCH 43/70] net/e1000/base: add definition of EEE 2.5G setup register

2020-06-22 Thread Guinan Sun
This is a new register which holds the minimum time in microseconds for 2500BASE-T operation. Signed-off-by: Lotem Leder Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_regs.h b/drivers/net/e1000

[dpdk-dev] [PATCH 45/70] net/e1000/base: remove useless statement

2020-06-22 Thread Guinan Sun
As it stands now, this fix will not change the current functionality of the code. In addition, we remove the comment that seemed to be a copy/paste from a separate implementation. Signed-off-by: Jeb Cramer Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.c | 7 --- 1 file

[dpdk-dev] [PATCH 44/70] net/e1000/base: add FXVL's Blank NVM device ID

2020-06-22 Thread Guinan Sun
In addition to commit 1b1a12, add definition of blank NVM device id and missing cases. Signed-off-by: Lotem Leder Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.c | 1 + drivers/net/e1000/base/e1000_hw.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/e1000/ba

[dpdk-dev] [PATCH 47/70] net/e1000/base: modify flow control setup

2020-06-22 Thread Guinan Sun
Customers had a problem with large pings after connected standby. This is due to the requirement of maintaining link after CS - the driver blocks resets during "AdapterStart" and skips flow control setup. Added condition in e1000_setup_link_ich8lan.c function that always setup flow control, and set

[dpdk-dev] [PATCH 48/70] net/e1000/base: support I225 update NVM flow

2020-06-22 Thread Guinan Sun
As long as I225 firmware is valid and operational, it is responsible for updating the NVM. If FW is not valid, it is up to the SW to update the NVM while making sure to check which sector is valid and update accordingly. Signed-off-by: Lotem Leder Signed-off-by: Guinan Sun --- drivers/net/e1000

[dpdk-dev] [PATCH 46/70] net/e1000/base: add missed define for VFTA

2020-06-22 Thread Guinan Sun
VLAN filtering using the VFTA (VLAN Filter Table Array) and should be initialized prior to setting rx mode. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_defines.h

[dpdk-dev] [PATCH 50/70] net/e1000/base: clean up dead code

2020-06-22 Thread Guinan Sun
For i225 devices, the tag NO_I225_SUPPORT will never be defined, so remove the tag and code that reside in the i225 family file. Signed-off-by: Jeff Kirsher Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_i225.c | 125 +--- 1 file changed, 1 insertion(+), 124

[dpdk-dev] [PATCH 51/70] net/e1000/base: expose new FEXTNVM registers and masks

2020-06-22 Thread Guinan Sun
Adding defines for FEXTNVM8 and FEXTNVM12 registers with new masks for future use. Signed-off-by: Nir Efrati Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.h | 5 ++--- drivers/net/e1000/base/e1000_regs.h| 2 ++ 2 files changed, 4 insertions(+), 3 deletions(-) diff --gi

[dpdk-dev] [PATCH 52/70] net/e1000/base: cleanup duplicate defines

2020-06-22 Thread Guinan Sun
Now that more than one silicon family uses the filter defines for ETQF, move the defines out of the 82575 silicon family header, into the general register/defines location. This will reduce the duplicate defines for drivers that support all the silicon families in one driver. Signed-off-by: Jeff

[dpdk-dev] [PATCH 53/70] net/e1000/base: add WUC registers and defines

2020-06-22 Thread Guinan Sun
Wake up control registers added for just i225 device. Corresponde to the i225 EAS, these registers in use and required for a legacy power management support. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 19 +++ 1 file changed

[dpdk-dev] [PATCH 49/70] net/e1000/base: led blinking fix for i210

2020-06-22 Thread Guinan Sun
Added initialization of identification LED. Signed-off-by: Maciej Hefczyc Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_i210.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e1000_i210.c index 1126b2916..8dadde

[dpdk-dev] [PATCH 54/70] net/e1000/base: correct PHY power up flow for i225

2020-06-22 Thread Guinan Sun
gPHY GPY211A1 specification (i225 PHY) required 300 microseconds delay after a good power up sequence. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_phy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_phy.c b/drivers/n

[dpdk-dev] [PATCH 57/70] net/e1000/base: add EEE functions and defines for IGC

2020-06-22 Thread Guinan Sun
Added support for required defines and functions to EEE for I225 drivers. Signed-off-by: Lifshits Vitaly Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e1000_defines.h b/driv

[dpdk-dev] [PATCH 56/70] net/e1000/base: add fall-through comments for switch cases

2020-06-22 Thread Guinan Sun
Add fall-through comments to cases without break statements. Signed-off-by: Jeb Cramer Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_vf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/e1000/base/e1000_vf.c b/drivers/net/e1000/base/e1000_vf.c index 543fa7741..dc

[dpdk-dev] [PATCH 55/70] net/e1000/base: add support for Nahum10

2020-06-22 Thread Guinan Sun
Add support to a new MAC type (for Nahum10) and new device ids (Alderlake). Operate rebuild after NAHUM10_HW introduction in the build.mk file. Code review comments addressed. Signed-off-by: Roman Fridlyand Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.c | 7 +++ driver

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-22 Thread Wei Hu (Xavier)
Hi, Sachin Saxena On 2020/6/22 13:10, Sachin Saxena (OSS) wrote: On 22-Jun-20 8:17 AM, Wei Hu (Xavier) wrote: Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver

[dpdk-dev] [PATCH 58/70] net/e1000/base: add PHY power management control

2020-06-22 Thread Guinan Sun
PHY power management control should provide a reliable and accurate indication of PHY reset completion and decrease the delay time after a PHY reset. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 4 drivers/net/e1000/base/e1000_phy.c

[dpdk-dev] [PATCH 60/70] net/e1000/base: add new device IDs for Foxville B2

2020-06-22 Thread Guinan Sun
Add support to new device IDs for Foxville B2. Signed-off-by: Lotem Leder Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.c | 3 +++ drivers/net/e1000/base/e1000_hw.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/net/e1000/base/e1000_api.c b/drivers/net/e1000/

[dpdk-dev] [PATCH 61/70] net/e1000/base: add address and queue select

2020-06-22 Thread Guinan Sun
Address select mask selects source address to be used in the address filtering. Queue select indicates which Rx queue should get the packet matching this MAC address. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 4 1 file changed, 4 ins

[dpdk-dev] [PATCH 59/70] net/e1000/base: introduce DPGFR register

2020-06-22 Thread Guinan Sun
Defined DPGFR, Dynamic Power Gate Force Control Register. Signed-off-by: Vitaly Lifshits Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_regs.h b/drivers/net/e1000/base/e1000_regs.h index 2a25854

[dpdk-dev] [PATCH 63/70] net/e1000/base: modify VLAN names

2020-06-22 Thread Guinan Sun
Fix defines macro to be align with upstream. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 3 +++ drivers/net/e1000/base/e1000_regs.h| 2 ++ 2 files changed, 5 insertions(+) diff --git a/drivers/net/e1000/base/e1000_defines.h b/drivers/

[dpdk-dev] [PATCH 62/70] net/e1000/base: introduce IEEE PHY ID mask

2020-06-22 Thread Guinan Sun
This patch introduce the proprietary mask to select PHYID bits from PHYID1 and PHYID2 words. PHYID2 word contain also Intel Device Number (LDN) and Intel Device Revision Nember (LDRN) Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 5 ++--- 1 f

[dpdk-dev] [PATCH 64/70] net/e1000/base: add EEE set function to share code API

2020-06-22 Thread Guinan Sun
For the e1000_set_eee function to be used by windows E2F driver added a reference function at api.c file. Signed-off-by: Evgeny Efimov Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.c | 16 drivers/net/e1000/base/e1000_api.h | 2 ++ 2 files changed, 18 insertio

[dpdk-dev] [PATCH 67/70] net/e1000/base: remove conditional compilation wrapper

2020-06-22 Thread Guinan Sun
Remove conditional compilation statements. Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 13 +-- drivers/net/e1000/base/e1000_hw.h | 4 - drivers/net/e1000/base/e1000_i210.c| 2 +- drivers/net/e1000/base/e1000_i225.c| 1 - drivers/net/e1000/base/e1000

[dpdk-dev] [PATCH 66/70] net/e1000/base: add LPI counters

2020-06-22 Thread Guinan Sun
A new defines is added to indicate if EEE LPI entries has been observed on Tx and Rx path. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_hw.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/e1000/base/e1000_hw.h b/drivers/net/e1000/bas

[dpdk-dev] [PATCH 65/70] net/e1000/base: add defines for source address filters

2020-06-22 Thread Guinan Sun
A new defines is added to indicate if the filter type is source or destination. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/e1000/base/e1000_defines.h b/drivers/net/e1000/bas

[dpdk-dev] [PATCH 68/70] net/e1000/base: modify copyright

2020-06-22 Thread Guinan Sun
Modify the copyright of the file header. Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_80003es2lan.c | 2 +- drivers/net/e1000/base/e1000_80003es2lan.h | 2 +- drivers/net/e1000/base/e1000_82540.c | 2 +- drivers/net/e1000/base/e1000_82541.c | 2 +- drivers/net/e1000/bas

[dpdk-dev] [PATCH 70/70] net/e1000/base: resolve core dump

2020-06-22 Thread Guinan Sun
The initialization of set_lan_id is deleted, resulting in a core dump when testpmd starts. This patch reverts part of the code to fix core dump problems. Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_mac.c | 65 + drivers/net/e1000/base/e1000_regs.h | 4

[dpdk-dev] [PATCH 69/70] net/e1000/base: update version

2020-06-22 Thread Guinan Sun
Update base code version in readme. Signed-off-by: Guinan Sun --- drivers/net/e1000/base/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/README b/drivers/net/e1000/base/README index 56738d001..b84ee5ad6 100644 --- a/drivers/net/e1000/base/REA

Re: [dpdk-dev] [PATCH v3 2/7] ethdev: add a link status textrepresentation

2020-06-22 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Monday, June 22, 2020 9:05 AM > > On 6/18/2020 1:32 PM, Morten Brørup wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > >> Sent: Thursday, June 18, 2020 2:03 PM > >> > >> On 6/18/2020 11:08 AM, Ivan Dyukov w

[dpdk-dev] [PATCH v8 0/9] Windows bus/pci support

2020-06-22 Thread talshn
From: Tal Shnaiderman This patchset implements the EAL and PCI functions needed for probing PMDs using RTE_KDRV_NONE on Windows. --- v8: * Move internal_config to static inside eal_common_config.c and use getters for all external uses. * Fix duplicated export line (FadyB)

[dpdk-dev] [PATCH v8 5/9] drivers: ignore pmdinfogen generation for Windows

2020-06-22 Thread talshn
From: Tal Shnaiderman pmdinfogen generation is currently unsupported for Windows. The relevant part in meson.build is skipped. Signed-off-by: Tal Shnaiderman --- drivers/meson.build | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/meson.

[dpdk-dev] [PATCH v8 3/9] pci: build on Windows

2020-06-22 Thread talshn
From: Tal Shnaiderman Added in rte_pci header file to include off_t type since it is missing for Windows. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_pci/rte_pci.h | 1 + lib/meson.build| 5 - 3 files changed, 6 ins

[dpdk-dev] [PATCH v8 7/9] bus/pci: introduce Windows support with stubs

2020-06-22 Thread talshn
From: Tal Shnaiderman Addition of stub eal and bus/pci functions to compile bus/pci for Windows. Signed-off-by: Tal Shnaiderman --- drivers/baseband/meson.build | 4 + drivers/bus/ifpga/meson.build | 6 ++ drivers/bus/pci/meson.build| 14 ++- drivers/bus/pci/pci_common.

[dpdk-dev] [PATCH v8 8/9] bus/pci: support Windows with bifurcated drivers

2020-06-22 Thread talshn
From: Tal Shnaiderman Uses SetupAPI.h functions to scan PCI tree. Uses DEVPKEY_Device_Numa_Node to get the PCI NUMA node. Uses SPDRP_BUSNUMBER and SPDRP_BUSNUMBER to get the BDF. scanning currently supports types RTE_KDRV_NONE. Signed-off-by: Tal Shnaiderman --- drivers/bus/pci/windows/pci.c

[dpdk-dev] [PATCH v8 6/9] drivers: fix incorrect meson import folder for Windows

2020-06-22 Thread talshn
From: Tal Shnaiderman import library (/IMPLIB) in meson.build should use the 'drivers' and not 'libs' folder. The error is: fatal error LNK1149: output filename matches input filename. The fix uses the correct folder. Fixes: 5ed3766981 ("drivers: process shared link dependencies as for libs")

[dpdk-dev] [PATCH v8 9/9] build: generate version.map file for MinGW on Windows

2020-06-22 Thread talshn
From: Tal Shnaiderman The MinGW build for Windows has special cases where exported function contain additional prefix: __emutls_v.per_lcore__* To avoid adding those prefixed functions to the version.map file the map_to_def.py script was modified to create a map file for MinGW with the needed ch

[dpdk-dev] [PATCH v8 2/9] pci: use OS generic memory mapping functions

2020-06-22 Thread talshn
From: Tal Shnaiderman Changing all of PCIs Unix memory mapping to the new memory allocation API wrapper. Change all of PCI mapping function usage in bus/pci to support the new API. Signed-off-by: Tal Shnaiderman --- drivers/bus/pci/bsd/pci.c | 2 +- drivers/bus/pci/linux/pci_uio.c

[dpdk-dev] [PATCH v8 4/9] pci: fix format warning on Windows

2020-06-22 Thread talshn
From: Tal Shnaiderman the struct rte_pci_addr defines domain as uint32_t variable however the PCI_PRI_FMT macro used for logging the struct sets the format of domain to uint16_t. The mismatch causes the following warning messages in Windows clang build: format specifies type 'unsigned short' bu

[dpdk-dev] [PATCH v8 1/9] eal: move OS common functions to single file

2020-06-22 Thread talshn
From: Tal Shnaiderman Move common functions between Unix and Windows to eal_common_config.c. Those functions are getter functions for IOVA, configuration, Multi-process. Move rte_config, internal_config, early_mem_config and runtime_dir to be defined in the common file with getter functions. R

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Maxime Coquelin
Hi, On 6/21/20 8:20 AM, Matan Azrad wrote: > Hi Maxime > > From: Maxime Coquelin: >> Hi Matan, >> >> On 6/19/20 3:11 PM, Matan Azrad wrote: >>> Hi Maxime >>> >>> Thanks for the fast review. >>> This is first version, let's review it carefully to be sure it is correct. >>> @Xiao Wang, it will be g

Re: [dpdk-dev] [PATCH v1 1/4] vhost: support host notifier queue configuration

2020-06-22 Thread Maxime Coquelin
On 6/21/20 8:26 AM, Matan Azrad wrote: > Hi Maxime > > From: Maxime Coquelin: >> On 6/19/20 3:28 PM, Matan Azrad wrote: >>> >>> >>> From: Maxime Coquelin: On 6/18/20 6:28 PM, Matan Azrad wrote: > As an arrangement to per queue operations in the vDPA device it is > needed to change

[dpdk-dev] [PATCH v4 1/2] ethdev: fix data room size verification in Rx queue setup

2020-06-22 Thread Wei Hu (Xavier)
In the rte_eth_rx_queue_setup API function, the local variable named mbp_buf_size, which is the data room size of the input parameter mp, is checked to guarantee that each memory chunck used for net device in the mbuf is bigger than the min_rx_bufsize. But if mbp_buf_size is less than RTE_PKTMBUF_H

[dpdk-dev] [PATCH v4 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-22 Thread Wei Hu (Xavier)
Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver does not support certain VLAN hardware offloads and does not check for it, the hardware setting will not change, bu

[dpdk-dev] [PATCH v4 0/2] ethdev: minor bugfixes

2020-06-22 Thread Wei Hu (Xavier)
This series are minor bugfixes for rte_ethdev.c. Wei Hu (Xavier) (2): ethdev: fix data room size verification in Rx queue setup ethdev: fix VLAN offloads set if no relative capabilities drivers/net/dpaa2/dpaa2_ethdev.c | 12 +++- drivers/net/enic/enic_ethdev.c |

[dpdk-dev] small error in rte_eth_bond_api.c

2020-06-22 Thread Анатолий Дубинский
Hello! I've found a small error in .../drivers/net/bonding/rte_eth_bond_api.c : Func rte_eth_bond_create: ret = rte_vdev_init(name, devargs); if (ret) return -ENOMEM; So, we get ENOMEM error regardless of the actual error code. This code would be more applicable. ret = rte_vdev_init(name, devar

Re: [dpdk-dev] [PATCH v4 1/2] ethdev: fix data room size verification in Rx queue setup

2020-06-22 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 22-Jun-20 1:38 PM, Wei Hu (Xavier) wrote: In the rte_eth_rx_queue_setup API function, the local variable named mbp_buf_size, which is the data room size of the input parameter mp, is checked to guarantee that each memory chunck used for net device in the mbuf is bigge

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-22 Thread Sachin Saxena (OSS)
Acked-by: Sachin Saxena On 22-Jun-20 1:39 PM, Wei Hu (Xavier) wrote: Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver does not support certain VLAN hardware off

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Matan Azrad
From: Maxime Coquelin > Hi, > > On 6/21/20 8:20 AM, Matan Azrad wrote: > > Hi Maxime > > > > From: Maxime Coquelin: > >> Hi Matan, > >> > >> On 6/19/20 3:11 PM, Matan Azrad wrote: > >>> Hi Maxime > >>> > >>> Thanks for the fast review. > >>> This is first version, let's review it carefully to be

Re: [dpdk-dev] small error in rte_eth_bond_api.c

2020-06-22 Thread Wei Hu (Xavier)
Hi, Anatoly Dubinsky it looks you are right. Maybe you can send a patch to fix it. Thanks, Xavier On 2020/6/20 2:12, Анатолий Дубинский wrote: Hello! I've found a small error in .../drivers/net/bonding/rte_eth_bond_api.c : Func rte_eth_bond_create: ret = rte_vdev_init(name, devargs); if (ret

Re: [dpdk-dev] [PATCH] net/sfc: reap Tx descriptors on transmit at least once

2020-06-22 Thread Ferruh Yigit
On 6/19/2020 11:25 AM, Andrew Rybchenko wrote: > Improve cache hit and increase packet rate on benchmarks. > > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix CPU cycles per pkt stats on transmit modes

2020-06-22 Thread Phil Yang
> -Original Message- > From: Honnappa Nagarahalli > Sent: Monday, June 22, 2020 11:40 AM > To: Phil Yang ; dev@dpdk.org > Cc: ferruh.yi...@intel.com; maxime.coque...@redhat.com; Ruifeng Wang > ; nd ; sta...@dpdk.org; > david.march...@redhat.com; Honnappa Nagarahalli > ; nd > Subject: RE:

Re: [dpdk-dev] [PATCH v2] bus/pci: fix VF bus error for memory access

2020-06-22 Thread Burakov, Anatoly
On 22-Jun-20 7:30 AM, Haiyue Wang wrote: To fix CVE-2020-12888, the linux vfio-pci module will invalidate mmaps and block MMIO access on disabled memory, it will send a SIGBUS to the application: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=abafbc551fddede3e0a08de

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Maxime Coquelin
On 6/22/20 10:41 AM, Matan Azrad wrote: >> The issue is if you only check ready state only before and after the message >> affecting the ring is handled, it can be ready at both stages, while the >> rings >> have changed and state change callback should have been called. > But in this version I

[dpdk-dev] [PATCH v3] app/testpmd: fix CPU cycles per pkt stats on transmit modes

2020-06-22 Thread Phil Yang
In txonly and flowgen forwarding mode, calculating CPU per packets with total received packets is not accurate. Use total transmitted packets for these cases. The error output under txonly mode: testpmd> show fwd stats all -- Forward statistics for port 0 ---

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-06-22 Thread Wangxiaoyun (Cloud)
Acked-by: Xiaoyun wang 在 2020/6/22 16:09, Wei Hu (Xavier) 写道: Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver does not support certain VLAN hardware offloads a

  1   2   3   >