[dpdk-dev] [PATCH] net/ice: fix FDIR rule duplication check failure

When FDIR filter detects duplicated rule and then returns EEXIST, ice flow will capture this error and return immediately. Fixes: 4e27d3ed02bd ("net/ice: fix flow API framework") Cc: ying.a.w...@intel.com Signed-off-by: Yahui Cao --- drivers/net/ice/ice_generic_flow.c | 7 ++- 1 file change

[dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

memcpy() source and destination areas must not overlap and equal pointers is the case which is really met, so handle it. Fixes: 68b931bff287 ("ethdev: eliminate interim variable") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- slave_configure() in drivers/net/bonding calls rte_eth_dev_c

Re: [dpdk-dev] Intel X710, DPDK with SFP - FTLX8574D3BCV-IT link down

Adding Beilei Xing and Qi Zhang Thanks and Regards, Amit On Mon, Nov 18, 2019 at 2:39 PM amit shukla wrote: > Hello, > > Using a X710 based NIC with Intel SFP - FTLX8574D3BCV-IT on a bare-metal > setup, I came across the following issue on the i40e PMD: > > When Intel SFP - FTLX8574D3BCV-IT is

[dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

Hello, I'm trying to explore pktgen and dpdk-pktgen with Jumbo frame. I'm using ubuntu-18.04 system where pktgen is a kernel module and I don't have any provision to set it for Jumbo frame. Can you please suggest how to configure Jumbo frame in pktgen ? In dpdk source code, I've modified RTE_MBU

[dpdk-dev] [PATCH] net/bonding: do not inherit slave device configuration

Bonding device should control bonded devices configuration. Also avoid usage of slave's data->dev_conf. Fixes: 2efb58cbab6e ("bond: new link bonding library") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/bonding/rte_eth_bond_pmd.c | 24 1 file ch

Re: [dpdk-dev] [dpdk-announce] FOSDEM 2020 Software Defined Networking Devroom CFP

Folks, Just a gentle reminder the CFP closes on November the 24th. Thanks, Ray K On 17/10/2019 19:36, Ray Kinsella wrote: > We are pleased to announce the Call for Participation for the FOSDEM > 2020 Software Defined Networking devroom! > > Important dates: > > Nov 24th 2019 Submission dead

[dpdk-dev] [PATCH] net/mlx5: fix port action create routine

To support LAG configurations the mlx5dv_dr_action_create_dest_ib_port() should be called instead of mlx5dv_dr_action_create_dest_vport(). Fixes: f07341e7aed3 ("net/mlx5: update source and destination vport translations") Signed-off-by: Viacheslav Ovsiienko Acked-by: Ori Kam --- drivers/net/m

Re: [dpdk-dev] [PATCH v3 1/6] lib/eal: implement the family of rte bitoperation APIs

Hi Morten, > -Original Message- > From: Morten Brørup > Sent: Monday, November 18, 2019 6:52 PM > To: Joyce Kong (Arm Technology China) ; > dev@dpdk.org > Cc: nd ; tho...@monjalon.net; jer...@marvell.com; > step...@networkplumber.org; david.march...@redhat.com; Honnappa > Nagarahalli ; Ga

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

On 11/8/19 4:30 PM, Thomas Monjalon wrote: > 08/11/2019 14:27, Andrew Rybchenko: >> On 11/8/19 4:17 PM, Thomas Monjalon wrote: >>> 08/11/2019 13:00, Andrew Rybchenko: On 11/8/19 2:03 PM, Thomas Monjalon wrote: > 08/11/2019 11:42, Andrew Rybchenko: >> On 11/8/19 1:28 PM, Thomas Monjalon

Re: [dpdk-dev] [PATCH] net/ice: fix FDIR rule duplication check failure

> -Original Message- > From: Cao, Yahui > Sent: Wednesday, November 20, 2019 12:01 AM > To: Yang, Qiming ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhang, Qi Z ; Cao, Yahui > ; Ye, Xiaolong ; Wang, Ying A > > Subject: [PATCH] net/ice: fix FDIR rule duplication check failure > > When FDIR fi

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

18/11/2019 11:02, Shahaf Shuler: > struct rte_pktmbuf_pool_private { > uint16_t mbuf_data_room_size; /**< Size of data space in each mbuf. */ > uint16_t mbuf_priv_size; /**< Size of private area in each mbuf. */ > + uint32_t reserved; /**< reserved for future use. */ Maybe si

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

19/11/2019 10:24, Andrew Rybchenko: > On 11/8/19 4:30 PM, Thomas Monjalon wrote: > > 08/11/2019 14:27, Andrew Rybchenko: > >> On 11/8/19 4:17 PM, Thomas Monjalon wrote: > >>> 08/11/2019 13:00, Andrew Rybchenko: > On 11/8/19 2:03 PM, Thomas Monjalon wrote: > > 08/11/2019 11:42, Andrew Rybch

Re: [dpdk-dev] [PATCH v2 1/3] test/event_crypto: fix missing IV value for AES algo

For series: Acked-by: abhinandan.guj...@intel.com I noticed that these patches have issue with "Intel-compilation". Hope, it will be taken care before merging. > -Original Message- > From: Hemant Agrawal > Sent: Thursday, November 7, 2019 2:31 PM > To: dev@dpdk.org > Cc: jerinjac...@gma

Re: [dpdk-dev] Backporting rte_intr_ack

14/10/2019 17:55, David Marchand: > The api rte_intr_ack that has been introduced to fix a race condition > observed with (at least) qede drivers/hw. > This is an experimental api in master but it still fixes a problem, so > I'd like to see this in stable branches. This is more a driver interface

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

On 11/19/19 12:50 PM, Thomas Monjalon wrote: > 19/11/2019 10:24, Andrew Rybchenko: >> On 11/8/19 4:30 PM, Thomas Monjalon wrote: >>> 08/11/2019 14:27, Andrew Rybchenko: On 11/8/19 4:17 PM, Thomas Monjalon wrote: > 08/11/2019 13:00, Andrew Rybchenko: >> On 11/8/19 2:03 PM, Thomas Monjal

[dpdk-dev] [PATCH] doc: update git fixline alias with cc to stable

Update git fixline alias to add sta...@dpdk.org to Cc Signed-off-by: Reshma Pattan --- doc/guides/contributing/patches.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst index 214030346..fa19d2eb5 100

Re: [dpdk-dev] [PATCH 1/2] ethdev: add flow action type update as an offload

19/11/2019 11:59, Andrew Rybchenko: > On 11/19/19 12:50 PM, Thomas Monjalon wrote: > > 19/11/2019 10:24, Andrew Rybchenko: > >> On 11/8/19 4:30 PM, Thomas Monjalon wrote: > >>> 08/11/2019 14:27, Andrew Rybchenko: > On 11/8/19 4:17 PM, Thomas Monjalon wrote: > > 08/11/2019 13:00, Andrew Ryb

Re: [dpdk-dev] [PATCH] doc: update git fixline alias with cc to stable

On Tue, Nov 19, 2019 at 11:03:57AM +, Reshma Pattan wrote: > Update git fixline alias to add sta...@dpdk.org to Cc > > Signed-off-by: Reshma Pattan > --- > doc/guides/contributing/patches.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/guides/contributing/pa

[dpdk-dev] [PATCH dpdk-dev] net/mlx5: allow to match TTL option

From: Tonghao Zhang For example, Open vSwitch may offload tunnel flows to hardware and the tunnel TTL option is 64 and its mask is 0xff as default. Allow to match IPv4 TTL option. Signed-off-by: Tonghao Zhang --- drivers/net/mlx5/mlx5_flow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/

Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header

Hello Matan and Slava, Thanks for your quick response. 1. What you were saying is correct. When I create flow with dst mac 10:22:33:44:55:66 instead of 11:22:33:44:55:66, received packets are queued to specified queue. Thanks for your advice! Q1. What is the problem with broadcast/multicast ad

[dpdk-dev] [PATCH 2/3] ethdev: remove deprecation notice about RSS hash offload

The offload was added, but the deprecation notice was not removed. Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/doc/guides/rel

[dpdk-dev] [PATCH 3/3] ethdev: improve flow mark Rx offload deprecation notice

The deprecation notice is required since it adds more requirements when RTE flow mark and flag actions may be used and require changes in applications. Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) d

[dpdk-dev] [PATCH 1/3] ethdev: remove deprecation notice for packet type set

The functionality is added, but the deprecation notice is not removed. Fixes: 5d4813acda2c ("ethdev: add packet type range function") Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst | 15 --- 1 file changed, 15 deletions(-) diff --git a/doc/guides/rel_notes

[dpdk-dev] [PATCH v2 2/3] ethdev: remove deprecation notice about RSS hash offload

The offload was added, but the deprecation notice was not removed. Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") Signed-off-by: Andrew Rybchenko --- v2: - 'offloads are' -> 'offload is' in the last sentence doc/guides/rel_notes/deprecation.rst | 7 +++ 1 file changed,

[dpdk-dev] [PATCH v2 1/3] ethdev: remove deprecation notice for packet type set

The functionality is added, but the deprecation notice is not removed. Fixes: 5d4813acda2c ("ethdev: add packet type range function") Signed-off-by: Andrew Rybchenko --- v2: - none doc/guides/rel_notes/deprecation.rst | 15 --- 1 file changed, 15 deletions(-) diff --git a/doc/gui

[dpdk-dev] [PATCH v2 3/3] ethdev: improve flow mark Rx offload deprecation notice

The deprecation notice is required since it adds more requirements when RTE flow mark and flag actions may be used and require changes in applications. Signed-off-by: Andrew Rybchenko --- v2: - rebase after changes in the previous patch doc/guides/rel_notes/deprecation.rst | 14 +++---

Re: [dpdk-dev] [PATCH] kni: reduce interface name size

On 11/15/2019 4:23 PM, Stephen Hemminger wrote: > On Fri, 15 Nov 2019 12:41:07 +0100 > Michael Pfeiffer wrote: > >> The name in rte_kni_device_info is passed to the kernel, which allows >> interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a >> longer name currently trigger a ke

[dpdk-dev] [PATCH v6 0/1] Fix secondary process issue

This patch removes rte_intr_callback_register from secondary process branch. -- V5->V6: - Fix secondary process issue V4->V5: - Fix code style check issue - Fix l2_len calculate errs for TSO - Replace mbuf alloc function with initialized V3->v4: - Fix receive performance code review

[dpdk-dev] [PATCH v6 1/1] net/hinic: fix secondary process issue

The secondary process does not need to register interrupt handle, remove rte_intr_callback_register from secondary process branch. Fixes: 06b6a81bbabf ("net/hinic: document missing features") Signed-off-by: Xiaoyun wang --- drivers/net/hinic/hinic_pmd_ethdev.c | 10 +++--- 1 file changed, 3

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: do not inherit slave device configuration

On 11/19/2019 9:03 AM, Andrew Rybchenko wrote: > Bonding device should control bonded devices configuration. > > Also avoid usage of slave's data->dev_conf. > > Fixes: 2efb58cbab6e ("bond: new link bonding library") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybchenko > --- > drivers/net/

Re: [dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: > memcpy() source and destination areas must not overlap and equal > pointers is the case which is really met, so handle it. Agree providing same config as input can cause problem with current implementation, but it is the limitation of the memcpy, th

[dpdk-dev] minimum supported meson version

Bruce, root meson.build declares 0.47.1, but I see the following during build: WARNING: Project specifies a minimum meson_version '>= 0.47.1' but uses features which were added in newer versions:  * 0.48.0: {'console arg in custom_target'}  * 0.50.0: {'install arg in configure_file'} Will above

Re: [dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/19 3:24 PM, Ferruh Yigit wrote: > On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: >> memcpy() source and destination areas must not overlap and equal >> pointers is the case which is really met, so handle it. > Agree providing same config as input can cause problem with current > implementa

[dpdk-dev] [PATCH] net/mlx5: fix hairpin split detection

When creating a flow, the flow is checked if it should be split into 2 flows based on the queue/rss acton. If the RSS action with given without any queues, it will result in crash due to the fact that the function checks the queue type. This commit fixes this issue by checking if the rss action i

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: do not inherit slave device configuration

On 11/19/19 3:18 PM, Ferruh Yigit wrote: > On 11/19/2019 9:03 AM, Andrew Rybchenko wrote: >> Bonding device should control bonded devices configuration. >> >> Also avoid usage of slave's data->dev_conf. >> >> Fixes: 2efb58cbab6e ("bond: new link bonding library") >> Cc: sta...@dpdk.org >> >> Signed

Re: [dpdk-dev] minimum supported meson version

On Tue, 2019-11-19 at 15:27 +0300, Andrew Rybchenko wrote: > Bruce, > > root meson.build declares 0.47.1, but I see the following during > build: > > WARNING: Project specifies a minimum meson_version '>= 0.47.1' but > uses > features which were added in newer versions: > * 0.48.0: {'console arg

Re: [dpdk-dev] minimum supported meson version

On 11/19/19 3:40 PM, Luca Boccassi wrote: > On Tue, 2019-11-19 at 15:27 +0300, Andrew Rybchenko wrote: >> Bruce, >> >> root meson.build declares 0.47.1, but I see the following during >> build: >> >> WARNING: Project specifies a minimum meson_version '>= 0.47.1' but >> uses >> features which were a

[dpdk-dev] [PATCH] build: remove unneeded meson option

The meson option has been missed when removing this code. Fixes: 8e35792c5325 ("eal: remove dead code on NUMA node detection") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- meson_options.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/meson_options.txt b/meson_options.txt index

Re: [dpdk-dev] [PATCH] net/bnxt: fix Rx queue pool calculation

On 11/18/2019 8:41 PM, Ajit Khaparde wrote: > > > On Mon, Nov 18, 2019 at 12:32 PM Ajit Khaparde > wrote: > > When the number of Rx queues requested by the application is less than > the number of pools calculated, we end up calling HWRM_VNIC_ALLOC wit

[dpdk-dev] [PATCH] net/mlx5: fix assert in tx inline settings ajustment

Assert condition is fixed to not alert for the case when multi-packet write is not supported/engaged at all. Fixes: b53cd86965a1 ("net/mlx5: adjust inline setting for large Tx queue sizes") Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_txq.c | 3 ++- 1 file changed, 2 insertions

Re: [dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/2019 12:36 PM, Andrew Rybchenko wrote: > On 11/19/19 3:24 PM, Ferruh Yigit wrote: >> On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: >>> memcpy() source and destination areas must not overlap and equal >>> pointers is the case which is really met, so handle it. >> Agree providing same confi

Re: [dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/19 4:19 PM, Ferruh Yigit wrote: > On 11/19/2019 12:36 PM, Andrew Rybchenko wrote: >> On 11/19/19 3:24 PM, Ferruh Yigit wrote: >>> On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: memcpy() source and destination areas must not overlap and equal pointers is the case which is really m

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/2019 1:19 PM, Ferruh Yigit wrote: > On 11/19/2019 12:36 PM, Andrew Rybchenko wrote: >> On 11/19/19 3:24 PM, Ferruh Yigit wrote: >>> On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: memcpy() source and destination areas must not overlap and equal pointers is the case which is really

[dpdk-dev] rte_eth_dev_stop and rte_eth_dev_close are still void

Thomas, Ferruh, the following deprecation notice is still in place: * ethdev: Update API functions returning ``void`` to return ``int`` with   negative errno values to indicate various error conditions (e.g.   invalid port ID, unsupported operation, failed operation):   - ``rte_eth_dev_stop``  

[dpdk-dev] [PATCH v2] net/i40e: always re-program promiscuous mode on VF interface

During a kernel PF reset, this event is propagated to the VF. The DPDK VF PMD will execute the reset task before the PF is done with his. This results in the admin queue message not being responded to leaving the port in "promiscuous" mode. This patch makes sure the promiscuous mode is configured

Re: [dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global

08/11/2019 17:25, Anatoly Burakov: > From: Marcin Baran > > As per new ABI policy, all of the libraries are now versioned using > one global ABI version. Changes in this patch implement the > necessary steps to enable that. For the history, would be nice to describe the "why" of each change here

Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state after VF reset

On 13 Nov 2019, at 2:14, Zhang, Xiao wrote: -Original Message- From: Eelco Chaudron [mailto:echau...@redhat.com] Sent: Tuesday, November 12, 2019 7:09 PM To: Zhang, Xiao Cc: Zhang, Qi Z ; dev@dpdk.org; Xing, Beilei Subject: Re: [dpdk-dev] [PATCH] net/i40e: force promiscuous state a

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/19 4:37 PM, Ferruh Yigit wrote: > On 11/19/2019 1:19 PM, Ferruh Yigit wrote: >> On 11/19/2019 12:36 PM, Andrew Rybchenko wrote: >>> On 11/19/19 3:24 PM, Ferruh Yigit wrote: On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: > memcpy() source and destination areas must not overlap and

Re: [dpdk-dev] [PATCH v7 02/10] buildtools: add script for updating symbols abi version

08/11/2019 17:25, Anatoly Burakov: > From: Pawel Modrak > > Add a script that automatically merges all stable ABI's under one > ABI section with the new version, while leaving experimental > section exactly as it is. > > Signed-off-by: Pawel Modrak > Signed-off-by: Anatoly Burakov > Acked-by:

Re: [dpdk-dev] [PATCH] build: remove unneeded meson option

On Tue, Nov 19, 2019 at 01:59:23PM +0100, David Marchand wrote: > The meson option has been missed when removing this code. > > Fixes: 8e35792c5325 ("eal: remove dead code on NUMA node detection") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v2] crypto/openssl: support SG for inplace buffers

Hi Anoob, Any more comments on this patch? If not please Ack. Thanks, Akhil > > As per current support, Scatter Gather is only supported > for out of place input and output buffers. > This patch add support for Scatter Gather for inplace buffers. > > Signed-off-by: Akhil Goyal > ---

Re: [dpdk-dev] [PATCH] doc: update git fixline alias with cc to stable

On 19/11/2019 11:22, Bruce Richardson wrote: > On Tue, Nov 19, 2019 at 11:03:57AM +, Reshma Pattan wrote: >> Update git fixline alias to add sta...@dpdk.org to Cc >> >> Signed-off-by: Reshma Pattan >> --- >> doc/guides/contributing/patches.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 dele

Re: [dpdk-dev] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: > memcpy() source and destination areas must not overlap and equal > pointers is the case which is really met, so handle it. > > Fixes: 68b931bff287 ("ethdev: eliminate interim variable") > Cc: sta...@dpdk.org > > Signed-off-by: Andrew Rybchenko Re

Re: [dpdk-dev] [PATCH v2 1/3] ethdev: remove deprecation notice for packet type set

On 11/19/2019 12:12 PM, Andrew Rybchenko wrote: > The functionality is added, but the deprecation notice is not > removed. > > Fixes: 5d4813acda2c ("ethdev: add packet type range function") > > Signed-off-by: Andrew Rybchenko Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2 2/3] ethdev: remove deprecation notice about RSS hash offload

On 11/19/2019 12:12 PM, Andrew Rybchenko wrote: > The offload was added, but the deprecation notice was not removed. > > Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") > > Signed-off-by: Andrew Rybchenko Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH] ci: add 32-bit travis builds

Add a travis job to build for 32-bit on 64-bit systems to catch additional build errors, for example, incorrect use of printf specifiers with uint64_t types. Signed-off-by: Bruce Richardson --- .ci/linux-build.sh | 5 + .travis.yml| 10 ++ 2 files changed, 15 insertions(+)

Re: [dpdk-dev] [PATCH v6 1/1] net/hinic: fix secondary process issue

On 11/19/2019 12:31 PM, Xiaoyun wang wrote: > The secondary process does not need to register interrupt handle, > remove rte_intr_callback_register from secondary process branch. > > Fixes: 06b6a81bbabf ("net/hinic: document missing features") I can see above patch documents the "Multiprocess awa

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

Tuesday, November 19, 2019 11:33 AM, Thomas Monjalon: > Subject: Re: [PATCH] mbuf: extend pktmbuf pool private structure > > 18/11/2019 11:02, Shahaf Shuler: > > struct rte_pktmbuf_pool_private { > > uint16_t mbuf_data_room_size; /**< Size of data space in each > mbuf. */ > > uint16_t mbu

[dpdk-dev] [PATCH] net/mlx5: fix L3 encapsulation flow validation

In order to configure L3 encapsulation\decapsulation flow to mlx5 devices, 2 actions should be added to the flow actions list: RTE_FLOW_ACTION_TYPE_RAW_DECAP and RTE_FLOW_ACTION_TYPE_RAW_ENCAP. One of the validations for this scenario is to check that modify actions is not done before the L3 decap

Re: [dpdk-dev] [PATCH v7 02/10] buildtools: add script for updating symbols abi version

On 19-Nov-19 2:01 PM, Thomas Monjalon wrote: 08/11/2019 17:25, Anatoly Burakov: From: Pawel Modrak Add a script that automatically merges all stable ABI's under one ABI section with the new version, while leaving experimental section exactly as it is. Signed-off-by: Pawel Modrak Signed-off-b

Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: avoid undefined behaviour on configuration copying

On 11/19/2019 2:57 PM, Ferruh Yigit wrote: > On 11/19/2019 8:22 AM, Andrew Rybchenko wrote: >> memcpy() source and destination areas must not overlap and equal >> pointers is the case which is really met, so handle it. >> >> Fixes: 68b931bff287 ("ethdev: eliminate interim variable") >> Cc: sta...@d

Re: [dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global

On 19-Nov-19 1:53 PM, Thomas Monjalon wrote: 08/11/2019 17:25, Anatoly Burakov: From: Marcin Baran As per new ABI policy, all of the libraries are now versioned using one global ABI version. Changes in this patch implement the necessary steps to enable that. For the history, would be nice to

Re: [dpdk-dev] [PATCH] net/mlx5: fix port action create routine

Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Tuesday, November 19, 2019 11:16 AM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix port action create routine > > To support LAG configurations the mlx5dv_dr_action_create

Re: [dpdk-dev] [PATCH] net/mlx5: fix assert in tx inline settings ajustment

Hi, > -Original Message- > From: Viacheslav Ovsiienko > Sent: Tuesday, November 19, 2019 3:13 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix assert in tx inline settings ajustment > > Assert condition is fixed to not alert for the

Re: [dpdk-dev] [PATCH] net/mlx5: fix hairpin split detection

Hi, > -Original Message- > From: dev On Behalf Of Ori Kam > Sent: Tuesday, November 19, 2019 2:39 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; Ori Kam > Subject: [dpdk-dev] [PATCH] net/mlx5: fix hairpin split detection > > When creating a flow, the flow

Re: [dpdk-dev] [PATCH v7 02/10] buildtools: add script for updating symbols abi version

19/11/2019 16:38, Burakov, Anatoly: > On 19-Nov-19 2:01 PM, Thomas Monjalon wrote: > > 08/11/2019 17:25, Anatoly Burakov: > >> From: Pawel Modrak > >> > >> Add a script that automatically merges all stable ABI's under one > >> ABI section with the new version, while leaving experimental > >> secti

Re: [dpdk-dev] [PATCH] ci: add 32-bit travis builds

Bruce Richardson writes: > Add a travis job to build for 32-bit on 64-bit systems to catch additional > build errors, for example, incorrect use of printf specifiers with uint64_t > types. > > Signed-off-by: Bruce Richardson > --- Nice! Acked-by: Aaron Conole

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

On Tue, 19 Nov 2019 15:23:50 + Shahaf Shuler wrote: > Tuesday, November 19, 2019 11:33 AM, Thomas Monjalon: > > Subject: Re: [PATCH] mbuf: extend pktmbuf pool private structure > > > > 18/11/2019 11:02, Shahaf Shuler: > > > struct rte_pktmbuf_pool_private { > > > uint16_t mbuf_data_room

Re: [dpdk-dev] [PATCH 20.02] net/virtio-user: do not close tap when disabling queue pairs

On Tue, 19 Nov 2019 14:29:48 +0800 Tiwei Bie wrote: > -static int > +int > +vhost_kernel_tap_attach_queue(int fd) > +{ > + struct ifreq ifr; > + > + memset(&ifr, 0, sizeof(ifr)); > + ifr.ifr_flags = IFF_ATTACH_QUEUE; > + return ioctl(fd, TUNSETQUEUE, (void *)&ifr); > +} > + > +int

Re: [dpdk-dev] [PATCH v7 03/10] buildtools: add ABI update shell script

08/11/2019 17:25, Anatoly Burakov: > In order to facilitate mass updating of version files, add a shell > script that recurses into lib/ and drivers/ directories and calls > the ABI version update script. > > Signed-off-by: Anatoly Burakov > Acked-by: Bruce Richardson > --- /dev/null > +++ b/bui

Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

Nirmal, Here are the changes that I've been using to allow jumbo frames with dpdk-19.08 and pktgen-19.10.0: diff -r default/dpdk-19.08/lib/librte_mbuf/rte_mbuf.h jumbo/dpdk-19.08/lib/librte_mbuf/rte_mbuf.h 462c462 < #define RTE_MBUF_DEFAULT_DATAROOM 2048 --- > #define RTE_MBUF

Re: [dpdk-dev] [PATCH v7 10/10] buildtools: add ABI versioning check script

08/11/2019 17:25, Anatoly Burakov: > From: Marcin Baran > +echo "correct version (ABI_VER/ABI_VER+1/EXPERIMENTAL)" I don't get why a symbol could be versioned for the next ABI? Assuming we upgrade the ABI version at the beginning of the cycle, every symbols should have the same version, right

[dpdk-dev] [PATCH 0/3] bnxt patches

Couple of bug fixes and an update to the release notes. Please apply. Ajit Khaparde (2): net/bnxt: fix to ignore resource qcaps error with older FW doc: update release notes for Broadcom PMD Rahul Gupta (1): net/bnxt: fix jumbo frame configuration in firmware doc/guides/rel_notes/release_

[dpdk-dev] [PATCH 3/3] doc: update release notes for Broadcom PMD

Update release doc briefly describing updates to bnxt PMD for 19.11 release. Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_19_11.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst in

[dpdk-dev] [PATCH 1/3] net/bnxt: fix to ignore resource qcaps error with older FW

On some old versions of FW, bnxt_hwrm_func_resc_qcaps can return an error. This is because the command was not implemented completely in FW till the subsequent version. Ignore the error and continue with the driver initialization. Fixes: edafb57ba4a1 ("net/bnxt: fix VF resource allocation") Cc: st

[dpdk-dev] [PATCH 2/3] net/bnxt: fix jumbo frame configuration in firmware

From: Rahul Gupta In order to prevent reconfiguration of firmware resources for every MTU change, configure FW with max MTU value using hwrm_func_cfg to support all frame sizes. There is no need to overwrite the driver level MTU variable data->mtu with the FW MTU. Fixes: 905cd45ce30e ("net/bnxt:

Re: [dpdk-dev] [PATCH 0/3] bnxt patches

On Tue, Nov 19, 2019 at 10:57 AM Ajit Khaparde wrote: > Couple of bug fixes and an update to the release notes. > Please apply. > > Ajit Khaparde (2): > net/bnxt: fix to ignore resource qcaps error with older FW > doc: update release notes for Broadcom PMD > > Rahul Gupta (1): > net/bnxt: f

Re: [dpdk-dev] [PATCH v2] app/testpmd: report invalid command line parameter

On 11/18/2019 8:18 AM, Ferruh Yigit wrote: On 11/18/2019 3:37 PM, David Marchand wrote: We currently do not check that a non option string has been passed to testpmd. Example: $ ./master/app/testpmd --no-huge -m 512 --vdev net_null0 \ --vdev net_null1 -- -i nb-cores=2 --total-num-mbuf

Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

John, Marko, It seems we are missing documentation about enabling Jumbo frames in an application, and possibly an example of using the rte_eth_dev_info->max_mtu. Med venlig hilsen / kind regards - Morten Brørup > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size

On Tue, Nov 12, 2019 at 3:50 PM Xueming Li wrote: > > When resize a memory with next element, the original element size grows. > If the orginal element has padding, the real inner element size didn't > grow as well and this causes trailer verification failure when malloc > debug enabled. I did no

Re: [dpdk-dev] [PATCH 1/2] mempool: use actual IOVA addresses when populating

On Thu, Nov 14, 2019 at 2:58 PM Anatoly Burakov wrote: > > Currently, when mempool is being populated, we get IOVA address > of every segment using rte_mem_virt2iova(). This works for internal > memory, but does not really work for external memory, and does not > work on platforms which return RTE

Re: [dpdk-dev] [PATCH] kni: reduce interface name size

On Tue, Nov 19, 2019 at 1:13 PM Ferruh Yigit wrote: > > On 11/15/2019 4:23 PM, Stephen Hemminger wrote: > > On Fri, 15 Nov 2019 12:41:07 +0100 > > Michael Pfeiffer wrote: > > > >> The name in rte_kni_device_info is passed to the kernel, which allows > >> interface names with at most 16 bytes (IFN

Re: [dpdk-dev] [PATCH v2] kni: reduce interface name size

On Fri, Nov 15, 2019 at 2:30 PM Ferruh Yigit wrote: > On 11/15/2019 1:03 PM, Michael Pfeiffer wrote: > > The name in rte_kni_device_info is passed to the kernel, which allows > > interface names with at most 16 bytes (IFNAMSIZ). rte_kni_alloc with a > > longer name currently trigger a kernel BUG i

Re: [dpdk-dev] [PATCH] build: remove unneeded meson option

On Tue, Nov 19, 2019 at 3:06 PM Bruce Richardson wrote: > > On Tue, Nov 19, 2019 at 01:59:23PM +0100, David Marchand wrote: > > The meson option has been missed when removing this code. > > > > Fixes: 8e35792c5325 ("eal: remove dead code on NUMA node detection") > > Cc: sta...@dpdk.org > > > > Sig

Re: [dpdk-dev] [PATCH v2 1/2] lib: fix log typos

On Wed, Nov 13, 2019 at 5:11 PM Kevin Traynor wrote: > > Fix these as they are user visible. Found with codespell. > > Fixes: bacaa2754017 ("eal: add channel for multi-process communication") > Fixes: f05e26051c15 ("eal: add IPC asynchronous request") > Fixes: 0cbce3a167f1 ("vfio: skip DMA map fai

Re: [dpdk-dev] [PATCH] ci: add 32-bit travis builds

On Tue, Nov 19, 2019 at 5:06 PM Aaron Conole wrote: > > Bruce Richardson writes: > > > Add a travis job to build for 32-bit on 64-bit systems to catch additional > > build errors, for example, incorrect use of printf specifiers with uint64_t > > types. > > > > Signed-off-by: Bruce Richardson > A

Re: [dpdk-dev] [PATCH v7 05/10] lpm: remove deprecated code

On Fri, Nov 8, 2019 at 5:25 PM Anatoly Burakov wrote: > > From: Marcin Baran > > Remove code for old ABI versions ahead of ABI version bump. > > Signed-off-by: Marcin Baran > Signed-off-by: Anatoly Burakov > Acked-by: Bruce Richardson > --- > > Notes: > v2: > - Moved this to before ABI

Re: [dpdk-dev] [PATCH v7 04/10] timer: remove deprecated code

On Fri, Nov 8, 2019 at 5:25 PM Anatoly Burakov wrote: > > From: Marcin Baran > > Remove code for old ABI versions ahead of ABI version bump. > > Signed-off-by: Marcin Baran > Signed-off-by: Anatoly Burakov > Acked-by: Bruce Richardson > Acked-by: Erik Gabriel Carrillo > --- > > Notes: > v

Re: [dpdk-dev] [PATCH v7 09/10] build: change ABI version to 20.0

Reduced the Cc: list. On Fri, Nov 8, 2019 at 5:26 PM Anatoly Burakov wrote: > > From: Pawel Modrak > > Merge all vesions in linker version script files to DPDK_20.0. > > This commit was generated by running the following command: > > :~/DPDK$ buildtools/update-abi.sh 20.0 > I inspected the chan

Re: [dpdk-dev] [PATCH v2 1/2] lib: fix log typos

On 19/11/2019 21:18, David Marchand wrote: > On Wed, Nov 13, 2019 at 5:11 PM Kevin Traynor wrote: >> >> Fix these as they are user visible. Found with codespell. >> >> Fixes: bacaa2754017 ("eal: add channel for multi-process communication") >> Fixes: f05e26051c15 ("eal: add IPC asynchronous reques

[dpdk-dev] [PATCH] net/bnxt: fix vector receive check

Take DEV_RX_OFFLOAD_RSS_HASH into account when deciding whether vector mode receive can be enabled. Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities") Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 1 + 1 file changed, 1

Re: [dpdk-dev] [PATCH v7 09/10] build: change ABI version to 20.0

08/11/2019 17:25, Anatoly Burakov: > From: Pawel Modrak > > Merge all vesions in linker version script files to DPDK_20.0. > > This commit was generated by running the following command: > > :~/DPDK$ buildtools/update-abi.sh 20.0 > > Signed-off-by: Pawel Modrak > Signed-off-by: Anatoly Burako

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

19/11/2019 17:25, Stephen Hemminger: > On Tue, 19 Nov 2019 15:23:50 + > Shahaf Shuler wrote: > > > Tuesday, November 19, 2019 11:33 AM, Thomas Monjalon: > > > Subject: Re: [PATCH] mbuf: extend pktmbuf pool private structure > > > > > > 18/11/2019 11:02, Shahaf Shuler: > > > > struct rte_p

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] bus/pci: fix driver detach clear

12/11/2019 09:47, Matan Azrad: > When a rte_device is unplugged, the driver should be detached from the > device. Yes > The PCI detach driver operation wrongly didn't clear the driver from the > device structure what remain the device in probe state from the EAL > point of view. Are you aware of

Re: [dpdk-dev] [PATCH] net/bnxt: fix vector receive check

On Tue, Nov 19, 2019 at 2:12 PM Lance Richardson < lance.richard...@broadcom.com> wrote: > Take DEV_RX_OFFLOAD_RSS_HASH into account when deciding whether vector > mode receive can be enabled. > > Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload > capabilities") > Signed-off-by: Lance

[dpdk-dev] [PATCH] [pktgen] Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing

Current IPv6 functionality in pktgen is broken. This fix makes it so that IPv6 addresses are properly set when using the set, sequence, and save commands and that the IP header and UDP/TCP psuedo-header IPV6 addresses are properly set. To preserve the runtime commands, the `_atoip` function no l

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

On Tue, 19 Nov 2019 23:30:15 +0100 Thomas Monjalon wrote: > 19/11/2019 17:25, Stephen Hemminger: > > On Tue, 19 Nov 2019 15:23:50 + > > Shahaf Shuler wrote: > > > > > Tuesday, November 19, 2019 11:33 AM, Thomas Monjalon: > > > > Subject: Re: [PATCH] mbuf: extend pktmbuf pool private str

[dpdk-dev] [PATCH v2] [pktgen] Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing

Current IPv6 functionality in pktgen is broken. This fix makes it so that IPv6 addresses are properly set when using the set, sequence, and save commands and that the IP header and UDP/TCP psuedo-header IPV6 addresses are properly set. To preserve the runtime commands, the `_atoip` function no lon

[dpdk-dev] [PATCH v4] net/e1000: fix link status update

There is no need to judge the original link state, only update the data according to the current link state. It can maintain better robustness. In addition, this patch change the variable from link_check to link_up. Fixes: 80ba61115e77 ("net/e1000: use link status helper functions") Cc: sta...@dp

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size

> -Original Message- > From: David Marchand > Sent: Wednesday, November 20, 2019 4:47 AM > To: Xueming(Steven) Li ; Anatoly Burakov > > Cc: Asaf Penso ; dev ; dpdk stable > > Subject: Re: [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element > size > > On Tue, Nov 12, 2019 at 3:5

  1   2   >