On Tue, Nov 19, 2019 at 11:03:57AM +0000, Reshma Pattan wrote:
> Update git fixline alias to add sta...@dpdk.org to Cc
> 
> Signed-off-by: Reshma Pattan <reshma.pat...@intel.com>
> ---
>  doc/guides/contributing/patches.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/contributing/patches.rst 
> b/doc/guides/contributing/patches.rst
> index 214030346..fa19d2eb5 100644
> --- a/doc/guides/contributing/patches.rst
> +++ b/doc/guides/contributing/patches.rst
> @@ -255,7 +255,7 @@ Here are some guidelines for the body of a commit message:
>    You can generate the required lines using the following git alias, which 
> prints
>    the commit SHA and the author of the original code::
>  
> -     git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h 
> (\"%s\")%nCc: %ae'"
> +     git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h 
> (\"%s\")%nCc: %ae%nCc: sta...@dpdk.org'"
>  
>    The output of ``git fixline <SHA>`` must then be added to the commit 
> message::
>  

While a good idea, we don't always want to CC stable for all fixes, as
fixes for commits in the current release obviously don't need backports.
I suggest the stable maintainers comment on whether receiving these
additional patches would be a problem for them, or if their tooling is
sufficiency advanced for them to ignore these without issue...

/Bruce

Reply via email to