On 11/19/2019 12:31 PM, Xiaoyun wang wrote:
> The secondary process does not need to register interrupt handle,
> remove rte_intr_callback_register from secondary process branch.
>
> Fixes: 06b6a81bbabf ("net/hinic: document missing features")
I can see above patch documents the "Multiprocess aware" feature, but not sure
if this patch is a fix for that commit.
Is there any commit that introduces/cause the defect in the code?
> Signed-off-by: Xiaoyun wang <cloud.wangxiao...@huawei.com>
> ---
> drivers/net/hinic/hinic_pmd_ethdev.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/hinic/hinic_pmd_ethdev.c
> b/drivers/net/hinic/hinic_pmd_ethdev.c
> index ddfe082..803a39e 100644
> --- a/drivers/net/hinic/hinic_pmd_ethdev.c
> +++ b/drivers/net/hinic/hinic_pmd_ethdev.c
> @@ -2964,14 +2964,10 @@ static int hinic_func_init(struct rte_eth_dev
> *eth_dev)
>
> /* EAL is SECONDARY and eth_dev is already created */
> if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
> - rc = rte_intr_callback_register(&pci_dev->intr_handle,
> - hinic_dev_interrupt_handler,
> - (void *)eth_dev);
> - if (rc)
> - PMD_DRV_LOG(ERR, "Initialize %s failed in secondary
> process",
> - eth_dev->data->name);
> + PMD_DRV_LOG(INFO, "Initialize %s in secondary process",
> + eth_dev->data->name);
>
> - return rc;
> + return 0;
> }
>
> nic_dev = HINIC_ETH_DEV_TO_PRIVATE_NIC_DEV(eth_dev);
>
