08/11/2019 17:25, Anatoly Burakov: > In order to facilitate mass updating of version files, add a shell > script that recurses into lib/ and drivers/ directories and calls > the ABI version update script. > > Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com> > Acked-by: Bruce Richardson <bruce.richard...@intel.com> > --- /dev/null > +++ b/buildtools/update-abi.sh > @@ -0,0 +1,42 @@ > +#!/bin/sh
For such script, I think -e is mandatory, so we do not miss any error. It would just require merge following check in the "if": > +# check version string format > +echo $abi_version | grep -q -e "^[[:digit:]]\{1,2\}\.[[:digit:]]\{1,2\}$" > +if [ "$?" -ne 0 ]; then > + # output to stderr > + >&2 echo "ABI version must be formatted as MAJOR.MINOR version" > + exit 1 > +fi