[PATCH v1] examples/fips_validation: prehash input for RSA

2024-10-28 Thread Gowrishankar Muthukrishnan
Plain text needs to be prehashed for RSA as well in asymmetric crypto validation. Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/e

[PATCH v1] examples/fips_validation: fix EdDSA signature size

2024-10-28 Thread Gowrishankar Muthukrishnan
Fix EdDSA signature size. Fixes: 12ede9ac497f ("examples/fips_validation: support EdDSA") Signed-off-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation_eddsa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/fips_validation/fips_validati

RE: [PATCH v13 2/3] examples/l3fwd-power: fix data overflow when parse command line

2024-10-28 Thread Tummala, Sivaprasad
[AMD Official Use Only - AMD Internal Distribution Only] Hi Huisong, LGTM! > -Original Message- > From: Huisong Li > Sent: Friday, October 25, 2024 2:49 PM > To: dev@dpdk.org > Cc: m...@smartsharesystems.com; tho...@monjalon.net; Yigit, Ferruh > ; anatoly.bura...@intel.com; david.h...@i

Re: [PATCH v4 02/13] eal: replace strtok with reentrant version

2024-10-28 Thread Stephen Hemminger
On Tue, 29 Oct 2024 08:56:20 +0800 fengchengwen wrote: > >>> > >>> This doesn't need to go to stable. parse_params is always single > >>> threaded. > >> > >> I recommend replacing all, based on: > >> 1\ almost at no cost. > >> 2\ reduce analysis costs, if don't we have to analyze the callers

[DPDK/ethdev Bug 1572] The L3FWD_POWER : Cause: rte_power_ethdev_pmgmt_queue_enable: err=-95, port=0

2024-10-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1572 Bug ID: 1572 Summary: The L3FWD_POWER : Cause: rte_power_ethdev_pmgmt_queue_enable: err=-95, port=0 Product: DPDK Version: 24.11 Hardware: All OS: All S

[PATCH v2 1/2] config/arm: strict use of -mcpu for supported CPUs

2024-10-28 Thread Wathsala Vithanage
Arm recommends using -mcpu over -march and march-extensions when the compiler supports the target CPU (neoverse-n1 etc.). Arm build so far has been an amalgam of -mcpu and -march. When march is in use, it has been the case so far to silently fall back to a downgraded march when the compiler does no

[PATCH v2 2/2] config/arm: sort SOCs alphabetically

2024-10-28 Thread Wathsala Vithanage
Order SOC configurations and names alphabetically. Signed-off-by: Wathsala Vithanage Reviewed-by: Dhruv Tripathi --- config/arm/meson.build | 72 +- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson

Re: [PATCH v2 1/2] net/bonding: standard the log message

2024-10-28 Thread lihuisong (C)
Acked-by: Huisong Li 在 2024/10/11 11:24, Chaoyong He 写道: From: Long Wu According to the check rules in the patch check script, drivers and libraries must use the logging framework. So standard the log message of bonding driver by using the logging framework. Signed-off-by: Long Wu Reviewed-

Re: [PATCH v2 2/2] net/bonding: add command to set dedicated queue size

2024-10-28 Thread lihuisong (C)
Very useful, Acked-by: Huisong Li 在 2024/10/11 11:24, Chaoyong He 写道: From: Long Wu The testpmd application can not modify the value of dedicated hardware Rx/Tx queue size, and hardcoded them as (128/512). This will cause the bonding port start fail if some NIC requires more Rx/Tx descriptors

Re: [PATCH v2 2/7] dts: enforce one dpdk build per test run

2024-10-28 Thread Patrick Robb
Reviewed-by: Patrick Robb

Re: [PATCH v3 3/7] dts: change remote and local paths objects

2024-10-28 Thread Patrick Robb
Reviewed-by: Patrick Robb

Re: [PATCH v2 1/7] dts: rename build target to DPDK build

2024-10-28 Thread Patrick Robb
Reviewed-by: Patrick Robb

Re: [PATCH v2 7/7] dts: remove git ref option

2024-10-28 Thread Patrick Robb
On Mon, Oct 21, 2024 at 9:50 AM Luca Vizzarro wrote: > From: Tomáš Ďurovec > > Given the whole DPDK tree directory can now be copied to the nodes, > there is no more need to use the git ref option, as the tree can be > controlled directly by the user. > > Signed-off-by: Tomáš Ďurovec > Signed-o

Re: [PATCH v2 6/7] doc: update argument options for external DPDK build

2024-10-28 Thread Patrick Robb
On Mon, Oct 21, 2024 at 9:50 AM Luca Vizzarro wrote: > > + > + DPDK Build Options: > + Arguments in this group (and subgroup) will be applied to a > DPDKLocation when the DPDK tree, tarball or revision will be provided, > other arguments > + like remote source and build dir are optional. A

Re: [PATCH v2 5/7] dts: add support for externally compiled DPDK

2024-10-28 Thread Patrick Robb
On Mon, Oct 21, 2024 at 9:50 AM Luca Vizzarro wrote: > From: Tomáš Ďurovec > > Enable the user to use either a DPDK source tree directory or a > tarball, with and without a pre-built build directory. These can be > stored on either SUT node or the DTS host. The DPDK build setup or the > pre-buil

Re: [PATCH v4 00/42] replace strerror

2024-10-28 Thread lihuisong (C)
For series, Acked-by: Huisong Li 在 2024/10/23 16:28, Dengdui Huang 写道: The function strerror() is insecure in a multi-thread environment. It is better to use rte_strerror() instead of strerror(). In this patchset, only the libs and drivers are modified. chang log: v3->v4 fix ci error v2->v3 d

Re: [PATCH v2 4/7] dts: enable copying directories to and from nodes

2024-10-28 Thread Patrick Robb
On Mon, Oct 21, 2024 at 9:49 AM Luca Vizzarro wrote: > > + > +@abstractmethod > +def remove_remote_file(self, remote_file_path: str | PurePath, force: > bool = True) -> None: > +"""Remove remote file, by default remove forcefully. > + > +Args: > +remote_file_pa

Re: [PATCH 1/2] config/arm: strict use of -mcpu for supported CPUs

2024-10-28 Thread fengchengwen
On 2024/10/29 7:31, Wathsala Vithanage wrote: > Arm recommends using -mcpu over -march and march-extensions when the > compiler supports the target CPU (neoverse-n1 etc.). Arm build so far > has been an amalgam of -mcpu and -march. When march is in use, it has > been the case so far to silently fal

Re: [PATCH v4 02/13] eal: replace strtok with reentrant version

2024-10-28 Thread fengchengwen
On 2024/10/28 23:31, Stephen Hemminger wrote: > On Mon, 28 Oct 2024 21:04:08 +0800 > fengchengwen wrote: > >> On 2024/10/27 11:00, Stephen Hemminger wrote: >>> On Sat, 26 Oct 2024 18:14:40 +0800 >>> Jie Hai wrote: >>> Multiple threads calling the same function may cause condition ra

Re: [PATCH] config/arm: fix warning for native build with meson >= 0.55

2024-10-28 Thread fengchengwen
Acked-by: Chengwen Feng On 2024/10/28 21:10, David Marchand wrote: > Caught in UNH logs for native compilation on ARM: > > Program /./dpdk/config/arm/armv8_machine.py found: YES > (/./dpdk/config/arm/armv8_machine.py) > WARNING: Project targeting '>= 0.57' but tried to use feature

[PATCH 2/2] config/arm: sort SOCs alphabetically

2024-10-28 Thread Wathsala Vithanage
Order SOC configurations and names alphabetically. Signed-off-by: Wathsala Vithanage Reviewed-by: Dhruv Tripathi --- config/arm/meson.build | 72 +- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson

[PATCH 1/2] config/arm: strict use of -mcpu for supported CPUs

2024-10-28 Thread Wathsala Vithanage
Arm recommends using -mcpu over -march and march-extensions when the compiler supports the target CPU (neoverse-n1 etc.). Arm build so far has been an amalgam of -mcpu and -march. When march is in use, it has been the case so far to silently fall back to a downgraded march when the compiler does no

[PATCH v10 2/6] power: refactor uncore power management library

2024-10-28 Thread Sivaprasad Tummala
This patch refactors the power management library, addressing uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/uncore/*'. The adjustment of meson.build files enables the selective activation of individual drivers. This

[PATCH v10 6/6] power: rename library sources for cpu frequency management

2024-10-28 Thread Sivaprasad Tummala
This patch renames the existing core power library source files from rte_power.* to rte_power_cpufreq.* for better clarity v9: - documentation update Signed-off-by: Sivaprasad Tummala --- app/test/test_power.c| 2 +- app/test/test_power_cpufreq.c

[PATCH v10 1/6] power: refactor core power management library

2024-10-28 Thread Sivaprasad Tummala
This patch introduces a comprehensive refactor to the core power management library. The primary focus is on improving modularity and organization by relocating specific driver implementations from the 'lib/power' directory to dedicated directories within 'drivers/power/core/*'. The adjustment of m

[PATCH v10 5/6] maintainers: update for drivers/power

2024-10-28 Thread Sivaprasad Tummala
Update maintainers for drivers/power/*. Signed-off-by: Sivaprasad Tummala --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e25e9465b5..df7a756612 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1753,6 +1753,7 @@ M: Anatoly Burakov M: David Hunt

[PATCH v10 4/6] drivers/power: uncore support for AMD EPYC processors

2024-10-28 Thread Sivaprasad Tummala
This patch introduces driver support for power management of uncore components in AMD EPYC processors. v9: - documentation update v2: - fixed typo in comments section. - added fabric frequency get support for legacy platforms. Signed-off-by: Sivaprasad Tummala --- doc/guides/prog_guide/powe

[PATCH v10 0/6] power: refactor power management library

2024-10-28 Thread Sivaprasad Tummala
This patchset refactors the power management library, addressing both core and uncore power management. The primary changes involve the creation of dedicated directories for each driver within 'drivers/power/core/*' and 'drivers/power/uncore/*'. This refactor significantly improves code organizati

[PATCH v10 3/6] test/power: removed function pointer validations

2024-10-28 Thread Sivaprasad Tummala
After refactoring the power library, power management operations are now consistently supported regardless of the operating environment, making function pointer checks unnecessary and thus removed from applications. v2: - removed function pointer validation in l3fwd-power app. Signed-off-by: Siv

[PATCH v3] doc: enhance build instructions on Windows

2024-10-28 Thread Andre Muezerie
Enhance build instructions on Windows Signed-off-by: Andre Muezerie --- v3: - Recommended Meson version to use and removed mention about old bug. - Set VS developer prompt to produce 64 bit binaries if needed. v2: - provide Meson version that works .mailmap | 1

Re: [PATCH v2] dts: fix doxygen API link and DTS docs placement

2024-10-28 Thread Dean Marx
On Fri, Oct 25, 2024 at 6:35 AM Paul Szczepanek wrote: > Alias used to produce the link to the DTS API docs uses config data. > The required value in config data was being added in the wrong scope. > This moves the key addition to where the config data object is created. > > DTS docs need to be p

[PATCH v2 2/2] gpudev: add malloc annotations to rte_gpu_mem_alloc

2024-10-28 Thread Stephen Hemminger
Add function attributes that allow detecting use after free, and calling free on bad pointer at compile time. Signed-off-by: Stephen Hemminger --- lib/gpudev/rte_gpudev.h | 46 + 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/lib/gpudev/rt

[PATCH v2 0/2] gpudev: annotate memory allocation functions

2024-10-28 Thread Stephen Hemminger
Use function attributes to catch misuse of GPU memory at compile time. v2 - remove test case where invalid pointer was being passed. The test is now caught at compile time, making a runtime test no longer necessary. Stephen Hemminger (2): test-gpudev: avoid use-after-free and free-non

[PATCH v2 1/2] test-gpudev: avoid use-after-free and free-non-heap warnings

2024-10-28 Thread Stephen Hemminger
Remove the test intentionally frees a bad pointer in GPU memory, and GCC sees that at compile time now. Fix use after free in printf. Signed-off-by: Stephen Hemminger --- app/test-gpudev/main.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/app/test-gpudev

[PATCH] net/mlx5: fix shared Rx queue port number in data path

2024-10-28 Thread Alexander Kozyrev
Wrong CQE is used to get the shared Rx queue port number in vectorized Rx burst routine. Fix the CQE indexing. Fixes: 25ed2ebff1 ("net/mlx5: support shared Rx queue port data path") Signed-off-by: Alexander Kozyrev --- drivers/net/mlx5/mlx5_rxtx_vec_altivec.h | 12 ++-- drivers/net/mlx5

[PATCH v4 7/8] dts: improve configuration API docs

2024-10-28 Thread Luca Vizzarro
Pydantic models are not treated the same way as dataclasses by autodoc. As a consequence the docstrings need to be applied directly to each field. Otherwise the generated API documentation page would present two entries per each field with each their own differences. Signed-off-by: Luca Vizzarro

[PATCH v4 8/8] dts: use TestSuiteSpec class imports

2024-10-28 Thread Luca Vizzarro
The introduction of TestSuiteSpec adds auto-discovery of test suites, which are also automatically imported. This causes double imports as the runner loads the test suites. This changes the behaviour of the runner to load the imported classes from TestSuiteSpec instead of importing them again. Sig

[PATCH v4 4/8] dts: use pydantic in the configuration

2024-10-28 Thread Luca Vizzarro
This change brings in pydantic in place of warlock. Pydantic offers a built-in model validation system in the classes, which allows for a more resilient and simpler code. As a consequence of this change: - most validation is now built-in - further validation is added to verify: - cross referenci

[PATCH v4 6/8] dts: add autodoc pydantic

2024-10-28 Thread Luca Vizzarro
Add and enable the autodoc-pydantic sphinx extension. Pydantic models are not correctly recognised by autodoc, causing the generated docs to lack all the actual model information. The autodoc-pydantic sphinx extension fixes the original behaviour by correctly formatting them. Signed-off-by: Luca V

[PATCH v4 1/8] dts: add pydantic dependency

2024-10-28 Thread Luca Vizzarro
As part of configuration validation and deserialization improvements, this adds pydantic as a project dependency. Pydantic is a library that caters to all of the aforementioned needs, while improving the process and code. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/poetry.

[PATCH v4 5/8] dts: remove warlock dependency

2024-10-28 Thread Luca Vizzarro
Since pydantic has completely replaced warlock, there is no more need to keep it as a dependency. This removes it. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/poetry.lock| 227 + dts/pyproject.toml | 1 - 2 files changed, 1

[PATCH v4 0/8] dts: Pydantic configuration

2024-10-28 Thread Luca Vizzarro
Hi there, sending a v4 for the pydantic changes. v4: - added autodoc_pydantic due to autodoc warnings - fixed pydantic models docstrings - updated docs - refactored DPDKBuildInfo and NodeInfo which didn't belong in configuration v3: - removed the common FrozenModel and configured each BaseModel

[PATCH v4 3/8] dts: refactor build and node info classes

2024-10-28 Thread Luca Vizzarro
The DPDKBuildInfo and NodeInfo classes, representing information gathered in runtime, were erroneously placed in the configuration package. This moves them in more appropriate modules. NodeInfo, specifically, ia moved to os_session instead of node mostly as a consequence of circular dependencies.

[PATCH v4 2/8] dts: add TestSuiteSpec class and discovery

2024-10-28 Thread Luca Vizzarro
Currently there is a lack of a definition which identifies all the test suites available to test. This change intends to simplify the process to discover all the test suites and idenfity them. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/runner.py

Re: [PATCH v6 0/7] Stage-Ordered API and other extensions for ring library

2024-10-28 Thread David Christensen
On 10/21/24 10:47 AM, Konstantin Ananyev wrote: NOTE UPFRONT: this version is still not ready for merging. Missing items: - ARM/PPC tests passing - PG update SORING tests pass on a P9 PowerNV system. (Results attached for review.) Original ring_stress_autotest still fails as documented in Bug

[PATCH v3] drivers: fix error CQE handling for 128 bytes CQE

2024-10-28 Thread Alexander Kozyrev
The completion queue element size can be independently configured to report either 64 or 128 bytes CQEs by programming cqe_sz parameter at CQ creation. This parameter depends on the cache line size and affects both regular CQEs and error CQEs. But the error handling assumes that an error CQE is 64

[PATCH v2] net/mlx5: fix miniCQEs number calculation

2024-10-28 Thread Alexander Kozyrev
Use the information from the CQE, not from the title packet, for getting the number of miniCQEs in the compressed CQEs array. This way we can avoid segfaults in the rxq_cq_decompress_v() in case of mbuf corruption (due to double mbuf free, for example). Fixes: 6cb559d67b ("net/mlx5: add vectorized

[DPDK/other Bug 1313] Build errors with clang 17.0.3 and ASan

2024-10-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1313 Ali Alnubani (alia...@nvidia.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|-

RE: [PATCH] net/mlx5: fix miniCQEs number calculation

2024-10-28 Thread Slava Ovsiienko
Acked-by: Viacheslav Ovsiienko > -Original Message- > From: Alexander Kozyrev > Sent: Monday, October 28, 2024 6:43 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad ; > Dariusz Sosnowski ; Bing Zhao > ; Suanming Mou > Subject: [PATCH] net/m

RE: [PATCH 1/1] doc: virtual function MTU settings has no meaning

2024-10-28 Thread Slava Ovsiienko
> -Original Message- > From: Stephen Hemminger > Sent: Monday, October 28, 2024 5:52 PM > To: Slava Ovsiienko > Cc: dev@dpdk.org; Raslan Darawsheh ; Matan Azrad > ; Suanming Mou > Subject: Re: [PATCH 1/1] doc: virtual function MTU settings has no meaning > > On Mon, 28 Oct 2024 16:45:09

[PATCH v3 3/3] vduse: use imported VDUSE uAPI header

2024-10-28 Thread Maxime Coquelin
This patch makes use of the imported VDUSE headers. The VDUSE support is now systematically built on Linux systems, even if the build system does not support its ioctl(). Signed-off-by: Maxime Coquelin Acked-by: Morten Brørup --- lib/vhost/meson.build | 5 + lib/vhost/vduse.c | 2 +-

[PATCH] net/mlx5: fix miniCQEs number calculation

2024-10-28 Thread Alexander Kozyrev
Use the information from the CQE, not from the title packet, for getting the number of miniCQEs in the compressed CQEs array. This way we can avoid segfaults in the rxq_cq_decompress_v() in case of mbuf corruption (due to double mbuf free, for example). Fixes: 6cb559d67b ("net/mlx5: add vectorized

[PATCH 2/4] net/tap: rename struct nlmsg to tap_nlmsg

2024-10-28 Thread Stephen Hemminger
The struct netlink message structure is part of the internal TAP device API, not the netlink API itself. Use tap_ prefix to avoid any confusion with nlmsghdr from netlink.h Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_flow.c| 22 +++--- drivers/net/tap/tap_netlink

[PATCH 4/4] net/tap: do not use rte_malloc for process private data

2024-10-28 Thread Stephen Hemminger
The process private data is local to the process and does not have to come from global shared memory. Using malloc() gets more coverage with tools and has better caching. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 21 ++--- 1 file changed, 10 insertions(

[PATCH 1/4] net/tap: replace rte_memcpy

2024-10-28 Thread Stephen Hemminger
There is no point in using rte_memcpy to copy Ethernet addresses. Use rte_ether_addr_copy() instead. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net

[PATCH 3/4] net/tap: do not use opaque parameter in convert

2024-10-28 Thread Stephen Hemminger
The function to convert from internal representation to netlink was using a void pointer when both caller and callee were using same structure. Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_flow.c | 47 +- 1 file changed, 16 insertions(+), 31 deleti

[PATCH 0/4] net/tap: minor cleanups

2024-10-28 Thread Stephen Hemminger
These are some minor things in tap device that can be easily fixed. Not urgent can wait until 25.03 release but submitting now for review. Stephen Hemminger (4): net/tap: replace rte_memcpy net/tap: rename struct nlmsg to tap_nlmsg net/tap: do not use opaque parameter in convert net/tap: d

Re: [PATCH v6 00/47] TruFlow update for Thor2

2024-10-28 Thread Sriharsha Basavapatna
On Mon, Oct 28, 2024 at 6:28 PM Thomas Monjalon wrote: > > 24/10/2024 07:26, Ajit Khaparde: > > On Mon, Oct 21, 2024 at 1:14 AM Sriharsha Basavapatna > > wrote: > > > > > > This patch series introduces TruFlow functionality for Broadcom Thor2 NIC. > > > > > > TruFlow(TF) is the software library t

[PATCH v8 10/22] event/cnxk: add CN20K event port profile switch

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add CN20K event port profile switch. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn20k_eventdev.c | 1 + drivers/event/cnxk/cn20k_worker.c | 11 +++ drivers/event/cnxk/cn20k_worker.h | 1 + 3 files changed, 13 insertions(+) diff --git a/drivers/ev

[PATCH v8 02/22] common/cnxk: implement SSO HW info

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add SSO HW info mbox to get hardware capabilities, and reuse them instead of depending on hardcoded values. Remove redundant includes. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_mbox.h | 28 ++ drivers/common/cnxk/roc_sso.c

Re: [PATCH V2 3/7] net/mlx5: add new devargs to control probe optimization

2024-10-28 Thread Stephen Hemminger
On Mon, 28 Oct 2024 11:18:18 +0200 "Minggang Li(Gavin)" wrote: > +- ``probe_opt_en`` parameter [int] > + > + A non-zero value optimizes the probe process, especially for large scale. > + PMD will hold the IB device information internally and reuse it. > + > + By default, the PMD will set this

[PATCH v8 13/22] event/cnxk: add CN20K device stop and close

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add event device stop and close callback functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn20k_eventdev.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/event/cnxk/cn20k_eventdev.c b/drivers/event/cnxk/cn20k_eventdev.c

Re: [PATCH v3 53/73] net/ntnic: enable RSS feature

2024-10-28 Thread Stephen Hemminger
On Wed, 23 Oct 2024 19:00:01 +0200 Serhii Iliushyk wrote: > + > + rte_memcpy(&tmp_rss_conf.rss_key, rss_conf->rss_key, > rss_conf->rss_key_len); Avoid use of rte_memcpy(), it has less checking that memcpy(). The only place it can make sense is in the hot data path where compiler is

[PATCH v8 12/22] event/cnxk: add CN20K device start

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add CN20K start function along with few cleanup API's to maintain sanity. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 103 +-- drivers/event/cnxk/cn20k_eventdev.c | 76 drivers/event/cnxk/cnxk_comm

[PATCH v8 09/22] event/cnxk: add CN20K event port quiesce

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add CN20K event port quiesce function. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn20k_eventdev.c | 60 + 1 file changed, 60 insertions(+) diff --git a/drivers/event/cnxk/cn20k_eventdev.c b/drivers/event/cnxk/cn20k_eventdev.c inde

[PATCH v8 21/22] common/cnxk: update timer base code

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Update event timer base code to support configuring HW accelerated timer arm and cancel. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/hw/tim.h| 5 ++ drivers/common/cnxk/roc_mbox.h | 38 - drivers/common/cnxk/roc_tim.c | 84 ++

[PATCH v8 05/22] event/cnxk: add CN20k event queue configuration

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add setup and release functions for event queues i.e. SSO HWGRPs. Allocate buffers in DRAM that hold inflight events. Register device args to modify inflight event buffer count, HWGRP QoS and stash. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c |

[PATCH v8 11/22] event/cnxk: add CN20K event port preschedule

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add CN20K event port preschedule modify and preschedule functions. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/hw/ssow.h | 1 + drivers/event/cnxk/cn20k_eventdev.c | 2 ++ drivers/event/cnxk/cn20k_worker.c | 30 + drivers/e

RE: [PATCH v2] drivers: fix error CQE handling

2024-10-28 Thread Slava Ovsiienko
Acked-by: Viacheslav Ovsiienko > -Original Message- > From: Alexander Kozyrev > Sent: Thursday, October 3, 2024 11:26 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Raslan Darawsheh ; Slava > Ovsiienko ; Matan Azrad ; > step...@networkplumber.org > Subject: [PATCH v2] drivers: fix error CQ

[PATCH v8 04/22] event/cnxk: add CN20K device config

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add CN20K event device configuration that attaches the requested number of SSO HWS(event ports) and HWGRP(event queues) LFs to the RVU PF/VF. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn20k_eventdev.c | 36 + 1 file changed, 36 inse

[PATCH v8 19/22] common/cnxk: add SSO event aggregator

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add configuration APIs for CN20K SSO event aggregator which allows SSO to generate event vectors. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/hw/sso.h| 33 drivers/common/cnxk/roc_mbox.h | 21 +++ drivers/common/cnxk/roc_model.h | 13 ++

[PATCH v8 01/22] event/cnxk: use stdatomic API

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Replace gcc inbuilt __atomic_xxx intrinsics with rte_atomic_xxx API. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Rebase and remove single dequeue and enqueue functions. v3 Changes: - Remove __atomic builtins. v4 Changes: - Rebase onto next-event tree. v5 Changes: - Re

[PATCH v8 07/22] event/cnxk: add CN20K SSO enqueue fast path

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add CN20K SSO GWS fastpath event device enqueue functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn20k_eventdev.c | 20 +- drivers/event/cnxk/cn20k_worker.c | 384 drivers/event/cnxk/cn20k_worker.h | 21 ++ drivers/event/

[PATCH v8 06/22] event/cnxk: add CN20K event port configuration

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add SSO HWS a.k.a event port setup, release, link, unlink functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 63 ++- drivers/event/cnxk/cn20k_eventdev.c | 174 drivers/event/cnxk/cn20k_eventdev.h

[PATCH v8 03/22] event/cnxk: add CN20K specific device probe

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add platform specific event device probe and remove, also add event device info get function. Signed-off-by: Pavan Nikhilesh --- doc/guides/eventdevs/cnxk.rst | 23 --- doc/guides/rel_notes/release_24_11.rst | 4 ++ drivers/common/cnxk/roc_sso.c | 1

[PATCH v8 08/22] event/cnxk: add CN20K SSO dequeue fast path

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add CN20K SSO GWS event dequeue fastpath functions. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn20k_eventdev.c | 5 + drivers/event/cnxk/cn20k_worker.c | 54 +++ drivers/event/cnxk/cn20k_worker.h | 137 +++- 3 files chang

[PATCH v8 22/22] event/cnxk: add CN20K timer adapter

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add event timer adapter support for CN20K platform. Implement new HWWQE insertion feature supported by CN20K platform. Signed-off-by: Pavan Nikhilesh --- drivers/common/cnxk/roc_tim.c| 6 +- drivers/event/cnxk/cn20k_eventdev.c | 16 ++- drivers/event/cnxk/cn20

[PATCH v8 20/22] event/cnxk: add Rx/Tx event vector support

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add Event vector support for CN20K Rx/Tx adapter. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn20k_eventdev.c | 185 ++- drivers/event/cnxk/cn20k_tx_worker.h | 84 ++ drivers/event/cnxk/cn20k_worker.h| 63

[PATCH v8 17/22] event/cnxk: support CN20K Tx adapter

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Tx adapter. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn20k_eventdev.c | 126 +++ drivers/event/cnxk/cn20k_eventdev.h | 4 + drivers/event/cnxk/cn20k_tx_worker.h | 16 3 files changed, 146 insertions(

[PATCH v8 18/22] event/cnxk: support CN20K Tx adapter fast path

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Tx adapter fastpath operations. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn20k_eventdev.c | 29 +++ drivers/event/cnxk/cn20k_tx_worker.h | 176 +++ drivers/event/cnxk/meson.build | 20

[PATCH v8 16/22] event/cnxk: support CN20K Rx adapter fast path

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add support for event eth Rx adapter fastpath operations. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn20k_eventdev.c | 122 - drivers/event/cnxk/cn20k_worker.c | 54 -- drivers/event/cnxk/cn20k_worker.h | 165

[PATCH v8 15/22] event/cnxk: support CN20K Rx adapter

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add support for CN20K event eth Rx adapter. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn20k_eventdev.c | 121 +++- drivers/event/cnxk/cn20k_eventdev.h | 4 + 2 files changed, 124 insertions(+), 1 deletion(-) diff --git a/drivers/even

[PATCH v8 14/22] event/cnxk: add CN20K xstats, selftest and dump

2024-10-28 Thread pbhagavatula
From: Pavan Nikhilesh Add selftest to verify SSO, xstats to get queue specific stats and add function to dump internal state of SSO. Signed-off-by: Pavan Nikhilesh --- app/test/test_eventdev.c| 7 +++ drivers/event/cnxk/cn20k_eventdev.c | 12 drive

Re: [PATCH 1/1] doc: add mlx5 xstats send scheduling counters description

2024-10-28 Thread Stephen Hemminger
On Mon, 28 Oct 2024 16:27:41 +0200 Viacheslav Ovsiienko wrote: > The mlx5 provides the scheduling send on time capability. > The check the operating status of this feature the xstats > counters are provided. This patch adds the counter descriptions > and provides some meaningful information how t

[PATCH 1/2] net/mlx5/hws: log syndrome and info on CQE error

2024-10-28 Thread oyj
From: Gavin Li Print CQE error syndrome and more information in case of queue error. Signed-off-by: Gavin Li Acked-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_send.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/n

Re: [PATCH V2 7/7] mlx5: add backward compatibility for RDMA monitor

2024-10-28 Thread Stephen Hemminger
On Mon, 28 Oct 2024 11:18:22 +0200 "Minggang Li(Gavin)" wrote: > +* **Updated NVIDIA mlx5 driver.** > + > + Optimized port probe in large scale. > + In previous release, it would take long time to probe one VF/SF if > + hundreds of VF/SF were created in the system. With this newly introduced >

[PATCH v3 2/3] uapi: import VDUSE header

2024-10-28 Thread Maxime Coquelin
Import VDUSE headers to be included in the Vhost library. Set header version to v6.10 Linux Kernel release. Signed-off-by: Maxime Coquelin Acked-by: Morten Brørup --- kernel/linux/uapi/linux/vduse.h | 353 kernel/linux/uapi/version | 2 +- 2 files change

RE: [PATCH v3 2/2] common/mlx5: reduce HCA attribute type sizes

2024-10-28 Thread Slava Ovsiienko
Thank you for the patch. Acked-by: Viacheslav Ovsiienko > -Original Message- > From: Igor Gutorov > Sent: Wednesday, August 7, 2024 11:44 PM > To: dev@dpdk.org > Cc: Igor Gutorov > Subject: [PATCH v3 2/2] common/mlx5: reduce HCA attribute type sizes > > A number of `log_max_*` fields'

[PATCH v3 1/3] uapi: introduce kernel uAPI headers import

2024-10-28 Thread Maxime Coquelin
This patch introduces uAPI headers import into the DPDK repository. This import is possible thanks to Linux Kernel licence exception for syscalls: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/LICENSES/exceptions/Linux-syscall-note Header files have to be explicitly impo

[PATCH v3 0/3] Import Kernel uAPI header files

2024-10-28 Thread Maxime Coquelin
This series enables importing Linux Kernel uAPI headers into the DPDK repository. It aims at solving alignment issues between the build system and the system applications linked ot DPDK libraries are run on. It can also help simplify spaghetti code done to support different versions of the Linux K

RE: [PATCH v1] net/mlx5: error cqe handle Tx queue need assert

2024-10-28 Thread Slava Ovsiienko
Hi, I have some notes regarding the patch: - patch does not fix the root cause of SQ state setting FW call failure (https://bugs.dpdk.org/show_bug.cgi?id=1449 ) - MLX5_ASSERT is engaged only in debug mode and should not be used in release - removing "return " prevents the tx_burst from retrying o

RE: [PATCH v3 1/2] net/mlx5: fix reported Rx/Tx desc limits

2024-10-28 Thread Slava Ovsiienko
Thank you for the patch. Acked-by: Viacheslav Ovsiienko > -Original Message- > From: Igor Gutorov > Sent: Wednesday, August 7, 2024 11:44 PM > To: dev@dpdk.org > Cc: Igor Gutorov ; sta...@dpdk.org > Subject: [PATCH v3 1/2] net/mlx5: fix reported Rx/Tx desc limits > > Currently, `rte_eth

Re: [PATCH v1 27/30] net/i40e/base: change time variables from 64 bit to 32 bit

2024-10-28 Thread Ilgiewicz, Jaroslaw
We will send the fix once we sync internally hopefully tomorrow. Sorry for the delay. Jaroslaw Ilgiewicz From: David Marchand Sent: Friday, October 25, 2024 1:45 PM To: Burakov, Anatoly ; Richardson, Bruce ; Ilgiewicz, Jaroslaw Cc: dev@dpdk.org ; Thomas Monjalon

Re: [PATCH v4 1/1] event/octeontx: fix possible integer overflow

2024-10-28 Thread Jerin Jacob
On Fri, Oct 25, 2024 at 4:28 PM Hanumanth Pothula wrote: > > The last argument passed to ssovf_parsekv() is an > unsigned char*, but it is accessed as an integer. > This can lead to an integer overflow. > > Hence, make ensure the argument is accessed as a char > and for better error handling use s

[DPDK/other Bug 1571] Documentation of non root table

2024-10-28 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1571 Bug ID: 1571 Summary: Documentation of non root table Product: DPDK Version: 24.07 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority:

[PATCH 1/1] doc: virtual function MTU settings has no meaning

2024-10-28 Thread Viacheslav Ovsiienko
There is the mlx5 NIC limitations - configuring MTU for PCI Virtual Function has no meaning. The actual maximal packet size in VF's receiving is limited by MTU configured on the related PCI Physical Function, the DPDK datapath running over VF should be prepared to handle packets of this maximal siz

[PATCH 1/1] doc: add mlx5 xstats send scheduling counters description

2024-10-28 Thread Viacheslav Ovsiienko
The mlx5 provides the scheduling send on time capability. The check the operating status of this feature the xstats counters are provided. This patch adds the counter descriptions and provides some meaningful information how to interpret the counter values in runtime. Signed-off-by: Viacheslav Ovs

Re: [v2] net/mlx5/hws: in NAT64 fix TC to TOS fields mapping

2024-10-28 Thread Raslan Darawsheh
Hi, From: Itamar Gozlan Sent: Sunday, October 27, 2024 6:14 PM To: Itamar Gozlan; Hamdan Agbariya; NBU-Contact-Thomas Monjalon (EXTERNAL); Suanming Mou; Dariusz Sosnowski; Slava Ovsiienko; Bing Zhao; Ori Kam; Matan Azrad; Erez Shitrit Cc: dev@dpdk.org; sta...@dpdk.org Subject: [v2] net/mlx5/hws

[PATCH] igc: fix invalid length and corrupted multi-segment mbufs

2024-10-28 Thread Martin Weiser
The issue only appeared with hardware-timestamping enabled (RTE_ETH_RX_OFFLOAD_TIMESTAMP). The length of the prepended hardware timestamp was not subtracted from the data length so that received packets were 16 bytes longer than expected. In scatter-gather mode only the first mbuf has a timesta

Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump

2024-10-28 Thread Lewis Donzis
It seems unlikely that there are other users of contigmem on FreeBSD, especially since it's not necessary for other applications. On FreeBSD, use of large and huge pages is automatic; you just call mmap() with a large size and it automatically tries to use the largest physical pages possible.

  1   2   >