On Mon, Oct 21, 2024 at 9:49 AM Luca Vizzarro <luca.vizza...@arm.com> wrote:
> > + > + @abstractmethod > + def remove_remote_file(self, remote_file_path: str | PurePath, force: > bool = True) -> None: > + """Remove remote file, by default remove forcefully. > + > + Args: > + remote_file_path: The file path to remove. > + force: If :data:`True`, ignore all warnings and try to remove > at all costs. > + """ > This is outside of the scope of this patch, but I figured I would comment that we should use this to clean the dpdk-devbind.py file when we re-add that functionality. I'm glad this method is added. :) > + > @abstractmethod > def remove_remote_dir( > self, > @@ -213,11 +302,34 @@ def remove_remote_dir( > """Remove remote directory, by default remove recursively and > forcefully. > > Args: > - remote_dir_path: The path of the directory to remove. > + remote_dir_path: The directory path to remove. > recursive: If :data:`True`, also remove all contents inside > the directory. > force: If :data:`True`, ignore all warnings and try to remove > at all costs. > """ > > + @abstractmethod > + def create_remote_tarball( > + self, > + remote_dir_path: str | PurePath, > + compress_format: TarCompressionFormat = TarCompressionFormat.none, > + exclude: str | list[str] | None = None, > + ) -> PurePosixPath: > Does this have to be a PurePosixPath instead of a PurePath? I know adding Windows support for DTS seems far out, but we should not add in barriers to that now without good reason (though if there is a strong practical reason why we want to do this now, then okay). I believe we will have a PurePosixPath return in testbed_model/posix_session.py and a PureWindowsPath return in testbed_model/windows_session.py (when it exists). Otherwise, I know we discussed this at the DTS call on Thurs, but thanks for remaining .gz .xz agnostic. Reviewed-by: Patrick Robb <pr...@iol.unh.edu>
