On Mon, Oct 21, 2024 at 9:50 AM Luca Vizzarro <luca.vizza...@arm.com> wrote:

> From: Tomáš Ďurovec <tomas.duro...@pantheon.tech>
>
> Given the whole DPDK tree directory can now be copied to the nodes,
> there is no more need to use the git ref option, as the tree can be
> controlled directly by the user.
>
> Signed-off-by: Tomáš Ďurovec <tomas.duro...@pantheon.tech>
> Signed-off-by: Luca Vizzarro <luca.vizza...@arm.com>
> ---
>  doc/guides/tools/dts.rst  |   9 ---
>  dts/framework/settings.py |  48 ++-------------
>  dts/framework/utils.py    | 119 +-------------------------------------
>  3 files changed, 7 insertions(+), 169 deletions(-)
>
> diff --git a/doc/guides/tools/dts.rst b/doc/guides/tools/dts.rst
> index 7b90c4856e..a00d987ece 100644
> --- a/doc/guides/tools/dts.rst
> +++ b/doc/guides/tools/dts.rst
> @@ -237,9 +237,6 @@ DTS is run with ``main.py`` located in the ``dts``
> directory after entering Poet
>     -t SECONDS, --timeout SECONDS
>                             [DTS_TIMEOUT] The default timeout for all DTS
> operations except for compiling DPDK. (default: 15)
>     -v, --verbose           [DTS_VERBOSE] Specify to enable verbose
> output, logging all messages to the console. (default: False)
> -   --revision ID, --rev ID, --git-ref ID
> -                           [DTS_DPDK_REVISION_ID] Git revision ID to
> test. Could be commit, tag, tree ID etc. To test local changes, first
> -                           commit them, then use their commit ID.
> (default: None)
>     --compile-timeout SECONDS
>                             [DTS_COMPILE_TIMEOUT] The timeout for
> compiling DPDK. (default: 1200)
>     --test-suite TEST_SUITE [TEST_CASES ...]
> @@ -275,12 +272,6 @@ The minimum DTS needs is a config file and a
> pre-built DPDK or DPDK
>  sources location which can be specified in said config file or on the
>  command line or environment variables.
>
> -Example command for running DTS with the template configuration and DPDK
> tag v23.11:
> -
> -.. code-block:: console
> -
> -   (dts-py3.10) $ ./main.py --git-ref v23.11
> -
>

I see this needs to go because of the --git-ref usage. Can this be replaced
with a new example command? Perhaps even 2, one for each of --tarball and
--dpdk-tree?


Reviewed-by: Patrick Robb <pr...@iol.unh.edu>

Reply via email to