[GitHub] kangkaisen commented on issue #549: Add a colocate join meta repair tool

2019-01-22 Thread GitBox
kangkaisen commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-456687468 Yes. Returning 404 could work. This is an automated message from the Apa

[GitHub] kangkaisen commented on issue #562: Add ColocateMetaService

2019-01-22 Thread GitBox
kangkaisen commented on issue #562: Add ColocateMetaService URL: https://github.com/apache/incubator-doris/pull/562#issuecomment-456686818 Auto redirect To FE Master and update the API doc. This is an automated message from th

Re: Does Doris need new mentor?

2019-01-22 Thread ShaoFeng Shi
Awesome, that's very clear now! Best regards, Shaofeng Shi 史少锋 Apache Kylin PMC Work email: shaofeng@kyligence.io Kyligence Inc: https://kyligence.io/ Apache Kylin FAQ: https://kylin.apache.org/docs/gettingstarted/faq.html Join Kylin user mail group: user-subscr...@kylin.apache.org Join Kyli

Re: Does Doris need new mentor?

2019-01-22 Thread Li,De(BDG)
Hi -, Now we have a page which can list the Mentor/PMC/committers. http://doris.apache.org/policy/pmc.html Best Regards, Reed On 2019/1/23 下午12:17, "ShaoFeng Shi" wrote: >Hi Willem, > >I have received the email notification, thanks for your support! > >I will start to study Doris and collabora

[GitHub] imay commented on issue #549: Add a colocate join meta repair tool

2019-01-22 Thread GitBox
imay commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-456682541 @kangkaisen I think returning 404 is OK if it can stop Chrome sending request

[GitHub] imay merged pull request #571: Add disk usage percent in SHOW BACKEND stmt

2019-01-22 Thread GitBox
imay merged pull request #571: Add disk usage percent in SHOW BACKEND stmt URL: https://github.com/apache/incubator-doris/pull/571 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] morningman closed issue #540: Implement new tablet repair and balance framework

2019-01-22 Thread GitBox
morningman closed issue #540: Implement new tablet repair and balance framework URL: https://github.com/apache/incubator-doris/issues/540 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] morningman opened a new pull request #571: Add disk usage percent in SHOW BACKEND stmt

2019-01-22 Thread GitBox
morningman opened a new pull request #571: Add disk usage percent in SHOW BACKEND stmt URL: https://github.com/apache/incubator-doris/pull/571 DataUsedCapacity only shows the capacity occupied by user data. But there are other files such as trash or snapshot may also occupy disk capacit

[GitHub] kangkaisen commented on issue #562: Add ColocateMetaService

2019-01-22 Thread GitBox
kangkaisen commented on issue #562: Add ColocateMetaService URL: https://github.com/apache/incubator-doris/pull/562#issuecomment-456664843 Return 404 page for favicon.ico request. like http://druid.io/favicon.ico This is an a

Re: Does Doris need new mentor?

2019-01-22 Thread ShaoFeng Shi
Hi Willem, I have received the email notification, thanks for your support! I will start to study Doris and collaborate with the community! Thank you all! Best regards, Shaofeng Shi 史少锋 Apache Kylin PMC Work email: shaofeng@kyligence.io Kyligence Inc: https://kyligence.io/ Apache Kylin FAQ

[GitHub] kangkaisen commented on issue #549: Add a colocate join meta repair tool

2019-01-22 Thread GitBox
kangkaisen commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-456664026 @lingbin Thanks for your reminder, there still is a problem. before this pr, when request xxx:8410/favicon.ico, the Chrome will get

Re: Does Doris need new mentor?

2019-01-22 Thread Willem Jiang
FYI, I just added the Shaofeng into the mentor group of Doris. The notification mail should be sent to incubator.apache.org. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Jan 23, 2019 at 10:28 AM Li,De(BDG) wrote: > > Hi Shaofeng, > > Since most of the Doris IPMC members and mentors

[GitHub] kangkaisen commented on issue #562: Add ColocateMetaService

2019-01-22 Thread GitBox
kangkaisen commented on issue #562: Add ColocateMetaService URL: https://github.com/apache/incubator-doris/pull/562#issuecomment-456660075 Add a colocate meta API Reference doc. I think we could add all Http API Reference to this doc and put this doc to WIKI page. -

[GitHub] kangkaisen commented on a change in pull request #562: Add ColocateMetaService

2019-01-22 Thread GitBox
kangkaisen commented on a change in pull request #562: Add ColocateMetaService URL: https://github.com/apache/incubator-doris/pull/562#discussion_r250047954 ## File path: fe/src/main/java/org/apache/doris/http/common/DorisHttpObjectAggregator.java ## @@ -0,0 +1,62 @@ +// L

[GitHub] lingbin commented on issue #549: Add a colocate join meta repair tool

2019-01-22 Thread GitBox
lingbin commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-456658034 > Refer to the java doc and debug, the `HttpServerHandler.channelReadComplete` will be called many times.When the first time call for `Mess

Re: Does Doris need new mentor?

2019-01-22 Thread ShaoFeng Shi
Hi De, I see; Yes, please send an email to gene...@incubator.apache.org, then the incubator will follow this change. Thank you! Best regards, Shaofeng Shi 史少锋 Apache Kylin PMC Work email: shaofeng@kyligence.io Kyligence Inc: https://kyligence.io/ Apache Kylin FAQ: https://kylin.apache.org/d

[GitHub] imay commented on a change in pull request #562: Add ColocateMetaService

2019-01-22 Thread GitBox
imay commented on a change in pull request #562: Add ColocateMetaService URL: https://github.com/apache/incubator-doris/pull/562#discussion_r250042838 ## File path: fe/src/main/java/org/apache/doris/http/common/DorisHttpObjectAggregator.java ## @@ -0,0 +1,62 @@ +// License

[GitHub] kangkaisen commented on a change in pull request #562: Add ColocateMetaService

2019-01-22 Thread GitBox
kangkaisen commented on a change in pull request #562: Add ColocateMetaService URL: https://github.com/apache/incubator-doris/pull/562#discussion_r250042232 ## File path: fe/src/main/java/org/apache/doris/http/common/DorisHttpObjectAggregator.java ## @@ -0,0 +1,62 @@ +// L

[GitHub] kangkaisen commented on a change in pull request #562: Add ColocateMetaService

2019-01-22 Thread GitBox
kangkaisen commented on a change in pull request #562: Add ColocateMetaService URL: https://github.com/apache/incubator-doris/pull/562#discussion_r250040900 ## File path: fe/src/main/java/org/apache/doris/http/meta/ColocateMetaService.java ## @@ -0,0 +1,250 @@ +package org.

[GitHub] kangkaisen commented on issue #562: Add ColocateMetaService

2019-01-22 Thread GitBox
kangkaisen commented on issue #562: Add ColocateMetaService URL: https://github.com/apache/incubator-doris/pull/562#issuecomment-456650125 OK. I will write a API doc for colocate meta. This is an automated message from the Apa

[GitHub] kangkaisen commented on issue #549: Add a colocate join meta repair tool

2019-01-22 Thread GitBox
kangkaisen commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-456649524 Refer to the java doc and debug, the `HttpServerHandler.channelReadComplete` will be called many times.When the first time call for `Mes

Re: Does Doris need new mentor?

2019-01-22 Thread Li,De(BDG)
Hi Shaofeng, Since most of the Doris IPMC members and mentors (7/12) have approved, I think no need to discuss and vote. I don’t know how to operate to add you as our mentor yet, is it need us to send a email to gene...@incubator.apache.org? The page you mentioned is still under construction. Be

[GitHub] imay commented on a change in pull request #562: Add ColocateMetaService

2019-01-22 Thread GitBox
imay commented on a change in pull request #562: Add ColocateMetaService URL: https://github.com/apache/incubator-doris/pull/562#discussion_r250028032 ## File path: fe/src/main/java/org/apache/doris/http/meta/ColocateMetaService.java ## @@ -0,0 +1,250 @@ +package org.apache

[GitHub] imay commented on a change in pull request #562: Add ColocateMetaService

2019-01-22 Thread GitBox
imay commented on a change in pull request #562: Add ColocateMetaService URL: https://github.com/apache/incubator-doris/pull/562#discussion_r250031396 ## File path: fe/src/main/java/org/apache/doris/http/common/DorisHttpObjectAggregator.java ## @@ -0,0 +1,62 @@ +// License

[GitHub] imay commented on issue #549: Add a colocate join meta repair tool

2019-01-22 Thread GitBox
imay commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-456638189 > The reason for curl failed is `HttpServerHandler.channelReadComplete` close the connect early. we shouldn't close ctx even if the action is n

Podling Report Reminder - February 2019

2019-01-22 Thread jmclean
Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 20 February 2019, 10:30 am PDT. The report for your podling will for

Re: Does Doris need new mentor?

2019-01-22 Thread ShaoFeng Shi
Hello Morningman, Mingyu,Chun,Chaoyong,De,Willem, Dave, I'm happy to do that; It's my pleasure! As my name is already on the IPMC list [1], so I think I'm qualified to do this [2]. If the current podling think you need a discussion and voting, I can wait :) In the meanwhile, I quickly went throu

[GitHub] kangkaisen commented on issue #549: Add a colocate join meta repair tool

2019-01-22 Thread GitBox
kangkaisen commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-456400620 The reason for curl failed is `HttpServerHandler.channelReadComplete` close the connect early. we shouldn't close ctx even if the actio

[GitHub] kangkaisen commented on issue #562: Add ColocateMetaService

2019-01-22 Thread GitBox
kangkaisen commented on issue #562: Add ColocateMetaService URL: https://github.com/apache/incubator-doris/pull/562#issuecomment-456396891 Update the PR. ready for review. This is an automated message from the Apache Git Servi

[GitHub] chaoyli merged pull request #536: Add Rowset and RowsetBuilder for PushHandler

2019-01-22 Thread GitBox
chaoyli merged pull request #536: Add Rowset and RowsetBuilder for PushHandler URL: https://github.com/apache/incubator-doris/pull/536 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] chaoyli commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler

2019-01-22 Thread GitBox
chaoyli commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler URL: https://github.com/apache/incubator-doris/pull/536#discussion_r249742246 ## File path: be/src/olap/push_handler.cpp ## @@ -54,10 +57,59 @@ OLAPStatus PushHandler::process_

[GitHub] chaoyli commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler

2019-01-22 Thread GitBox
chaoyli commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler URL: https://github.com/apache/incubator-doris/pull/536#discussion_r249741597 ## File path: be/src/olap/delta_writer.cpp ## @@ -115,9 +121,9 @@ OLAPStatus DeltaWriter::init() {

[GitHub] chaoyli commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler

2019-01-22 Thread GitBox
chaoyli commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler URL: https://github.com/apache/incubator-doris/pull/536#discussion_r249742356 ## File path: be/src/olap/delta_writer.cpp ## @@ -96,8 +97,13 @@ OLAPStatus DeltaWriter::init() {

[GitHub] chaoyli commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler

2019-01-22 Thread GitBox
chaoyli commented on a change in pull request #536: Add Rowset and RowsetBuilder for PushHandler URL: https://github.com/apache/incubator-doris/pull/536#discussion_r249741856 ## File path: be/src/olap/push_handler.cpp ## @@ -330,69 +339,55 @@ OLAPStatus PushHandler::_conve

[GitHub] imay merged pull request #570: Fix sync and trash bug

2019-01-22 Thread GitBox
imay merged pull request #570: Fix sync and trash bug URL: https://github.com/apache/incubator-doris/pull/570 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use t

[GitHub] chaoyli opened a new pull request #570: Fix sync and trash bug

2019-01-22 Thread GitBox
chaoyli opened a new pull request #570: Fix sync and trash bug URL: https://github.com/apache/incubator-doris/pull/570 1. no need to save header when header has no incremental delta 2. make fsync tablet_meta configurable 3. add metric for meta operation ---

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249743428 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -0,0 +1,133 @@ +// Licensed to the Apache S

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249739808 ## File path: be/src/olap/storage_engine.cpp ## @@ -115,96 +115,140 @@ StorageEngine::~StorageEngine() { cl

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249740794 ## File path: be/src/olap/storage_engine.cpp ## @@ -115,96 +115,140 @@ StorageEngine::~StorageEngine() { cl

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249741719 ## File path: be/src/olap/storage_engine.cpp ## @@ -1002,4 +956,60 @@ OLAPStatus StorageEngine::load_header(

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249740335 ## File path: be/src/olap/storage_engine.cpp ## @@ -115,96 +115,140 @@ StorageEngine::~StorageEngine() { cl

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249740272 ## File path: be/src/olap/storage_engine.cpp ## @@ -115,96 +115,140 @@ StorageEngine::~StorageEngine() { cl

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249739998 ## File path: be/src/olap/storage_engine.cpp ## @@ -115,96 +115,140 @@ StorageEngine::~StorageEngine() { cl

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249740168 ## File path: be/src/olap/storage_engine.cpp ## @@ -115,96 +115,140 @@ StorageEngine::~StorageEngine() { cl

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249739231 ## File path: be/src/olap/push_handler.cpp ## @@ -234,20 +234,16 @@ OLAPStatus PushHandler::process_realtime_pus

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249742284 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -0,0 +1,133 @@ +// Licensed to the Apache S

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249739035 ## File path: be/src/olap/delta_writer.cpp ## @@ -45,12 +45,11 @@ DeltaWriter::~DeltaWriter() { } void Delta

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249738632 ## File path: be/src/agent/task_worker_pool.cpp ## @@ -533,7 +534,8 @@ void* TaskWorkerPool::_alter_tablet_work

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249743759 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -0,0 +1,133 @@ +// Licensed to the Apache S

[GitHub] kangpinghuang commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
kangpinghuang commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249744156 ## File path: be/src/olap/txn_manager.cpp ## @@ -190,17 +188,13 @@ void TxnManager::get_txn_related_tablets(cons

[GitHub] kangkaisen commented on issue #549: Add a colocate join meta repair tool

2019-01-22 Thread GitBox
kangkaisen commented on issue #549: Add a colocate join meta repair tool URL: https://github.com/apache/incubator-doris/issues/549#issuecomment-456354202 After read Netty source code and debugged, I have found out the reason for all issues. I will do a full test, update the PR and explain a

[GitHub] morningman merged pull request #569: Fix replica version report bug

2019-01-22 Thread GitBox
morningman merged pull request #569: Fix replica version report bug URL: https://github.com/apache/incubator-doris/pull/569 This is an automated message from the Apache Git Service. To respond to the message, please log on Gi

[GitHub] morningman opened a new pull request #569: Fix replica version report bug

2019-01-22 Thread GitBox
morningman opened a new pull request #569: Fix replica version report bug URL: https://github.com/apache/incubator-doris/pull/569 Replica with version hash equals to 0 should be handled correctly. This is an automated message

[GitHub] yiguolei commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
yiguolei commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249676776 ## File path: be/src/olap/storage_engine.cpp ## @@ -115,96 +115,140 @@ StorageEngine::~StorageEngine() { clear();

[GitHub] yiguolei commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
yiguolei commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249676832 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -0,0 +1,132 @@ +// Licensed to the Apache Softwar

[GitHub] yiguolei commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
yiguolei commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249676798 ## File path: be/src/olap/storage_engine.cpp ## @@ -115,96 +115,140 @@ StorageEngine::~StorageEngine() { clear();

[GitHub] yiguolei commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
yiguolei commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249676407 ## File path: be/src/olap/storage_engine.cpp ## @@ -1002,4 +956,60 @@ OLAPStatus StorageEngine::load_header( retu

[GitHub] yiguolei commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
yiguolei commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249676478 ## File path: be/src/olap/task/engine_publish_version_task.h ## @@ -0,0 +1,43 @@ +// Licensed to the Apache Software F

[GitHub] yiguolei commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
yiguolei commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249676161 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -0,0 +1,132 @@ +// Licensed to the Apache Softwar

[GitHub] yiguolei commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
yiguolei commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249675807 ## File path: be/src/olap/task/engine_publish_version_task.h ## @@ -0,0 +1,43 @@ +// Licensed to the Apache Software F

[GitHub] yiguolei commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
yiguolei commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249675704 ## File path: be/src/olap/txn_manager.cpp ## @@ -126,9 +126,8 @@ OLAPStatus TxnManager::add_txn( return OLAP_SUCC

[GitHub] chaoyli commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
chaoyli commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249671895 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -0,0 +1,132 @@ +// Licensed to the Apache Software

[GitHub] chaoyli commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
chaoyli commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249670915 ## File path: be/src/olap/txn_manager.cpp ## @@ -126,9 +126,8 @@ OLAPStatus TxnManager::add_txn( return OLAP_SUCCE

[GitHub] chaoyli commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
chaoyli commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249671750 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -0,0 +1,132 @@ +// Licensed to the Apache Software

[GitHub] chaoyli commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
chaoyli commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249671146 ## File path: be/src/olap/task/engine_publish_version_task.cpp ## @@ -0,0 +1,132 @@ +// Licensed to the Apache Software

[GitHub] chaoyli commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
chaoyli commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249673477 ## File path: be/src/olap/storage_engine.cpp ## @@ -1002,4 +956,60 @@ OLAPStatus StorageEngine::load_header( retur

[GitHub] chaoyli commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
chaoyli commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249668036 ## File path: be/src/olap/txn_manager.cpp ## @@ -190,11 +189,7 @@ void TxnManager::get_txn_related_tablets(const TTran

[GitHub] chaoyli commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
chaoyli commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249674001 ## File path: be/src/olap/task/engine_publish_version_task.h ## @@ -0,0 +1,43 @@ +// Licensed to the Apache Software Fo

[GitHub] chaoyli commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
chaoyli commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249672471 ## File path: be/src/olap/storage_engine.cpp ## @@ -115,96 +115,140 @@ StorageEngine::~StorageEngine() { clear();

[GitHub] chaoyli commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
chaoyli commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249672800 ## File path: be/src/olap/storage_engine.cpp ## @@ -115,96 +115,140 @@ StorageEngine::~StorageEngine() { clear();

[GitHub] chaoyli commented on a change in pull request #567: Add publish version task

2019-01-22 Thread GitBox
chaoyli commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249671037 ## File path: be/src/olap/task/engine_publish_version_task.h ## @@ -0,0 +1,43 @@ +// Licensed to the Apache Software Fo