chaoyli commented on a change in pull request #567: Add publish version task URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249672471
########## File path: be/src/olap/storage_engine.cpp ########## @@ -115,96 +115,140 @@ StorageEngine::~StorageEngine() { clear(); } +// TODO(ygl): deal with rowsets and tablets when load failed OLAPStatus StorageEngine::_load_data_dir(DataDir* data_dir) { std::string data_dir_path = data_dir->path(); LOG(INFO) <<"start to load tablets from data_dir_path:" << data_dir_path; - bool is_header_converted = false; OLAPStatus res = TabletMetaManager::get_header_converted(data_dir, is_header_converted); Review comment: &is_header_converted ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org