yiguolei commented on a change in pull request #567: Add publish version task
URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249675704
##########
File path: be/src/olap/txn_manager.cpp
##########
@@ -126,9 +126,8 @@ OLAPStatus TxnManager::add_txn(
return OLAP_SUCCESS;
}
-OLAPStatus TxnManager::delete_txn(
- TPartitionId partition_id, TTransactionId transaction_id,
- TTabletId tablet_id, SchemaHash schema_hash) {
+OLAPStatus TxnManager::delete_txn(TPartitionId partition_id, TTransactionId
transaction_id,
+ TTabletId tablet_id, SchemaHash schema_hash)
{
pair<int64_t, int64_t> key(partition_id, transaction_id);
TabletInfo tablet_info(tablet_id, schema_hash);
Review comment:
delete txn should not do clear pending data task, because a txn is published
and will call delete_txn, if clear pending rowset, then the visible data is
deleted.
the caller method should call rowset. remove to delete the data. or add the
delete rowset to a queue and write a single gc thread to gc it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
