kangpinghuang commented on a change in pull request #567: Add publish version
task
URL: https://github.com/apache/incubator-doris/pull/567#discussion_r249739035
##########
File path: be/src/olap/delta_writer.cpp
##########
@@ -45,12 +45,11 @@ DeltaWriter::~DeltaWriter() {
}
void DeltaWriter::_garbage_collection() {
- StorageEngine::instance()->delete_transaction(_req.partition_id,
_req.txn_id,
- _req.tablet_id,
_req.schema_hash);
+ TxnManager::instance()->delete_txn(_req.partition_id,
_req.txn_id,_req.tablet_id, _req.schema_hash);
StorageEngine::instance()->add_unused_rowset(_cur_rowset);
if (_related_tablet != nullptr) {
- StorageEngine::instance()->delete_transaction(_req.partition_id,
_req.txn_id,
-
_related_tablet->tablet_id(), _related_tablet->schema_hash());
+ TxnManager::instance()->delete_txn(_req.partition_id, _req.txn_id,
Review comment:
additional empty space
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
